fix: address PHP 8.2 deprecation warnings and improve AI API robustness (#1131)

jepeng-miao · web-flow · commit f51a49a6c57d · 2026-02-13T07:39:18.000+08:00
* 修复reinfo.php 中的 PHP 警告和弃用错误

修复内容：
这些错误主要是由于在 PHP 8.1+ 环境下，代码尝试访问不存在的数组键（ Undefined array key "error" ）以及将 null 传递给字符串函数（如 strpos , strlen , str_replace ）导致的。

1. 修复 is_valid() 函数 :
   - 在 reinfo.php:L20-25 中增加了对输入参数 $str2 的空值检查。如果 $str2 为 null （例如当数据库中没有运行错误记录时），函数将直接返回 false ，从而避免了 strlen() 和 str_split() 报错。
2. 优化 runtimeinfo 数据处理 :
   - 在 reinfo.php:L81-91 中，引入了 $error_info 变量来安全地获取运行错误信息。
   - 使用了空接合操作符 ( ?? "" ) 确保在调用 str_replace 和 htmlentities 时，即使没有错误信息，传递的也是空字符串而不是 null 。
   - 在调用 strpos() 之前增加了 $error_info !== null 的判断，彻底解决了 Undefined array key 和 Deprecated 警告。
3. 消除变量冲突 :
   - 原代码重复使用了 $row 变量，导致 solution 表的数据和 runtimeinfo 表的数据混淆。现在使用了独立的 $row_runtime 变量，使逻辑更加清晰且安全。

* fix(admin): 修复公告编辑中的未定义键警告与 Header 已发送错误

- 增加对 $_POST['showInMenu'] 的 isset 检查，解决未勾选复选框时的警告。
- 引入 ob_start() 并将 header 跳转改为 JS alert + location 方式，彻底解决 "headers already sent" 问题。
- 优化代码结构，将数据查询逻辑移至 kindeditor 包含之前。
- 清理 textarea 渲染时的多余空白字符。

* fix(admin): 修复公告保存逻辑中的警告并增加保存成功提醒

- 增加 ob_start() 确保输出缓冲。
- 修复 $_POST['showInMenu'] 的未定义键警告。
- 将保存后的跳转方式改为带提醒的 JS 跳转，提升用户体验并避免跳转失效。

* fix(admin): 公告添加页面增加输出缓冲以防止提前输出

- 在文件顶部增加 ob_start()，确保在包含 admin-header.php 或其他包含文件时不会因意外输出导致 header 相关错误。

* fix(admin): 清理 KindEditor 包含文件头部的多余空格

- 移除文件开头的空白字符，防止该文件被其他 PHP 脚本 include 时触发提前输出，从而引发 "Cannot modify header information" 错误。
diff --git a/trunk/web/admin/kindeditor.php b/trunk/web/admin/kindeditor.php
@@ -1,4 +1,4 @@
-        <meta charset="utf-8" />
+<meta charset="utf-8" />
         <link rel="stylesheet" href="../kindeditor/themes/default/default.css" />
         <link rel="stylesheet" href="../kindeditor/plugins/code/prettify.css" />
         <script charset="utf-8" src="../kindeditor/kindeditor.js?v=20251217"></script>
diff --git a/trunk/web/admin/news_add.php b/trunk/web/admin/news_add.php
@@ -1,4 +1,5 @@
 <?php
+ob_start();
 require_once ("admin-header.php");
 require_once("../include/check_post_key.php");
 if(!(isset($_SESSION[$OJ_NAME.'_'.'administrator']))){
@@ -12,7 +13,7 @@
 //contest_id
 $title = $_POST['title'];
 $content = $_POST['content'];
-$showInMenu = $_POST['showInMenu'];
+$showInMenu = isset($_POST['showInMenu']) ? $_POST['showInMenu'] : "";
 $menu = $showInMenu == "on" ? 1 : 0;
 
 $user_id = $_SESSION[$OJ_NAME.'_'.'user_id'];
@@ -30,5 +31,5 @@
 $sessionDataKey = $OJ_NAME.'_'."_MENU_NEWS_CACHE";
 unset($_SESSION[$sessionDataKey]);
 
-echo "<script>window.location.href=\"news_list.php\";</script>";
+echo "<script>alert('保存成功！');window.location.href=\"news_list.php\";</script>";
 ?>
diff --git a/trunk/web/admin/news_add_page.php b/trunk/web/admin/news_add_page.php
@@ -1,4 +1,5 @@
 <?php
+ob_start();
 require_once("admin-header.php");
 if(!(isset($_SESSION[$OJ_NAME.'_'.'administrator']))){
   echo "<a href='../loginpage.php'>Please Login First!</a>";
diff --git a/trunk/web/admin/news_edit.php b/trunk/web/admin/news_edit.php
@@ -1,80 +1,101 @@
 <?php
+ob_start();
 require_once("admin-header.php");
 if(!(isset($_SESSION[$OJ_NAME.'_'.'administrator']))){
   echo "<a href='../loginpage.php'>Please Login First!</a>";
   exit(1);
 }
 
-require_once("../include/db_info.inc.php");
-require_once("../include/my_func.inc.php");
-
 echo "<hr>";
-echo "<center><h3>".$MSG_NEWS."-"."Edit"."</h3></center>";
+echo "<center><h3>".$MSG_NEWS."-".$MSG_ADD."</h3></center>";
 
 include_once("kindeditor.php");
 ?>
 
-<div class="padding">
 <?php
-if(isset($_POST['news_id'])){
-  require_once("../include/check_post_key.php");
-
-  $title = $_POST['title'];
-  $content = $_POST['content'];
-  $showInMenu = $_POST['showInMenu'];
-  $menu = $showInMenu == "on" ? 1 : 0;
-
-  $content = str_replace("<p>", "", $content);
-  $content = str_replace("</p>", "<br />", $content);
-//  $content = str_replace(",", "&#44;", $content);
-
-  $user_id = $_SESSION[$OJ_NAME.'_'.'user_id'];
-  $news_id = intval($_POST['news_id']);
-
-  $sql = "UPDATE `news` SET `title`=?,`time`=now(),`content`=?,user_id=?,`menu`=? WHERE `news_id`=?";
-  //echo $sql;
-  pdo_query($sql,$title,$content,$user_id,$menu,$news_id);
-  $sessionDataKey = $OJ_NAME.'_'."_MENU_NEWS_CACHE";
-  unset($_SESSION[$sessionDataKey]);
-  header("location:news_list.php");
-  exit();
-}else{
-  $news_id = intval($_GET['id']);
-  $sql = "SELECT * FROM `news` WHERE `news_id`=?";
-  $result = pdo_query($sql,$news_id);
-  if(count($result)!=1){
-    echo "No such News!";
-    exit(0);
-  }
-
+if(isset($_GET['cid'])){
+  $cid = intval($_GET['cid']);
+  $sql = "SELECT * FROM news WHERE `news_id`=?";
+  $result = pdo_query($sql,$cid);
   $row = $result[0];
-
-  $title = htmlentities($row['title'],ENT_QUOTES,"UTF-8");
+  $title = $row['title'];
   $content = $row['content'];
-  $showInMenu = $row['menu'] == 1;
+  $defunct = $row['defunct'];
+}
+$plist = "";
+if(isset($_POST['pid'])){
+	sort($_POST['pid']);
+	foreach($_POST['pid'] as $i){
+	  if($plist)
+	    $plist.=','.intval($i);
+	  else
+	    $plist = $i;
+	}
+	
+  if(isset($_POST['hlist']))$plist = trim($_POST['hlist']);
+  $pieces = explode(",",$plist );
+  $pieces = array_unique($pieces);
+  if($pieces[0]=="") unset($pieces[0]);
+  $plist=implode(",",$pieces);
+
+	  $content="[plist=".$plist."]".htmlentities($_POST['keyword'],ENT_QUOTES,"utf-8")."[/plist]";
 }
 ?>
 
-  <form method=POST action=news_edit.php>
-    <input type=hidden name='news_id' value=<?php echo $news_id?>>
+<div class="padding">
+  <form method=POST action=news_add.php>
     <p align=left>
       <label class="col control-label"><?php echo $MSG_TITLE?></label>
-      <input type=text name=title size=71 value='<?php echo $title?>'>
+	  <input class="input input-large" style="width:100%;" size=71 value='<?php echo isset($title)?$title."-Copy":""?>' type=text name='title' id='title' > 
+	  <input type=submit class='btn btn-success' value='<?php echo $MSG_SAVE?>' name=submit> 
+	  <input class='btn btn-primary' id='ai_bt' type=button value='AI一下' onclick='ai_gen()' >
+	  <input class='btn btn-danger'  type=reset value='<?php echo $MSG_RESET?>' onclick='setTimeout("ai_gen()",500);' >
     </p>
     <p align=left>
       <label class="col control-label"><?php echo $MSG_NEWS_MENU?>
-        <input style="display: inline-block;" type="checkbox" name=showInMenu <?php if($showInMenu) { echo "checked"; } ?> />
+        <input style="display: inline-block;" type="checkbox" name=showInMenu />
       </label>
     </p>
     <p align=left>
-      <textarea class=kindeditor name=content rows=41 ><?php echo htmlentities($content,ENT_QUOTES,"UTF-8")?>
+      <textarea class=kindeditor name=content rows=41 >
+        <?php echo isset($content)?$content:""?>
       </textarea>
     </p>
-    <?php require_once("../include/set_post_key.php");?>
     <p>
       <center>
       <input type=submit value='<?php echo $MSG_SAVE?>' name=submit>
       </center>
     </p>
+    <?php require_once("../include/set_post_key.php");?>
   </form>
 </div>
+<script>
+
+	function ai_gen(filename){
+		    let oldval=$('#ai_bt').val();
+		    $('#ai_bt').val('AI思考中...请稍候...');
+		    $('#ai_bt').prop('disabled', true);;
+		    let title=$('#title').val();
+		    $.ajax({
+		    	url: '../<?php echo $OJ_AI_API_URL?>', 
+			type: 'GET',
+			data: { title: title },
+			success: function(data) {
+			    console.log(title);
+			    if(title==""){
+				    $('#title').val(data);
+			    }else{
+				    let description="<span class='md'>"+(data)+"</span>";
+				    let preview=$("#previewFrame").contents();
+				    $("textarea").eq(0).val(description); // 假设 #file_data 是 div
+			    }
+		    	    $('#ai_bt').prop('disabled', false);;
+			    $('#ai_bt').val('AI一下');
+			},
+			error: function() {
+			    $('#ai_bt').val('获取数据失败');
+		    	    $('#ai_bt').prop('disabled', false);;
+			}
+		    });
+	}
+</script>
diff --git a/trunk/web/reinfo.php b/trunk/web/reinfo.php
@@ -19,6 +19,7 @@
 function is_valid($str2)
 {
     global $_SESSION, $OJ_NAME, $OJ_FRIENDLY_LEVEL;
+    if ($str2 === null) return false;
     if (isset($_SESSION[$OJ_NAME . '_' . 'source_browser'])) return true;
     //return true; // 如果希望能让任何人都查看对比和RE,放开行首注释，并设定$OJ_SHOW_DIFF=true; if you fail to view diff , try remove the // at beginning of this line.
     if ($OJ_FRIENDLY_LEVEL > 3) return true;
@@ -79,16 +80,18 @@ function is_valid($str2)
     $sql = "SELECT `error` FROM `runtimeinfo` WHERE `solution_id`=?";
     $result = pdo_query($sql, $id);
 
+    $error_info = null;
     if (isset($result[0])) {
-        $row = $result[0];
-        $view_reinfo = htmlentities(str_replace("\n\r", "\n", $row['error']), ENT_QUOTES, "UTF-8");
+        $row_runtime = $result[0];
+        $error_info = $row_runtime['error'];
+        $view_reinfo = htmlentities(str_replace("\n\r", "\n", $error_info ?? ""), ENT_QUOTES, "UTF-8");
     }
 
-    if (strpos($row['error'], "judge/") !== false && !isset($_SESSION[$OJ_NAME . "_administrator"])) $view_reinfo = "潜在的数组或指针越界，请检查代码。";
-    else if (strpos($row['error'], "php") !== false) $view_reinfo = "error2";
-    else if (strpos($row['error'], "PASS") !== false) $view_reinfo = "error3";
-    else if ($OJ_SHOW_DIFF && $row && ($ok || $isRE) && ($OJ_TEST_RUN || is_valid($row['error']) || $ok)) {
-        $view_reinfo = htmlentities(str_replace("\n\r", "\n", $row['error']), ENT_QUOTES, "UTF-8");
+    if ($error_info !== null && strpos($error_info, "judge/") !== false && !isset($_SESSION[$OJ_NAME . "_administrator"])) $view_reinfo = "潜在的数组或指针越界，请检查代码。";
+    else if ($error_info !== null && strpos($error_info, "php") !== false) $view_reinfo = "error2";
+    else if ($error_info !== null && strpos($error_info, "PASS") !== false) $view_reinfo = "error3";
+    else if ($OJ_SHOW_DIFF && $row && ($ok || $isRE) && ($OJ_TEST_RUN || is_valid($error_info) || $ok)) {
+        $view_reinfo = htmlentities(str_replace("\n\r", "\n", $error_info ?? ""), ENT_QUOTES, "UTF-8");
 
         $view_reinfo .= "<br>$MSG_MARK:$mark";
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`- <meta charset="utf-8" />`
	`1`	`+<meta charset="utf-8" />`
`2`	`2`	`<link rel="stylesheet" href="../kindeditor/themes/default/default.css" />`
`3`	`3`	`<link rel="stylesheet" href="../kindeditor/plugins/code/prettify.css" />`
`4`	`4`	`<script charset="utf-8" src="../kindeditor/kindeditor.js?v=20251217"></script>`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`<?php`
	`2`	`+ob_start();`
`2`	`3`	`require_once("admin-header.php");`
`3`	`4`	`if(!(isset($_SESSION[$OJ_NAME.'_'.'administrator']))){`
`4`	`5`	`echo "<a href='../loginpage.php'>Please Login First!</a>";`