Fix diffusion shadow (AMReX-Astro#3068)

some loop counters were also uninitialized.
this also fixes a few compiler warnings.

Author: zingale

Exec/unit_tests/diffusion_test/Prob.cpp

@@ -20,9 +20,6 @@ void Castro::problem_post_simulation(Vector<std::unique_ptr<AmrLevel> >& amr_lev
     Castro& castro = dynamic_cast<Castro&>(*amr_level[n]);
     Real time = castro.get_state_data(State_Type).curTime();
 
-    auto domain_lo = castro.geom.Domain().loVect3d();
-    auto domain_hi = castro.geom.Domain().hiVect3d();
-
     // the state data
     MultiFab& S = castro.get_new_data(State_Type);
 

Exec/unit_tests/diffusion_test/Problem_Derive.cpp

@@ -8,8 +8,8 @@
 using namespace amrex;
 
 
-void deranalytic(const Box& bx, FArrayBox& derfab, int dcomp, int /*ncomp*/,
-                 const FArrayBox& datfab, const Geometry& geomdata,
+void deranalytic(const Box& bx, FArrayBox& derfab, int /*dcomp*/, int /*ncomp*/,
+                 const FArrayBox& /*datfab*/, const Geometry& geomdata,
                  Real time, const int* /*bcrec*/, int /*level*/)
 {
 
@@ -18,7 +18,6 @@ void deranalytic(const Box& bx, FArrayBox& derfab, int dcomp, int /*ncomp*/,
 
     const int coord_type = geomdata.Coord();
 
-    auto const dat = datfab.array();
     auto const der = derfab.array();
 
     amrex::ParallelFor(bx,
@@ -33,8 +32,8 @@ void deranalytic(const Box& bx, FArrayBox& derfab, int dcomp, int /*ncomp*/,
         r[2] = problo[2] + dx[2] * (static_cast<Real>(k) + 0.5_rt);
 #endif
         if (coord_type <= 1) {
-            for (int i; i < AMREX_SPACEDIM; ++i) {
-                r[i] -= problem::center[i];
+            for (int n = 0; n < AMREX_SPACEDIM; ++n) {
+                r[n] -= problem::center[n];
             }
         }
 

Exec/unit_tests/diffusion_test/problem_bc_fill.H

@@ -41,8 +41,8 @@ void problem_bc_fill(int i, int j, int k,
     r[2] = problo[2] + dx[2] * (static_cast<Real>(k) + 0.5_rt);
 #endif
     if (coord <= 1) {
-        for (int i; i < AMREX_SPACEDIM; ++i) {
-            r[i] -= problem::center[i];
+        for (int n = 0; n < AMREX_SPACEDIM; ++n) {
+            r[n] -= problem::center[n];
         }
     }
 

Exec/unit_tests/diffusion_test/problem_initialize_state_data.H

@@ -25,8 +25,8 @@ void problem_initialize_state_data (int i, int j, int k,
     r[2] = problo[2] + dx[2] * (static_cast<Real>(k) + 0.5_rt);
 #endif
     if (coord_type <= 1) {
-        for (int i; i < AMREX_SPACEDIM; ++i) {
-            r[i] -= problem::center[i];
+        for (int n = 0; n < AMREX_SPACEDIM; ++n) {
+            r[n] -= problem::center[n];
         }
     }