Skip to content

Commit 082661b

Browse files
committed
Circumvented issue with installing pywinpty on py38; Added py38/win/latest
Signed-off-by: Andreas Maier <maiera@de.ibm.com>
1 parent 30947be commit 082661b

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,11 @@ jobs:
106106
\"python-version\": \"3.8\", \
107107
\"package_level\": \"minimum\" \
108108
}, \
109+
{ \
110+
\"os\": \"windows-latest\", \
111+
\"python-version\": \"3.8\", \
112+
\"package_level\": \"latest\" \
113+
}, \
109114
{ \
110115
\"os\": \"windows-latest\", \
111116
\"python-version\": \"3.13.0\", \

changes/noissue.6.fix.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Circumvented an issue when installing pywinpty 2.0.14 with latest version of
2+
maturin on Python 3.8, by excluding pywinpty 2.0.14.

dev-requirements.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,11 @@ pip-check-reqs>=2.5.1; python_version >= '3.9'
175175

176176
# pywinpty is used by terminado <- notebook <- jupyter
177177
# pywinpty>=1.0 requires maturin to build. Meanwhile, it works.
178-
pywinpty>=2.0.12; os_name == "nt"
178+
# pywinpty 2.0.14 has an issue with latest maturin on Python 3.8, see https://github.com/andfoy/pywinpty/issues/486
179+
# pywinpty 2.0.12/13 has the above issue on Python 3.13
180+
pywinpty>=2.0.12,!=2.0.14; os_name == "nt" and python_version == '3.8'
181+
pywinpty>=2.0.12; os_name == "nt" and python_version >= '3.9' and python_version <= '3.12'
182+
pywinpty>=2.0.14; os_name == "nt" and python_version >= '3.13'
179183

180184
# pytz is actually covered in requirements.txt, but we need to repeat it here
181185
# because development packages pull it in, so the exclusion of 2024.2 is active

minimum-constraints-develop.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,8 @@ pip-check-reqs==2.4.3; python_version <= '3.8'
145145
pip-check-reqs==2.5.1; python_version >= '3.9'
146146

147147
# pywinpty is used by terminado <- notebook <- jupyter
148-
pywinpty==2.0.12; os_name == "nt"
148+
pywinpty==2.0.12; os_name == "nt" and python_version >= '3.8' and python_version <= '3.12'
149+
pywinpty==2.0.14; os_name == "nt" and python_version >= '3.13'
149150

150151
# Indirect dependencies for development that are not in dev-requirements.txt
151152

0 commit comments

Comments
 (0)