Skip to content

Commit 768b6af

Browse files
committed
Circumvented issue with installing pywinpty on py38; Added py38/win/latest
Signed-off-by: Andreas Maier <maiera@de.ibm.com>
1 parent 94f2337 commit 768b6af

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,11 @@ jobs:
103103
\"python-version\": \"3.8\", \
104104
\"package_level\": \"minimum\" \
105105
}, \
106+
{ \
107+
\"os\": \"windows-latest\", \
108+
\"python-version\": \"3.8\", \
109+
\"package_level\": \"latest\" \
110+
}, \
106111
{ \
107112
\"os\": \"windows-latest\", \
108113
\"python-version\": \"3.13\", \

changes/noissue.6.fix.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Circumvented an issue when installing pywinpty 2.0.14 with latest version of
2+
maturin on Python 3.8, by excluding pywinpty 2.0.14.

dev-requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,8 @@ pip-check-reqs>=2.5.1; python_version >= '3.9'
175175

176176
# pywinpty is used by terminado <- notebook <- jupyter
177177
# pywinpty>=1.0 requires maturin to build. Meanwhile, it works.
178-
pywinpty>=2.0.12; os_name == "nt"
178+
# pywinpty 2.0.14 has an issue with latest maturin, see https://github.com/andfoy/pywinpty/issues/486
179+
pywinpty>=2.0.12,!=2.0.14; os_name == "nt"
179180

180181
# pytz is actually covered in requirements.txt, but we need to repeat it here
181182
# because development packages pull it in, so the exclusion of 2024.2 is active

0 commit comments

Comments
 (0)