Skip to content

Commit 01ab536

Browse files
authored
[megatron] fix: correct typo in modeling_qwen2_megatron.py (verl-project#4486)
### What does this PR do? > This PR corrects a spelling error in the docstring of the `setup_embeddings_and_output_layer` method within `verl/models/qwen2/megatron/modeling_qwen2_megatron.py`. Specifically, it changes `initalizes` to `initializes`. ### Checklist Before Starting - [x] Search for similar PRs. Paste at least one query link here: https://github.com/volcengine/verl/pulls?q=is%3Apr+typo+modeling_qwen2_megatron - [x] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - Title: `[megatron] fix: correct typo in modeling_qwen2_megatron.py` ### Test > This is a trivial documentation fix (docstring only) and does not affect runtime logic. > - Visual inspection of the change. ### API and Usage Example > N/A - This change only affects internal code documentation. ### Design & Code Changes > **Modifications:** > - `verl/models/qwen2/megatron/modeling_qwen2_megatron.py`: Fixed typo `initalizes` -> `initializes`. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [x] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [x] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). (N/A) - [x] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: Trivial docstring fix. - [] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ).
1 parent d8195a8 commit 01ab536

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

verl/models/qwen2/megatron/modeling_qwen2_megatron.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@ def _init_head(self, config):
583583
def setup_embeddings_and_output_layer(self) -> None:
584584
"""Sets up embedding layer in first stage and output layer in last stage.
585585
586-
This function initalizes word embeddings in the final stage when we are
586+
This function initializes word embeddings in the final stage when we are
587587
using pipeline parallelism and sharing word embeddings, and sets up param
588588
attributes on the embedding and output layers.
589589
"""

0 commit comments

Comments
 (0)