Skip to content

Commit 7cf31bf

Browse files
authored
[perf] fix: fix npu profiling scripts (verl-project#5226)
### What does this PR do? fix npu profiling scripts ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [ ] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`.
1 parent 28688e7 commit 7cf31bf

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

examples/grpo_trainer/run_qwen2_5_7b_grpo_discrete_prof_npu.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@ python3 -m verl.trainer.main_ppo \
4343
actor_rollout_ref.rollout.log_prob_micro_batch_size_per_gpu=1 \
4444
actor_rollout_ref.rollout.tensor_model_parallel_size=4 \
4545
actor_rollout_ref.rollout.name=vllm \
46-
actor_rollout_ref.rollout.gpu_memory_utilization=0.3 \
46+
actor_rollout_ref.rollout.gpu_memory_utilization=0.6 \
4747
actor_rollout_ref.rollout.n=4 \
4848
actor_rollout_ref.rollout.enable_chunked_prefill=False \
49+
actor_rollout_ref.rollout.checkpoint_engine.update_weights_bucket_megabytes=4096 \
4950
actor_rollout_ref.ref.log_prob_micro_batch_size_per_gpu=1 \
5051
actor_rollout_ref.ref.fsdp_config.param_offload=True \
5152
actor_rollout_ref.ref.profiler.enable=True \

examples/grpo_trainer/run_qwen2_5_7b_grpo_e2e_prof_npu.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,10 @@ python3 -m verl.trainer.main_ppo \
4141
actor_rollout_ref.rollout.log_prob_micro_batch_size_per_gpu=1 \
4242
actor_rollout_ref.rollout.tensor_model_parallel_size=4 \
4343
actor_rollout_ref.rollout.name=vllm \
44-
actor_rollout_ref.rollout.gpu_memory_utilization=0.3 \
44+
actor_rollout_ref.rollout.gpu_memory_utilization=0.6 \
4545
actor_rollout_ref.rollout.n=4 \
4646
actor_rollout_ref.rollout.enable_chunked_prefill=False \
47+
actor_rollout_ref.rollout.checkpoint_engine.update_weights_bucket_megabytes=4096 \
4748
actor_rollout_ref.ref.log_prob_micro_batch_size_per_gpu=1 \
4849
actor_rollout_ref.ref.fsdp_config.param_offload=True \
4950
actor_rollout_ref.ref.profiler.enable=True \

0 commit comments

Comments
 (0)