Skip to content

Commit b63fe7f

Browse files
authored
[trainer] fix: resolve dataset config in agent loop (verl-project#5034)
### What does this PR do? line 516: `dataset_config=self.config.data` https://github.com/volcengine/verl/blob/772c224935d136b05f5f2d10ddaa6d3b7a41403c/verl/experimental/agent_loop/agent_loop.py#L509-L517 self.config.data may have unresolved arguments like `'tool_config_path': '${oc.select:actor_rollout_ref.rollout.multi_turn.tool_config_path, null}'`, which cannot be instantiated. This will cause error ``` *** omegaconf.errors.InterpolationResolutionError: TypeError raised while resolving interpolation: Index 'actor_rollout_ref' (str) is not an int ``` ### Solution: Wrap it in DictConfigWrap, so that it will not be initialized in hydra resolve config. ### Checklist Before Starting - [ ] Search for similar PRs. Paste at least one query link here: ... - [ ] Format the PR title as `[{modules}] {type}: {description}` (This will be checked by the CI) - `{modules}` include `fsdp`, `megatron`, `veomni`, `sglang`, `vllm`, `rollout`, `trainer`, `ci`, `training_utils`, `recipe`, `hardware`, `deployment`, `ray`, `worker`, `single_controller`, `misc`, `perf`, `model`, `algo`, `env`, `tool`, `ckpt`, `doc`, `data`, `cfg`, `reward` - If this PR involves multiple modules, separate them with `,` like `[megatron, fsdp, doc]` - `{type}` is in `feat`, `fix`, `refactor`, `chore`, `test` - If this PR breaks any API (CLI arguments, config, function signature, etc.), add `[BREAKING]` to the beginning of the title. - Example: `[BREAKING][fsdp, megatron] feat: dynamic batching` ### Test > For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc. ### API and Usage Example > Demonstrate how the API changes if any, and provide usage example(s) if possible. ```python # Add code snippet or script demonstrating how to use this ``` ### Design & Code Changes > Demonstrate the high-level design if this PR is complex, and list the specific changes. ### Checklist Before Submitting > [!IMPORTANT] > Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review. - [ ] Read the [Contribute Guide](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md). - [ ] Apply [pre-commit checks](https://github.com/volcengine/verl/blob/main/CONTRIBUTING.md#code-linting-and-formatting): `pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always` - [ ] Add / Update [the documentation](https://github.com/volcengine/verl/tree/main/docs). - [ ] Add unit or end-to-end test(s) to [the CI workflow](https://github.com/volcengine/verl/tree/main/.github/workflows) to cover all the code. If not feasible, explain why: ... - [ ] Once your PR is ready for CI, send a message in [the `ci-request` channel](https://verl-project.slack.com/archives/C091TCESWB1) in [the `verl` Slack workspace](https://join.slack.com/t/verl-project/shared_invite/zt-3855yhg8g-CTkqXu~hKojPCmo7k_yXTQ). (If not accessible, please try [the Feishu group (飞书群)](https://applink.larkoffice.com/client/chat/chatter/add_by_link?link_token=772jd4f1-cd91-441e-a820-498c6614126a).) - [ ] If your PR is related to the `recipe` submodule, please also update the reference to the submodule commit via `git submodule update --remote` or `cd recipe && git pull origin main`.
1 parent 6b4a867 commit b63fe7f

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

verl/experimental/agent_loop/agent_loop.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ def __init__(
200200
tokenizer: AutoTokenizer,
201201
processor: AutoProcessor,
202202
dataset_cls: type[RLHFDataset],
203-
dataset_config: DictConfig,
203+
dataset_config: DictConfigWrap,
204204
**kwargs,
205205
):
206206
"""Initialize agent loop, each sample will have its own loop instance.
@@ -211,15 +211,15 @@ def __init__(
211211
tokenizer (AutoTokenizer): Tokenizer for tokenize messages.
212212
processor (AutoProcessor): Processor for process messages.
213213
dataset_cls (type[Dataset]): Dataset class for creating dataset, Defaults to RLHFDataset.
214-
dataset_config (DictConfig): Dataset config.
214+
dataset_config (DictConfigWrap): Dataset config.
215215
"""
216216
self.config = trainer_config.config
217217
self.server_manager = server_manager
218218
self.tokenizer = tokenizer
219219
self.processor = processor
220220
self.dataset_cls = dataset_cls
221-
self.dataset_config = dataset_config
222-
self.apply_chat_template_kwargs = dataset_config.get("apply_chat_template_kwargs", {})
221+
self.dataset_config = dataset_config.config
222+
self.apply_chat_template_kwargs = self.dataset_config.get("apply_chat_template_kwargs", {})
223223
self.system_prompt = initialize_system_prompt(self.tokenizer, **self.apply_chat_template_kwargs)
224224
self.loop = get_event_loop()
225225

@@ -513,7 +513,7 @@ async def _run_agent_loop(
513513
tokenizer=self.tokenizer,
514514
processor=self.processor,
515515
dataset_cls=self.dataset_cls,
516-
dataset_config=self.config.data,
516+
dataset_config=DictConfigWrap(self.config.data),
517517
)
518518
output: AgentLoopOutput = await agent_loop.run(sampling_params, **kwargs)
519519
return await self._agent_loop_postprocess(output, **kwargs)

0 commit comments

Comments
 (0)