Skip to content

Commit ca6625f

Browse files
committed
fix: replace hardcoded upstream ID with constant in diff_test.go
1 parent 47439b7 commit ca6625f

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

internal/adc/kine/diff_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import (
1010

1111
const (
1212
exampleHost = "example.com"
13+
upstream1 = "upstream1"
1314
)
1415

1516
func TestDiffer_DiffRoutes(t *testing.T) {
@@ -248,7 +249,7 @@ func TestDiffer_DiffUpstreams(t *testing.T) {
248249

249250
var hasUpdate, hasCreate bool
250251
for _, event := range events {
251-
if event.Type == EventTypeUpdate && event.ResourceID == "upstream1" {
252+
if event.Type == EventTypeUpdate && event.ResourceID == upstream1 {
252253
hasUpdate = true
253254
}
254255
if event.Type == EventTypeCreate && event.ResourceID == "upstream2" {
@@ -257,7 +258,7 @@ func TestDiffer_DiffUpstreams(t *testing.T) {
257258
}
258259

259260
if !hasUpdate {
260-
t.Error("expected UPDATE event for upstream1")
261+
t.Error("expected UPDATE event for " + upstream1)
261262
}
262263
if !hasCreate {
263264
t.Error("expected CREATE event for upstream2")
@@ -318,8 +319,8 @@ func TestDiffer_DiffUpstreamsDelete(t *testing.T) {
318319
if events[0].Type != EventTypeDelete {
319320
t.Errorf("expected DELETE event, got %v", events[0].Type)
320321
}
321-
if events[0].ResourceID != "upstream1" {
322-
t.Errorf("expected resource ID upstream1, got %v", events[0].ResourceID)
322+
if events[0].ResourceID != upstream1 {
323+
t.Errorf("expected resource ID %s, got %v", upstream1, events[0].ResourceID)
323324
}
324325
if events[0].ResourceType != ResourceTypeUpstream {
325326
t.Errorf("expected resource type upstream, got %v", events[0].ResourceType)

0 commit comments

Comments
 (0)