Fix some sonar smell

JackieTien97 · web-flow · commit 19de5b10f38b · 2025-09-24T17:21:52.000+08:00
diff --git a/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/backup/IoTDBDataBackTool.java b/iotdb-client/cli/src/main/java/org/apache/iotdb/tool/backup/IoTDBDataBackTool.java
@@ -897,7 +897,7 @@ private static Properties getProperties(String configName) {
         LOGGER.info("Start to read config file {}", url);
         properties.load(new InputStreamReader(inputStream, StandardCharsets.UTF_8));
       } catch (Exception e) {
-        e.printStackTrace();
+        LOGGER.error("Read config file {} error", url, e);
       }
     }
     return properties;
@@ -1079,7 +1079,7 @@ public static void propertiesFileUpdate(String filePath, String key, String newV
       fileOutputStream.close();
 
     } catch (IOException e) {
-      e.printStackTrace();
+      LOGGER.error("properties file update error.", e);
     }
   }
 
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java
@@ -280,11 +280,10 @@ public void setCatalog(String arg0) throws SQLException {
         }
       }
 
-      Statement stmt = this.createStatement();
-      String sql = "USE " + arg0;
-      boolean rs;
+      PreparedStatement stmt = this.prepareStatement("USE ?");
+      stmt.setString(1, arg0);
       try {
-        rs = stmt.execute(sql);
+        stmt.execute();
       } catch (SQLException e) {
         stmt.close();
         logger.error("Use database error: {}", e.getMessage());
@@ -352,11 +351,10 @@ public void setSchema(String arg0) throws SQLException {
         }
       }
 
-      Statement stmt = this.createStatement();
-      String sql = "USE " + arg0;
-      boolean rs;
+      PreparedStatement stmt = this.prepareStatement("USE ?");
+      stmt.setString(1, arg0);
       try {
-        rs = stmt.execute(sql);
+        stmt.execute();
       } catch (SQLException e) {
         stmt.close();
         logger.error("Use database error: {}", e.getMessage());
diff --git a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBPreparedStatement.java b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBPreparedStatement.java
@@ -456,8 +456,6 @@ public void setObject(int parameterIndex, Object parameterObj, int targetSqlType
               } else if ("false".equalsIgnoreCase((String) parameterObj)
                   || "N".equalsIgnoreCase((String) parameterObj)) {
                 setBoolean(parameterIndex, false);
-              } else if (((String) parameterObj).matches("-?\\d+\\.?\\d*")) {
-                setBoolean(parameterIndex, !((String) parameterObj).matches("-?[0]+[.]*[0]*"));
               } else {
                 throw new SQLException(
                     "No conversion from " + parameterObj + " to Types.BOOLEAN possible.");
diff --git a/iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java b/iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java
@@ -3227,7 +3227,7 @@ private void updateTSInsertTabletsReq(
     request.addToSizeList(tablet.getRowSize());
   }
 
-  // sample some records and judge weather need to add too many null values to convert to tablet.
+  // sample some records and judge whether need to add too many null values to convert to tablet.
   private boolean judgeConvertOfOneDevice(List<List<String>> measurementsList) {
     int size = measurementsList.size();
     int sampleNum = (int) (size * SAMPLE_PROPORTION);
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java
@@ -33,12 +33,17 @@
 import org.apache.iotdb.consensus.ConsensusFactory;
 import org.apache.iotdb.metrics.config.MetricConfigDescriptor;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import java.io.File;
 import java.lang.reflect.Field;
 import java.util.Arrays;
 
 public class ConfigNodeConfig {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(ConfigNodeConfig.class);
+
   /** ClusterName, the default value "defaultCluster" will be changed after join cluster. */
   private volatile String clusterName = "defaultCluster";
 
@@ -1185,7 +1190,7 @@ public String getConfigMessage() {
             .append(configContent)
             .append(";");
       } catch (Exception e) {
-        e.printStackTrace();
+        LOGGER.warn("Failed to get field {}", configField, e);
       }
     }
     return configMessage.toString();
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/PartitionBalancer.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/PartitionBalancer.java
@@ -40,12 +40,12 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.security.SecureRandom;
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Random;
 import java.util.TreeMap;
 import java.util.concurrent.ConcurrentHashMap;
 
@@ -274,7 +274,7 @@ private void shuffleAllocationStrategy(
       List<TTimePartitionSlot> timePartitionSlots,
       BalanceTreeMap<TConsensusGroupId, Integer> availableDataRegionGroupCounter,
       SeriesPartitionTable seriesPartitionTable) {
-    final Random random = new Random();
+    final SecureRandom random = new SecureRandom();
     List<TConsensusGroupId> availableDataRegionGroups =
         new ArrayList<>(availableDataRegionGroupCounter.keySet());
     for (TTimePartitionSlot timePartitionSlot : timePartitionSlots) {
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocator.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocator.java
@@ -24,14 +24,14 @@
 import org.apache.iotdb.common.rpc.thrift.TDataNodeLocation;
 import org.apache.iotdb.common.rpc.thrift.TRegionReplicaSet;
 
+import java.security.SecureRandom;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.Comparator;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Random;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -40,7 +40,7 @@
 /** Allocate Region through Greedy and CopySet Algorithm. */
 public class GreedyCopySetRegionGroupAllocator implements IRegionGroupAllocator {
 
-  private static final Random RANDOM = new Random();
+  private static final SecureRandom RANDOM = new SecureRandom();
   private static final int GCR_MAX_OPTIMAL_PLAN_NUM = 10;
 
   private int replicationFactor;
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyRegionGroupAllocator.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyRegionGroupAllocator.java
@@ -24,17 +24,17 @@
 import org.apache.iotdb.common.rpc.thrift.TDataNodeLocation;
 import org.apache.iotdb.common.rpc.thrift.TRegionReplicaSet;
 
+import java.security.SecureRandom;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
-import java.util.Random;
 import java.util.stream.Collectors;
 
 /** Allocate Region Greedily */
 public class GreedyRegionGroupAllocator implements IRegionGroupAllocator {
 
-  public static final Random RANDOM = new Random();
+  public static final SecureRandom RANDOM = new SecureRandom();
 
   public GreedyRegionGroupAllocator() {
     // Empty constructor
diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TemplateTable.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TemplateTable.java
@@ -185,12 +185,8 @@ private void serialize(OutputStream outputStream) throws IOException {
     }
   }
 
-  private void serializeTemplate(Template template, OutputStream outputStream) {
-    try {
-      template.serialize(outputStream);
-    } catch (IOException e) {
-      e.printStackTrace();
-    }
+  private void serializeTemplate(Template template, OutputStream outputStream) throws IOException {
+    template.serialize(outputStream);
   }
 
   private void deserialize(InputStream inputStream) throws IOException {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
@@ -3444,7 +3444,7 @@ public String getConfigMessage() {
             .append(configContent)
             .append(";");
       } catch (Exception e) {
-        e.printStackTrace();
+        logger.warn("Failed to get field {}", configField, e);
       }
     }
     return configMessage.toString();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionMemoryImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionMemoryImpl.java
@@ -400,8 +400,7 @@ private int initFromLog() throws IOException {
             databaseFullPath);
         return idx;
       } catch (final Exception e) {
-        e.printStackTrace();
-        throw new IOException("Failed to parse " + databaseFullPath + " mlog.bin for err:" + e);
+        throw new IOException("Failed to parse " + databaseFullPath + " mlog.bin", e);
       }
     } else {
       return 0;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionPBTreeImpl.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/impl/SchemaRegionPBTreeImpl.java
@@ -406,8 +406,7 @@ private void initFromLog() throws IOException {
             System.currentTimeMillis() - time,
             storageGroupFullPath);
       } catch (Exception e) {
-        e.printStackTrace();
-        throw new IOException("Failed to parse " + storageGroupFullPath + " mlog.bin for err:" + e);
+        throw new IOException("Failed to parse " + storageGroupFullPath + " mlog.bin", e);
       }
     }
   }
@@ -424,7 +423,7 @@ private void applyMLog(SchemaLogReader<ISchemaRegionPlan> mLogReader, long offse
     try {
       mLogReader.skip(offset);
     } catch (IOException e) {
-      e.printStackTrace();
+      logger.error("Failed to skip {} from {}", offset, schemaRegionDirPath, e);
     }
     while (mLogReader.hasNext()) {
       plan = mLogReader.next();
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/template/ClusterTemplateManager.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/template/ClusterTemplateManager.java
@@ -256,7 +256,7 @@ public List<PartialPath> getPathsSetTemplate(String name, PathPatternTree scope)
                     try {
                       listPath.add(new PartialPath(item));
                     } catch (IllegalPathException e) {
-                      e.printStackTrace();
+                      LOGGER.error("illegal path {}", item);
                     }
                   });
         }
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/SingleSequenceFileTask.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/SingleSequenceFileTask.java
@@ -21,6 +21,8 @@
 
 import org.apache.tsfile.file.metadata.ChunkMetadata;
 import org.apache.tsfile.file.metadata.IDeviceID;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.File;
 import java.io.IOException;
@@ -29,8 +31,9 @@
 import java.util.concurrent.Callable;
 
 public class SingleSequenceFileTask implements Callable<SequenceFileTaskSummary> {
-  private UnseqSpaceStatistics unseqSpaceStatistics;
-  private String seqFile;
+  private static final Logger LOGGER = LoggerFactory.getLogger(SingleSequenceFileTask.class);
+  private final UnseqSpaceStatistics unseqSpaceStatistics;
+  private final String seqFile;
 
   public SingleSequenceFileTask(UnseqSpaceStatistics unseqSpaceStatistics, String seqFile) {
     this.unseqSpaceStatistics = unseqSpaceStatistics;
@@ -94,10 +97,10 @@ private SequenceFileTaskSummary checkSeqFile(
       summary.totalChunkGroups = chunkGroupStatisticsList.size();
     } catch (IOException e) {
       if (e instanceof NoSuchFileException) {
-        System.out.println(seqFile + " is not exist");
+        LOGGER.warn("{} doesn't exist.", seqFile);
         return new SequenceFileTaskSummary();
       }
-      e.printStackTrace();
+      LOGGER.error("check {} failed.", seqFile, e);
       return new SequenceFileTaskSummary();
     }
     return summary;
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/TimePartitionProcessTask.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tool/TimePartitionProcessTask.java
@@ -21,6 +21,8 @@
 
 import org.apache.tsfile.file.metadata.ChunkMetadata;
 import org.apache.tsfile.utils.Pair;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.File;
 import java.io.IOException;
@@ -30,6 +32,7 @@
 import java.util.concurrent.Future;
 
 public class TimePartitionProcessTask {
+  private static final Logger LOGGER = LoggerFactory.getLogger(TimePartitionProcessTask.class);
   private final String timePartition;
   private final Pair<List<String>, List<String>> timePartitionFiles;
   private long sequenceSpaceCost = 0;
@@ -107,10 +110,10 @@ private UnseqSpaceStatistics buildUnseqSpaceStatistics(List<String> unseqFiles)
         }
       } catch (IOException e) {
         if (e instanceof NoSuchFileException) {
-          System.out.println(((NoSuchFileException) e).getFile() + " is not exist");
+          LOGGER.warn("{} doesn't exist.", ((NoSuchFileException) e).getFile());
           continue;
         }
-        e.printStackTrace();
+        LOGGER.error("failed to deal with {}", unseqFile, e);
       }
     }
     unsequenceSpaceCost += (System.currentTimeMillis() - startTime);
@@ -136,7 +139,7 @@ public OverlapStatistic processSequenceSpaceAsync(
       } catch (InterruptedException e) {
         throw e;
       } catch (Exception e) {
-        e.printStackTrace();
+        LOGGER.error("error occurred", e);
       }
     }
     overlapStatistic.mergeUnSeqSpaceStatistics(unseqSpaceStatistics);
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/strategy/RandomOnDiskUsableSpaceStrategy.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/disk/strategy/RandomOnDiskUsableSpaceStrategy.java
@@ -21,13 +21,13 @@
 import org.apache.iotdb.commons.utils.JVMCommonUtils;
 import org.apache.iotdb.db.exception.DiskSpaceInsufficientException;
 
+import java.security.SecureRandom;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Random;
 
 public class RandomOnDiskUsableSpaceStrategy extends DirectoryStrategy {
 
-  private Random random = new Random(System.currentTimeMillis());
+  private final SecureRandom random = new SecureRandom();
 
   @Override
   public int nextFolderIndex() throws DiskSpaceInsufficientException {
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/TsFileSketchTool.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/TsFileSketchTool.java
@@ -41,6 +41,8 @@
 import org.apache.tsfile.utils.BloomFilter;
 import org.apache.tsfile.utils.Pair;
 import org.apache.tsfile.write.schema.Schema;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.FileWriter;
 import java.io.IOException;
@@ -56,6 +58,8 @@
 
 public class TsFileSketchTool {
 
+  private static final Logger LOGGER = LoggerFactory.getLogger(TsFileSketchTool.class);
+
   private String filename;
   private PrintWriter pw;
   private TsFileSketchToolReader reader;
@@ -97,7 +101,7 @@ public TsFileSketchTool(String filename, String outFile) {
             String.format("Cannot load file %s because the file has crashed.", filename));
       }
     } catch (IOException e) {
-      e.printStackTrace();
+      LOGGER.warn("Fail to init TsFileSketchTool, {}", filename, e);
     }
   }
 
@@ -214,7 +218,7 @@ private void printTsFileMetadata(TsFileMetadata tsFileMetaData) {
               + "|\t[magic tail] "
               + reader.readTailMagic());
     } catch (IOException e) {
-      e.printStackTrace();
+      LOGGER.warn("Fail to parse TsFileMetadata, {}", filename, e);
     }
   }
 
@@ -274,7 +278,7 @@ private void printFileInfo() {
               + "|\t[version number] "
               + reader.readVersionNumber());
     } catch (IOException e) {
-      e.printStackTrace();
+      LOGGER.warn("Fail to printFileInfo, {}", filename, e);
     }
   }
 
@@ -384,7 +388,7 @@ private void printChunk(List<ChunkGroupMetadata> allChunkGroupMetadata) {
         printlnBoth(pw, splitStr + " [Chunk Group] of " + chunkGroupMetadata.getDevice() + " ends");
       }
     } catch (IOException e) {
-      e.printStackTrace();
+      LOGGER.warn("Fail to parse chunk, {}", filename, e);
     }
   }
 
@@ -414,7 +418,7 @@ private void printTimeseriesIndex(
       }
       printlnBoth(pw, splitStr);
     } catch (IOException e) {
-      e.printStackTrace();
+      LOGGER.warn("Fail to printTimeseriesIndex, {}", filename, e);
     }
   }
 
@@ -438,7 +442,7 @@ private void printTimeseriesIndex(long pos, Pair<Path, TimeseriesMetadata> times
                 + chunkMetadata.getOffsetOfChunkHeader());
       }
     } catch (IOException e) {
-      e.printStackTrace();
+      LOGGER.warn("Fail to printTimeseriesIndex, {}", filename, e);
     }
   }
 
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/settle/TsFileAndModSettleTool.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/settle/TsFileAndModSettleTool.java
diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/utils/TsFileStatisticScan.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/utils/TsFileStatisticScan.java
diff --git a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/UDTFEqualSizeBucketRandomSample.java b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/UDTFEqualSizeBucketRandomSample.java

Original file line number	Diff line number	Diff line change
`@@ -897,7 +897,7 @@ private static Properties getProperties(String configName) {`
`897`	`897`	`LOGGER.info("Start to read config file {}", url);`
`898`	`898`	`properties.load(new InputStreamReader(inputStream, StandardCharsets.UTF_8));`
`899`	`899`	`} catch (Exception e) {`
`900`		`- e.printStackTrace();`
	`900`	`+ LOGGER.error("Read config file {} error", url, e);`
`901`	`901`	`}`
`902`	`902`	`}`
`903`	`903`	`return properties;`
`@@ -1079,7 +1079,7 @@ public static void propertiesFileUpdate(String filePath, String key, String newV`
`1079`	`1079`	`fileOutputStream.close();`
`1080`	`1080`
`1081`	`1081`	`} catch (IOException e) {`
`1082`		`- e.printStackTrace();`
	`1082`	`+ LOGGER.error("properties file update error.", e);`
`1083`	`1083`	`}`
`1084`	`1084`	`}`
`1085`	`1085`
Original file line number	Diff line number	Diff line change
`@@ -3227,7 +3227,7 @@ private void updateTSInsertTabletsReq(`
`3227`	`3227`	`request.addToSizeList(tablet.getRowSize());`
`3228`	`3228`	`}`
`3229`	`3229`
`3230`		`- // sample some records and judge weather need to add too many null values to convert to tablet.`
	`3230`	`+ // sample some records and judge whether need to add too many null values to convert to tablet.`
`3231`	`3231`	`private boolean judgeConvertOfOneDevice(List<List<String>> measurementsList) {`
`3232`	`3232`	`int size = measurementsList.size();`
`3233`	`3233`	`int sampleNum = (int) (size * SAMPLE_PROPORTION);`
Original file line number	Diff line number	Diff line change
`@@ -185,12 +185,8 @@ private void serialize(OutputStream outputStream) throws IOException {`
`185`	`185`	`}`
`186`	`186`	`}`
`187`	`187`
`188`		`- private void serializeTemplate(Template template, OutputStream outputStream) {`
`189`		`- try {`
`190`		`- template.serialize(outputStream);`
`191`		`- } catch (IOException e) {`
`192`		`- e.printStackTrace();`
`193`		`- }`
	`188`	`+ private void serializeTemplate(Template template, OutputStream outputStream) throws IOException {`
	`189`	`+ template.serialize(outputStream);`
`194`	`190`	`}`
`195`	`191`
`196`	`192`	`private void deserialize(InputStream inputStream) throws IOException {`
Original file line number	Diff line number	Diff line change
`@@ -3444,7 +3444,7 @@ public String getConfigMessage() {`
`3444`	`3444`	`.append(configContent)`
`3445`	`3445`	`.append(";");`
`3446`	`3446`	`} catch (Exception e) {`
`3447`		`- e.printStackTrace();`
	`3447`	`+ logger.warn("Failed to get field {}", configField, e);`
`3448`	`3448`	`}`
`3449`	`3449`	`}`
`3450`	`3450`	`return configMessage.toString();`