Skip to content

Commit 190b5f3

Browse files
jinzhongjiajinzhongjia
committed
refactor(msgpack): convert recursive parser to iterative with safety limits
- Replace recursive read() with iterative state machine implementation to prevent stack overflow on deep nesting - Add ParseLimits struct with configurable max_depth, max_array_length, max_map_size, max_string_length, and max_ext_length - Introduce PackWithLimits() function for custom limit configuration with backward-compatible Pack() wrapper using DEFAULT_LIMITS - Refactor Payload.free() to iterative stack-based implementation to avoid stack overflow during cleanup - Add new error types (MaxDepthExceeded, ArrayTooLarge, MapTooLarge, StringTooLong, ExtDataTooLong) for limit violations - Implement comprehensive test suite covering deep nesting, malicious payloads, corrupted data, and edge cases - Add benchmark.md with complete performance metrics for all MessagePack operations in both debug and optimized builds
1 parent dffc961 commit 190b5f3

File tree

3 files changed

+1256
-153
lines changed

3 files changed

+1256
-153
lines changed

‎benchmark.md‎

Lines changed: 141 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,141 @@
1+
```sh
2+
❯ zig build bench
3+
4+
================================================================================
5+
MessagePack Benchmark Suite
6+
================================================================================
7+
8+
Basic Types:
9+
--------------------------------------------------------------------------------
10+
Nil Write | 1000000 iterations | 23 ns/op | 43478260 ops/sec
11+
Nil Read | 1000000 iterations | 12484 ns/op | 80102 ops/sec
12+
Bool Write | 1000000 iterations | 27 ns/op | 37037037 ops/sec
13+
Bool Read | 1000000 iterations | 11992 ns/op | 83388 ops/sec
14+
Small Int Write | 1000000 iterations | 27 ns/op | 37037037 ops/sec
15+
Small Int Read | 1000000 iterations | 12429 ns/op | 80456 ops/sec
16+
Large Int Write | 1000000 iterations | 48 ns/op | 20833333 ops/sec
17+
Large Int Read | 1000000 iterations | 11975 ns/op | 83507 ops/sec
18+
Float Write | 1000000 iterations | 46 ns/op | 21739130 ops/sec
19+
Float Read | 1000000 iterations | 12382 ns/op | 80762 ops/sec
20+
21+
Strings:
22+
--------------------------------------------------------------------------------
23+
Short String Write (5 bytes) | 500000 iterations | 21283 ns/op | 46985 ops/sec
24+
Short String Read (5 bytes) | 500000 iterations | 38483 ns/op | 25985 ops/sec
25+
Medium String Write (~300 bytes) | 100000 iterations | 26060 ns/op | 38372 ops/sec
26+
Medium String Read (~300 bytes) | 100000 iterations | 40271 ns/op | 24831 ops/sec
27+
28+
Binary Data:
29+
--------------------------------------------------------------------------------
30+
Small Binary Write (32 bytes) | 500000 iterations | 23217 ns/op | 43071 ops/sec
31+
Small Binary Read (32 bytes) | 500000 iterations | 39784 ns/op | 25135 ops/sec
32+
Large Binary Write (1KB) | 100000 iterations | 33540 ns/op | 29815 ops/sec
33+
Large Binary Read (1KB) | 100000 iterations | 49550 ns/op | 20181 ops/sec
34+
35+
Arrays:
36+
--------------------------------------------------------------------------------
37+
Small Array Write (10 elements) | 100000 iterations | 56802 ns/op | 17605 ops/sec
38+
Small Array Read (10 elements) | 100000 iterations | 120598 ns/op | 8292 ops/sec
39+
Medium Array Write (100 elements) | 50000 iterations | 86305 ns/op | 11586 ops/sec
40+
Medium Array Read (100 elements) | 50000 iterations | 179349 ns/op | 5575 ops/sec
41+
42+
Maps:
43+
--------------------------------------------------------------------------------
44+
Small Map Write (10 entries) | 100000 iterations | 303730 ns/op | 3292 ops/sec
45+
Small Map Read (10 entries) | 100000 iterations | 450047 ns/op | 2221 ops/sec
46+
Medium Map Write (50 entries) | 50000 iterations | 942602 ns/op | 1060 ops/sec
47+
Medium Map Read (50 entries) | 50000 iterations | 1456101 ns/op | 686 ops/sec
48+
49+
Extension Types:
50+
--------------------------------------------------------------------------------
51+
EXT Write (16 bytes) | 500000 iterations | 24203 ns/op | 41317 ops/sec
52+
EXT Read (16 bytes) | 500000 iterations | 40463 ns/op | 24713 ops/sec
53+
54+
Timestamps:
55+
--------------------------------------------------------------------------------
56+
Timestamp32 Write | 1000000 iterations | 74 ns/op | 13513513 ops/sec
57+
Timestamp32 Read | 1000000 iterations | 12940 ns/op | 77279 ops/sec
58+
Timestamp64 Write | 1000000 iterations | 74 ns/op | 13513513 ops/sec
59+
Timestamp64 Read | 1000000 iterations | 12427 ns/op | 80469 ops/sec
60+
61+
Complex Structures:
62+
--------------------------------------------------------------------------------
63+
Nested Structure Write | 50000 iterations | 115840 ns/op | 8632 ops/sec
64+
Nested Structure Read | 50000 iterations | 239723 ns/op | 4171 ops/sec
65+
Mixed Types Write | 50000 iterations | 88667 ns/op | 11278 ops/sec
66+
Mixed Types Read | 50000 iterations | 185971 ns/op | 5377 ops/sec
67+
68+
================================================================================
69+
Benchmark Complete
70+
================================================================================
71+
❯ zig build bench -Doptimize=ReleaseFast
72+
73+
================================================================================
74+
MessagePack Benchmark Suite
75+
================================================================================
76+
77+
Basic Types:
78+
--------------------------------------------------------------------------------
79+
Nil Write | 1000000 iterations | 6 ns/op | 166666666 ops/sec
80+
Nil Read | 1000000 iterations | 4359 ns/op | 229410 ops/sec
81+
Bool Write | 1000000 iterations | 2 ns/op | 500000000 ops/sec
82+
Bool Read | 1000000 iterations | 4635 ns/op | 215749 ops/sec
83+
Small Int Write | 1000000 iterations | 7 ns/op | 142857142 ops/sec
84+
Small Int Read | 1000000 iterations | 4710 ns/op | 212314 ops/sec
85+
Large Int Write | 1000000 iterations | 5 ns/op | 200000000 ops/sec
86+
Large Int Read | 1000000 iterations | 4978 ns/op | 200883 ops/sec
87+
Float Write | 1000000 iterations | 4 ns/op | 250000000 ops/sec
88+
Float Read | 1000000 iterations | 4487 ns/op | 222866 ops/sec
89+
90+
Strings:
91+
--------------------------------------------------------------------------------
92+
Short String Write (5 bytes) | 500000 iterations | 6876 ns/op | 145433 ops/sec
93+
Short String Read (5 bytes) | 500000 iterations | 9888 ns/op | 101132 ops/sec
94+
Medium String Write (~300 bytes) | 100000 iterations | 10189 ns/op | 98145 ops/sec
95+
Medium String Read (~300 bytes) | 100000 iterations | 14305 ns/op | 69905 ops/sec
96+
97+
Binary Data:
98+
--------------------------------------------------------------------------------
99+
Small Binary Write (32 bytes) | 500000 iterations | 9787 ns/op | 102176 ops/sec
100+
Small Binary Read (32 bytes) | 500000 iterations | 9506 ns/op | 105196 ops/sec
101+
Large Binary Write (1KB) | 100000 iterations | 6748 ns/op | 148192 ops/sec
102+
Large Binary Read (1KB) | 100000 iterations | 8847 ns/op | 113032 ops/sec
103+
104+
Arrays:
105+
--------------------------------------------------------------------------------
106+
Small Array Write (10 elements) | 100000 iterations | 8685 ns/op | 115141 ops/sec
107+
Small Array Read (10 elements) | 100000 iterations | 15166 ns/op | 65936 ops/sec
108+
Medium Array Write (100 elements) | 50000 iterations | 16765 ns/op | 59648 ops/sec
109+
Medium Array Read (100 elements) | 50000 iterations | 29700 ns/op | 33670 ops/sec
110+
111+
Maps:
112+
--------------------------------------------------------------------------------
113+
Small Map Write (10 entries) | 100000 iterations | 35803 ns/op | 27930 ops/sec
114+
Small Map Read (10 entries) | 100000 iterations | 44254 ns/op | 22596 ops/sec
115+
Medium Map Write (50 entries) | 50000 iterations | 48868 ns/op | 20463 ops/sec
116+
Medium Map Read (50 entries) | 50000 iterations | 68684 ns/op | 14559 ops/sec
117+
118+
Extension Types:
119+
--------------------------------------------------------------------------------
120+
EXT Write (16 bytes) | 500000 iterations | 6597 ns/op | 151584 ops/sec
121+
EXT Read (16 bytes) | 500000 iterations | 8930 ns/op | 111982 ops/sec
122+
123+
Timestamps:
124+
--------------------------------------------------------------------------------
125+
Timestamp32 Write | 1000000 iterations | 5 ns/op | 200000000 ops/sec
126+
Timestamp32 Read | 1000000 iterations | 4397 ns/op | 227427 ops/sec
127+
Timestamp64 Write | 1000000 iterations | 5 ns/op | 200000000 ops/sec
128+
Timestamp64 Read | 1000000 iterations | 4289 ns/op | 233154 ops/sec
129+
130+
Complex Structures:
131+
--------------------------------------------------------------------------------
132+
Nested Structure Write | 50000 iterations | 13055 ns/op | 76599 ops/sec
133+
Nested Structure Read | 50000 iterations | 15526 ns/op | 64408 ops/sec
134+
Mixed Types Write | 50000 iterations | 13108 ns/op | 76289 ops/sec
135+
Mixed Types Read | 50000 iterations | 18246 ns/op | 54806 ops/sec
136+
137+
================================================================================
138+
Benchmark Complete
139+
================================================================================
140+
```
141+

0 commit comments

Comments
 (0)