chore: apply suggested fixes

Author: mstdokumaci

src/msgpack.zig

@@ -882,23 +882,18 @@ fn clonePayload(payload: Payload, allocator: Allocator) !Payload {
 
         .map => |m| {
             var new_map = Map.init(allocator);
-            errdefer new_map.deinit();
+            errdefer (Payload{ .map = new_map }).free(allocator);
 
             // Clone all entries
             var it = m.map.iterator();
             while (it.next()) |entry| {
-                var cloned_key: ?Payload = null;
-                var cloned_value: ?Payload = null;
-                errdefer {
-                    if (cloned_value) |v| v.free(allocator);
-                    if (cloned_key) |k| k.free(allocator);
-                }
-
-                cloned_key = try clonePayload(entry.key_ptr.*, allocator);
-                cloned_value = try clonePayload(entry.value_ptr.*, allocator);
+                const cloned_key = try clonePayload(entry.key_ptr.*, allocator);
+                errdefer cloned_key.free(allocator);
+                const cloned_value = try clonePayload(entry.value_ptr.*, allocator);
+                errdefer cloned_value.free(allocator);
 
                 // Use putInternal to insert without additional cloning
-                try new_map.putInternal(cloned_key.?, cloned_value.?);
+                try new_map.putInternal(cloned_key, cloned_value);
             }
             return Payload{ .map = new_map };
         },

src/test.zig

@@ -3632,6 +3632,7 @@ test "clonePayload arr partial fail path frees partially cloned elements" {
         try std.testing.expect(err == error.OutOfMemory);
     }
 
+    // Verify post-failure allocator state is valid: next alloc must succeed.
     const next_alloc = try clone_alloc.alloc(u8, 16);
     clone_alloc.free(next_alloc);
 }
@@ -3655,6 +3656,7 @@ test "clonePayload map partial fail path frees partially cloned entries" {
         try std.testing.expect(err == error.OutOfMemory);
     }
 
+    // Verify post-failure allocator state is valid: next alloc must succeed.
     const next_alloc = try clone_alloc.alloc(u8, 16);
     clone_alloc.free(next_alloc);
 }