Skip to content

Commit fe85569

Browse files
committed
std.Build.Step.Run: inherit build runner cwd
Right now, if you override the build root with `--build-root`, then `Run` steps can fail to execute because of incorrect path handling in the compiler: `std.process.Child` gets a cwd-relative path, but also has its cwd set to the build root. The latter behavior is really weird; it doesn't match my expectations, nor does it match how we spawn child `zig` processes. So, this commit makes the child process inherit the build runner's cwd, as `LazyPath.getPath2` *expects* it to. After investigating, this behavior dates all the way back to 2017; it was introduced in 4543413. So, there isn't any clear/documented reason for this; it should be safe to revert, since under the modern `LazyPath` system it is strictly a bug AFAICT.
1 parent a63f787 commit fe85569

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

lib/std/Build/Step/Run.zig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1334,9 +1334,6 @@ fn spawnChildAndCollect(
13341334
var child = std.process.Child.init(argv, arena);
13351335
if (run.cwd) |lazy_cwd| {
13361336
child.cwd = lazy_cwd.getPath2(b, &run.step);
1337-
} else {
1338-
child.cwd = b.build_root.path;
1339-
child.cwd_dir = b.build_root.handle;
13401337
}
13411338
child.env_map = run.env_map orelse &b.graph.env_map;
13421339
child.request_resource_usage_statistics = true;

0 commit comments

Comments
 (0)