std.debug.Dwarf.SelfUnwinder: assume same-value rule by default for all columns
#25523
+21
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems wrong: the |
…ll columns This fixes leaf function unwinding, presumably among other things.
alexrp
force-pushed
the
gcc-kinda-sucks
branch
from
953e6e7 to
4d465ea
Compare
Oops, good point.
Most libc startup code and thread entry points explicitly zero the link register; some ABIs even require them to do so. We do this for all targets in Zig code and in our bundled musl. glibc startup code mostly does it too, although it's pretty inconsistent from arch to arch. Can't speak for macOS libc though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's kind of remarkable how many terrible things we have to live with today can be traced back to GCC.
This fixes leaf function unwinding, presumably among other things.