Fix Tuya illuminance/valve enum sensor entity type, add test (#4112)

* Fix Tuya illuminance sensor entity type

* Fix Tuya valve status entity type

* Add test ensuring correct entity category for enum sensors

Author: TheJulianJES

tests/test_quirks_v2.py

@@ -4,7 +4,12 @@
 import itertools
 
 import zigpy.quirks
-from zigpy.quirks.v2 import QuirksV2RegistryEntry
+from zigpy.quirks.v2 import (
+    EntityPlatform,
+    EntityType,
+    QuirksV2RegistryEntry,
+    ZCLEnumMetadata,
+)
 
 import zhaquirks
 
@@ -70,3 +75,21 @@ def test_manufacturer_model_metadata_unique() -> None:
         assert len(quirk_locations) == 1, (
             f"Manufacturer-model pair '{manufacturer}' '{model}' is shared by multiple quirks: {quirk_locations}"
         )
+
+
+def test_enum_sensor_category() -> None:
+    """Ensure enum metadata with sensor entity platform has valid entity category."""
+    for quirk in ALL_QUIRK_V2_CLASSES:
+        for entity_metadata in quirk.entity_metadata:
+            if (
+                isinstance(entity_metadata, ZCLEnumMetadata)
+                and entity_metadata.entity_platform is EntityPlatform.SENSOR
+            ):
+                assert entity_metadata.entity_type in (
+                    EntityType.STANDARD,
+                    EntityType.DIAGNOSTIC,
+                ), (
+                    f"Enum sensor '{entity_metadata.translation_key}' in "
+                    f"{quirk.quirk_file}:{quirk.quirk_file_line} "
+                    f"has invalid entity type '{entity_metadata.entity_type}'"
+                )

zhaquirks/tuya/tuya_illuminance.py

@@ -1,6 +1,6 @@
 """Tuya illuminance sensors."""
 
-from zigpy.quirks.v2 import EntityPlatform
+from zigpy.quirks.v2 import EntityPlatform, EntityType
 from zigpy.types import t
 
 from zhaquirks.tuya.builder import TuyaQuirkBuilder
@@ -23,6 +23,7 @@ class BrightnessLevel(t.enum8):
         dp_id=1,
         attribute_name="brightness_level",
         enum_class=BrightnessLevel,
+        entity_type=EntityType.STANDARD,
         entity_platform=EntityPlatform.SENSOR,
         translation_key="brightness_level",
         fallback_name="Brightness level",

zhaquirks/tuya/tuya_valve.py

@@ -510,6 +510,7 @@ class GiexIrrigationStatus(t.enum8):
         dp_id=3,
         attribute_name="valve_status",
         enum_class=TuyaValveStatus,
+        entity_type=EntityType.STANDARD,
         entity_platform=EntityPlatform.SENSOR,
         translation_key="valve_status",
         fallback_name="Valve status",