Expanding v2 quirks to support Green Power #4342
konistehrad
started this conversation in
General
Replies: 2 comments
-
|
I think we can just mirror the matching logic you originally wrote and create a |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Ok cool makes sense. I’m going to start with a first pass at the ZGP controller itself soon, and once I’m in a position to I’ll start working on the alternate quirk builder. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @puddly, hoping to bend your ear here about how to get ZGP support in the new quirks structure. We're up against a few awkward constraints when supporting ZGP devices, namely:
As a result, in the original PR, I implemented a
matchclass method that ran as much custom code as it needed to do the match, and assigned all devices match priority, from the SWS200 "this is definitely the one" to the Moes "IDEK man" catch-all.With all that as context, I'm hoping to work with you to architect something a little saner and cleaner than the original PR. If you could give me some pointers on how I might structure green power device matching given these constraints, I'd really appreciate it.
Beta Was this translation helpful? Give feedback.
All reactions