-
Notifications
You must be signed in to change notification settings - Fork 878
Expose the 'multicolor' command on additional Hue lights #4318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Added the Akari downlight, Discover floodlight and Lightstrip Solo
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4318 +/- ##
=======================================
Coverage 92.12% 92.13%
=======================================
Files 358 358
Lines 11917 11920 +3
=======================================
+ Hits 10979 10982 +3
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@TheJulianJES - when I created this PR, I added information to the Proposed Change, Additional Information and I also uploaded Device Diagnostics for the three devices concerned so I'm not sure why none of that is visible above. Let me know if you need me come back and add further information. |
The info was inside the commented out template block in the description. You can just edit the PR description again and move it out of there. I already did that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Small notes on the new model names.
Co-authored-by: TheJulianJES <[email protected]>
Co-authored-by: TheJulianJES <[email protected]>
Proposed change
Added the Akari downlight, Discover floodlight and Lightstrip Solo
Added support for 'multicolor' command for more Hue devices.
Additional information
Extends support added by PR 4076 and 3664
Device diagnostics
zha-01JTWSK5QQ8MVHXRQYFG0V6GK8-Philips Hue Discover Outdoor Floodlight RGBCCT-cea73e176a6bbffd9f8e0ebb5abf5456.json
You can find the diagnostics information by going
zha-01JTWSK5QQ8MVHXRQYFG0V6GK8-Philips Hue Akari Downlight-077929e0069ea90ed22233f2b43aba06.json
to the device page, clicking the
three dots, and then by clicking on "Download diagnostics". Drag-and-drop the
downloaded file into this section.
zha-01JTWSK5QQ8MVHXRQYFG0V6GK8-Philips Hue Lightstrip Solo-2eb70bc25a2d10a0be9780f96f914449.json
Checklist
pre-commit
checks pass / the code has been formatted using Black