Skip to content

Commit 976f604

Browse files
authored
Revert restoring update entity latest_version (#462)
1 parent 63e0cdc commit 976f604

File tree

2 files changed

+0
-30
lines changed

2 files changed

+0
-30
lines changed

tests/test_update.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -606,28 +606,3 @@ async def test_firmware_update_latest_version_even_if_downgrade(
606606
entity.state[ATTR_LATEST_VERSION]
607607
== f"0x{fw_image_downgrade.firmware.header.file_version:08x}"
608608
)
609-
610-
611-
@pytest.mark.parametrize(
612-
"latest_version",
613-
[
614-
"0x1234",
615-
"0x12345678",
616-
],
617-
)
618-
async def test_firmware_update_state_restoration(
619-
zha_gateway: Gateway, latest_version: str
620-
) -> None:
621-
"""Test the firmware update state restoration function."""
622-
zigpy_device = zigpy_device_mock(zha_gateway)
623-
zha_device, ota_cluster, fw_image, installed_fw_version = await setup_test_data(
624-
zha_gateway, zigpy_device
625-
)
626-
627-
entity = get_entity(zha_device, platform=Platform.UPDATE)
628-
assert not entity.state[ATTR_LATEST_VERSION]
629-
630-
entity.restore_external_state_attributes(
631-
latest_version=latest_version,
632-
)
633-
assert entity.state[ATTR_LATEST_VERSION] == latest_version

zha/application/platforms/update.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,6 @@ async def on_remove(self) -> None:
298298
self._attr_in_progress = False
299299
await super().on_remove()
300300

301-
def restore_external_state_attributes(self, *, latest_version: str | None) -> None:
302-
"""Restore extra state attributes that are stored outside of the ZCL cache."""
303-
if latest_version is not None:
304-
self._attr_latest_version = latest_version
305-
306301

307302
@CONFIG_DIAGNOSTIC_MATCH(cluster_handler_names=CLUSTER_HANDLER_OTA)
308303
class FirmwareUpdateEntity(BaseFirmwareUpdateEntity):

0 commit comments

Comments
 (0)