Remove redundant "number" translation key and description (#444)

* Remove `hasattr` check in `AnalogOutputNumber`

* Move `description` in `on_add` to `AnalogInputSensor`

Also removes `hasattr` check

* Remove redundant "number" translation key

* Adjust number to be similar to sensor platform

* Remove redundant code from `on_add`

* Expect number platform having no default translation key

* Regenerate diagnostics

Author: TheJulianJES

tests/data/devices/isilentllc-dog-feeder.json

@@ -1125,7 +1125,7 @@
           "migrate_unique_ids": [],
           "platform": "number",
           "class_name": "AnalogOutputNumber",
-          "translation_key": "number",
+          "translation_key": null,
           "device_class": null,
           "state_class": null,
           "entity_category": null,

tests/data/devices/isilentllc-masterbed-light-controller.json

@@ -1653,7 +1653,7 @@
           "migrate_unique_ids": [],
           "platform": "number",
           "class_name": "AnalogOutputNumber",
-          "translation_key": "number",
+          "translation_key": null,
           "device_class": null,
           "state_class": null,
           "entity_category": null,
@@ -1708,7 +1708,7 @@
           "migrate_unique_ids": [],
           "platform": "number",
           "class_name": "AnalogOutputNumber",
-          "translation_key": "number",
+          "translation_key": null,
           "device_class": null,
           "state_class": null,
           "entity_category": null,

tests/test_number.py

@@ -204,7 +204,7 @@ async def test_number_missing_description_attr(
     assert isinstance(entity, PlatformEntity)
 
     assert entity.fallback_name is None
-    assert entity.translation_key == "number"
+    assert entity.translation_key is None
 
 
 @pytest.mark.parametrize(

tests/test_registries.py

@@ -13,6 +13,7 @@
 from zha.application.const import ATTR_QUIRK_ID
 from zha.application.platforms import PlatformEntity
 from zha.application.platforms.binary_sensor import BinaryInputWithDescription, IASZone
+from zha.application.platforms.number import AnalogOutputNumber
 from zha.application.platforms.sensor import AnalogInputSensor
 from zha.application.registries import (
     PLATFORM_ENTITIES,
@@ -578,4 +579,5 @@ def test_entity_names() -> None:
                     IASZone,
                     BinaryInputWithDescription,
                     AnalogInputSensor,
+                    AnalogOutputNumber,
                 )

zha/application/platforms/number/__init__.py

@@ -126,8 +126,6 @@ async def async_set_native_value(self, value: float) -> None:
 class AnalogOutputNumber(BaseNumber):
     """Representation of a ZHA Number entity."""
 
-    _attr_translation_key: str = "number"
-
     def __init__(
         self,
         cluster_handlers: list[ClusterHandler],
@@ -158,10 +156,7 @@ def recompute_capabilities(self) -> None:
         else:
             self._attr_icon = None
 
-        if analog_output.description is not None:
-            self._attr_fallback_name = analog_output.description
-        else:
-            self._attr_fallback_name = None
+        self._attr_fallback_name = analog_output.description
 
     def on_add(self) -> None:
         """Run when entity is added."""
@@ -172,14 +167,6 @@ def on_add(self) -> None:
                 self.handle_cluster_handler_attribute_updated,
             )
         )
-        if (
-            hasattr(self._analog_output_cluster_handler, "description")
-            and self._analog_output_cluster_handler.description is not None
-        ):
-            self._attr_translation_key = None
-            self._attr_fallback_name: str = (
-                self._analog_output_cluster_handler.description
-            )
 
     @property
     def native_value(self) -> float | None:

zha/application/platforms/sensor/__init__.py

@@ -202,12 +202,6 @@ def on_add(self) -> None:
                 self.handle_cluster_handler_attribute_updated,
             )
         )
-        if (
-            hasattr(self._cluster_handler, "description")
-            and self._cluster_handler.description is not None
-        ):
-            self._attr_translation_key = None
-            self._attr_fallback_name: str = self._cluster_handler.description
 
     def _is_supported(self) -> bool:
         if (