Add event platform for client cluster #594
Conversation
|
Just noticed that #419 exists too. I think this is simpler and stands on the main standardized clusters. |
- Add event entities for LevelControl client clusters - Adjust registries to support ClientCluster handlers
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #594 +/- ##
==========================================
+ Coverage 96.98% 97.09% +0.10%
==========================================
Files 63 64 +1
Lines 10559 10661 +102
==========================================
+ Hits 10241 10351 +110
+ Misses 318 310 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Btw. I've explicitly avoided some fixed structure here. Tried to keep the original cluster commands as is. Currently HA has very few devices classes for events, so the structure of the event data there has not given correct structure. Given the above situation, inventing some in-between structure that isn't 1 to 1 mapped to zigbee spec seem pointless and only adds complexity. |
| yield from self._handle_single_output_clusters(endpoint) | ||
| else: | ||
| # until we can get rid of registries | ||
| yield from self.handle_on_off_output_cluster_exception(endpoint) |
There was a problem hiding this comment.
I really don't understand this weird cluster exception here. It seems to add extra cluster handler at this stage.
There was a problem hiding this comment.
It's from 2019. The more we delete from discovery.py the better 😄
There was a problem hiding this comment.
Ok. Will look at it after goes in. I'd rather not make this larger than it is. The split of input/output handler is no longer required since the client cluster handlers have names and id's that separate them from server side. So this stuff can be simplified.
But I'd rather avoid making this larger than it already is, given how hard the test fixtures are to review.
2 participants
Depends on home-assistant/core#157853 for support in HA