Fix unit tests

Author: puddly

tests/test_api.py

@@ -1,5 +1,5 @@
 import asyncio
-from unittest.mock import MagicMock, patch, sentinel
+from unittest.mock import AsyncMock, MagicMock, patch, sentinel
 
 import pytest
 import serial_asyncio
@@ -37,10 +37,13 @@ async def mock_conn(loop, protocol_factory, **kwargs):
     await api.connect()
 
 
-def test_close(api):
+@pytest.mark.asyncio
+async def test_disconnect(api):
     uart = api._uart
-    api.close()
-    assert uart.close.call_count == 1
+    uart.disconnect = AsyncMock()
+
+    await api.disconnect()
+    assert uart.disconnect.call_count == 1
     assert api._uart is None
 
 

tests/test_application.py

@@ -102,28 +102,28 @@ async def mock_get_network_state():
 
 @pytest.mark.asyncio
 async def test_disconnect_success(app):
-    api = MagicMock()
+    api = AsyncMock()
 
     app._api = api
     await app.disconnect()
 
-    api.close.assert_called_once()
+    api.disconnect.assert_called_once()
     assert app._api is None
 
 
 @pytest.mark.asyncio
 async def test_disconnect_failure(app, caplog):
-    api = MagicMock()
-    api.disconnect = MagicMock(side_effect=RuntimeError("Broken"))
+    api = AsyncMock()
+    api.reset = AsyncMock(side_effect=RuntimeError("Broken"))
 
     app._api = api
 
     with caplog.at_level(logging.WARNING):
         await app.disconnect()
 
-    assert "disconnect" in caplog.text
+    assert "Failed to reset before disconnect" in caplog.text
 
-    api.close.assert_called_once()
+    api.disconnect.assert_called_once()
     assert app._api is None
 
 

tests/test_uart.py

@@ -108,13 +108,6 @@ def test_escape(gw):
     assert r == data_escaped
 
 
-def test_length(gw):
-    data = b"\x80\x10\x00\x05\xaa\x00\x0f?\xf0\xff"
-    length = 5
-    r = gw._length(data)
-    assert r == length
-
-
 def test_checksum(gw):
     data = b"\x00\x0f?\xf0"
     checksum = 0xAA