chore: apply-rector-changes-for-code-style-and-type-safety

Author: Masatoshi Ogiwara

docs/includes/fundamentals/as-avs/AtlasSearchTest.php

@@ -149,9 +149,9 @@ public function testVectorSearch(): void
     /** Generates random vectors using fixed seed to make tests deterministic */
     private function addVector(array $items): array
     {
-        srand(1);
+        mt_srand(1);
         foreach ($items as &$item) {
-            $this->vectors[] = $item['vector4'] = array_map(fn () => rand() / mt_getrandmax(), range(0, 3));
+            $this->vectors[] = $item['vector4'] = array_map(fn () => random_int(0, mt_getrandmax()) / mt_getrandmax(), range(0, 3));
         }
 
         return $items;

src/CommandSubscriber.php

@@ -18,7 +18,7 @@ final class CommandSubscriber implements CommandSubscriberInterface
     /** @var array<string, CommandStartedEvent> */
     private array $commands = [];
 
-    public function __construct(private Connection $connection)
+    public function __construct(private readonly Connection $connection)
     {
     }
 

src/Scout/ScoutEngine.php

@@ -69,8 +69,8 @@ final class ScoutEngine extends Engine
 
     /** @param array<string, array> $indexDefinitions */
     public function __construct(
-        private Database $database,
-        private bool $softDelete,
+        private readonly Database $database,
+        private readonly bool $softDelete,
         private array $indexDefinitions = [],
     ) {
     }

tests/AtlasSearchTest.php

@@ -256,9 +256,9 @@ public function testEloquentBuilderVectorSearch()
     /** Generate random vectors using fixed seed to make tests deterministic */
     private function addVector(array $items): array
     {
-        srand(1);
+        mt_srand(1);
         foreach ($items as &$item) {
-            $this->vectors[] = $item['vector4'] = array_map(fn () => rand() / mt_getrandmax(), range(0, 3));
+            $this->vectors[] = $item['vector4'] = array_map(fn () => random_int(0, mt_getrandmax()) / mt_getrandmax(), range(0, 3));
         }
 
         return $items;