File tree Expand file tree Collapse file tree 1 file changed +7
-0
lines changed
engine/src/flutter/impeller/typographer/backends/skia Expand file tree Collapse file tree 1 file changed +7
-0
lines changed Original file line number Diff line number Diff line change @@ -417,13 +417,20 @@ TypographerContextSkia::CollectNewGlyphs(
417417 size_t generation_id = atlas->GetAtlasGeneration ();
418418 intptr_t atlas_id = reinterpret_cast <intptr_t >(atlas.get ());
419419 for (const auto & frame : text_frames) {
420+ // TODO(jonahwilliams): determine how to re-enable this. See
421+ // https://github.com/flutter/flutter/issues/163730 for example. This can
422+ // happen when the Aiks/Typographer context are re-created, but the last
423+ // DisplayList is re-used. The "atlas_id" check is not reliable, perhaps
424+ // because it may end up with the same memory?
425+ #if false
420426 auto [frame_generation_id, frame_atlas_id] =
421427 frame->GetAtlasGenerationAndID ();
422428 if (atlas->IsValid () && frame->IsFrameComplete () &&
423429 frame_generation_id == generation_id && frame_atlas_id == atlas_id &&
424430 !frame->GetFrameBounds (0 ).is_placeholder ) {
425431 continue ;
426432 }
433+ #endif // false
427434 frame->ClearFrameBounds ();
428435 frame->SetAtlasGeneration (generation_id, atlas_id);
429436
You can’t perform that action at this time.
0 commit comments