Merge branch 'flutter:master' into master

Author: zijiehe-google-com

.ci.yaml

@@ -0,0 +1,137 @@
+name: Report a google3 bug
+description: |
+  You found a bug in Flutter causing your application to crash or
+  throw an exception, a widget is buggy, or something looks wrong.
+title: "[Google3 Bug]: "
+labels: 'customer: google'
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thank you for using Flutter!
+
+        If you are looking for support, please check out our documentation
+        or consider asking a question on Stack Overflow:
+
+          - https://flutter.dev/
+          - https://api.flutter.dev/
+          - https://stackoverflow.com/questions/tagged/flutter?sort=frequent
+  - type: markdown
+    attributes:
+      value: |
+        Before filling the form fields, please consider the following:
+        - Ensure that you have searched the [existing issues](https://github.com/flutter/flutter/issues)
+        - Read the [guide to filing a bug](https://flutter.dev/docs/resources/bug-reports)
+  - type: markdown
+    attributes:
+      value: |
+        Flutter GitHub issues are public and so you must avoid posting any Google confidential information in them.
+  - type: checkboxes
+    id: priority-indicator
+    attributes:
+      label: Help us understand the severity of this issue
+      description: Please only choose one
+      options:
+        - label: causing severe production issues e.g. malfunctions or data loss
+        - label: blocking next binary release
+        - label: blocking a client feature launch within a quarter
+        - label: nice-to-have but does not block a launch within the next quarter
+  - type: textarea
+    attributes:
+      label: Steps to reproduce
+      description: Please tell us exactly how to reproduce the problem you are running into.
+      placeholder: |
+        1. ...
+        2. ...
+        3. ...
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Expected results
+      description: Please tell us what is expected to happen.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Actual results
+      description: Please tell us what is actually happening.
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Code sample
+      description: |
+        Please create a minimal reproducible sample that shows the problem
+        and attach it below between the lines with the backticks.
+
+        To create it, use the `flutter create bug` command and update the `main.dart` file.
+
+        Alternatively, you can use https://dartpad.dev/ or create a public GitHub
+        repository to share your sample.
+
+        Without this we will unlikely be able to progress on the issue, and because of that
+        we regretfully will have to close it.
+
+        Note: Please do not upload screenshots of text. Instead, use code blocks
+        or the above mentioned ways to upload your code sample.
+      value: |
+        <details open><summary>Code sample</summary>
+
+        ```dart
+        [Paste your code here]
+        ```
+
+        </details>
+    validations:
+      required: true
+  - type: textarea
+    attributes:
+      label: Screenshots or Video
+      description: |
+        Upload any screenshots or video of the bug if applicable.
+      value: |
+        <details open>
+        <summary>Screenshots / Video demonstration</summary>
+
+        [Upload media here]
+
+        </details>
+  - type: textarea
+    attributes:
+      label: Logs
+      description: |
+        Include the full logs of the commands you are running between the lines
+        with the backticks below. If you are running any `flutter` commands,
+        please include the output of running them with `--verbose`; for example,
+        the output of running `flutter --verbose create foo`.
+
+        If the logs are too large to be uploaded to GitHub, you may upload
+        them as a `txt` file or use online tools like https://pastebin.com to
+        share it.
+
+        Note: Please do not upload screenshots of text. Instead, use code blocks
+        or the above mentioned ways to upload logs.
+      value: |
+        <details open><summary>Logs</summary>
+
+        ```console
+        [Paste your logs here]
+        ```
+
+        </details>
+  - type: textarea
+    attributes:
+      label: Flutter Doctor output
+      description: |
+        Please provide the full output of running `flutter doctor -v`
+      value: |
+        <details open><summary>Doctor output</summary>
+
+        ```console
+        [Paste your output here]
+        ```
+
+        </details>
+    validations:
+      required: true

.github/ISSUE_TEMPLATE/10_google3_bug.yml

@@ -1,3 +1,4 @@
+# TODO(matan): Update to reflect the new infra world, https://github.com/flutter/flutter/issues/165814
 name: The CI infrastructure used by Flutter has a problem
 description: |
   As a contributor, you want to file an issue about the build/test/release
@@ -23,11 +24,10 @@ body:
       description: |
         Is this a bug, feature request or Infra Task?
 
-        If you have a bug and you believe the issue is a blocker please add the P0 label and
-        set the project to 'Infra Ticket Queue.'
+        If you have a bug and you believe the issue is a blocker please add the `P0` label.
 
         If this is a devicelab feature such as a package update or a device is down please
-        add the 'device-lab' label to the created issue and set the project to 'Infra Ticket Queue.'
+        add the `infra: device lab` label to the created issue.
       options:
         - bug
         - feature request

.github/ISSUE_TEMPLATE/6_infrastructure.yml

@@ -229,6 +229,7 @@ team-infra:
     - any-glob-to-any-file:
       - docs/infra/**/*
 
+# Keep this synced with CODEOWNERS.
 team-ios:
   - changed-files:
     - any-glob-to-any-file:

.github/labeler.yml

@@ -0,0 +1,26 @@
+# Copyright 2013 The Flutter Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+name: Generate a content aware hash for the Flutter Engine
+
+on: workflow_dispatch
+
+jobs:
+  generate-engine-content-hash:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Fetch base commit and origin/master
+        run: |
+          git fetch --no-tags --prune --depth=1 origin ${{ github.event.pull_request.base.sha }}
+
+      - name: Generate Hash
+        run: |
+          engine_content_hash=$(git ls-tree HEAD DEPS bin/internal/release-candidate-branch.version engine | git hash-object --stdin)
+          # test notice annotation for retrival from api
+          echo "::notice ::{\"engine_content_hash\": \"${engine_content_hash}\"}"
+          # test summary writing
+          echo "{\"engine_content_hash\": \"${engine_content_hash}\"" >> $GITHUB_STEP_SUMMARY

.github/workflows/content-aware-hash.yml

@@ -86,6 +86,7 @@ unlinked_spec.ds
 **/android/key.properties
 *.jks
 local.properties
+**/.cxx/
 
 # iOS/XCode related
 **/ios/**/*.mode1v3

.gitignore

@@ -24,6 +24,42 @@ docs/releases/Hotfix-Documentation-Best-Practices.md
 
 INTERNAL NOTE
 -->
+## Flutter 3.29 Changes
+
+### [3.29.2](https://github.com/flutter/flutter/releases/tag/3.29.2)
+
+- [flutter/163175](https://github.com/flutter/flutter/pull/163175) - Improve performance of CanvasKit rendering for web.
+- [flutter/164628](https://github.com/flutter/flutter/issues/164628) - iOS Fixes crash when allocation of surface for toImage/toImageSync fails.
+- [flutter/164201](https://github.com/flutter/flutter/pull/164201) - Always use Android hardware buffers for platform views when supported.
+- [flutter/162198](https://github.com/flutter/flutter/issues/162198) Fixes double-download of canvaskit.wasm
+- [flutter/164024](https://github.com/flutter/flutter/issues/164024): - Add back an empty io.flutter.app.FlutterApplication for Android apps post v2 embedder migration.
+- [flutter/162198](https://github.com/flutter/flutter/issues/162198) - Fixes double-download of canvaskit.wasm
+- [flutter/164392](https://github.com/flutter/flutter/pull/164392) - All platforms, Fixes a crash that can occur when animating and interacting with a scrollable simultaneously.
+
+### [3.29.1](https://github.com/flutter/flutter/releases/tag/3.29.1)
+
+- [flutter/163830](https://github.com/flutter/flutter/pull/163830) - Fix Tab linear and elastic animation blink.
+- [flutter/164119](https://github.com/flutter/flutter/pull/164119) - Configuration changes to run test on macOS 14 for Flutter's CI.
+- [flutter/164155](https://github.com/flutter/flutter/pull/164155) - Roll .ci.yaml changes into the LUCI configuration only when the master branch is updated.
+- [flutter/164191](https://github.com/flutter/flutter/pull/164191) - Improve safaridriver launch process in Flutter's CI testing for web.
+- [flutter/164193](https://github.com/flutter/flutter/pull/164193) - Provide guided error message when app crashes due to JIT restriction on iPhones.
+- [flutter/164050](https://github.com/flutter/flutter/pull/164050) - Fixes test reorderable_list_test.dart failing for certain ordering seeds, such as 20250221.
+- [flutter/163316](https://github.com/flutter/flutter/pull/163316) - Configuration changes to run test on macOS 14 for Flutter's CI.
+- [flutter/163581](https://github.com/flutter/flutter/pull/163581) - Fix crash when using BackdropFilters in certain GLES drivers.
+- [flutter/163616](https://github.com/flutter/flutter/pull/163616) - Disable Vulkan on known bad Xclipse GPU drivers for Android.
+- [flutter/163666](https://github.com/flutter/flutter/pull/163666) - Always post new task during gesture dispatch to fix jittery scrolling on iOS devices.
+- [flutter/163667](https://github.com/flutter/flutter/pull/163667) - Ensure that OpenGL "flipped" textures do not leak via texture readback.
+- [flutter/163741](https://github.com/flutter/flutter/pull/163741) - Flutter tool respects tracked engine.version.
+- [flutter/163754](https://github.com/flutter/flutter/pull/163754) - Fix text glitch when returning to foreground for Android.
+- [flutter/163058](https://github.com/flutter/flutter/pull/163058) - Fixes jittery glyphs.
+- [flutter/163201](https://github.com/flutter/flutter/pull/163201) - Fixes buttons with icons that ignore foregroundColor.
+- [flutter/163265](https://github.com/flutter/flutter/pull/163265) - Disable Vulkan on known bad exynos SoCs for Android.
+- [flutter/163261](https://github.com/flutter/flutter/pull/163261) - Fixes for Impeller DrawVertices issues involving snapshots with empty sizes.
+- [flutter/163672](https://github.com/flutter/flutter/pull/163672) - Check for tracked engine.version before overriding.
+
+### [3.29.0](https://github.com/flutter/flutter/releases/tag/3.29.0)
+Initial stable release.
+
 ## Flutter 3.27 Changes
 
 ### [3.27.4](https://github.com/flutter/flutter/releases/tag/3.27.4)
@@ -127,7 +163,7 @@ Initial stable release.
 - [flutter/149704](https://github.com/flutter/flutter/issues/149704) - [Impeller] Fixes and issue on iOS where flickering may be occur when translating a blurred rounded rectangle.
 - [flutter/149745](https://github.com/flutter/flutter/issues/149745) - [Impeller] Fixes a segfault on iOS when tessellating empty convex polygons.
 - [flutter/149771](https://github.com/flutter/flutter/issues/149771) - [Impeller] Fixes a rendering error on iOS when advanced blend is double scaled.
-- [flutter/53183](https://github.com/flutter/engine/pull/53183) - Fixes an issue where Linux apps show visual corruption on some frames
+- [flutter/53183](https://github.com/flutter/engine/pull/53183) - Fixes an issue where Linux apps show visual corruption on some frames.
 - [flutter/149856](https://github.com/flutter/flutter/issues/149856) - Clarifies Flutter Fix log on how to update Kotlin Gradle Plugin that was introduced in Flutter 3.19.
 - [flutter/150617](https://github.com/flutter/flutter/pull/150617) - Fixes a bug in `flutter test` where `--flavor` wasn't considered when validating cached assets, causing the flavor-conditional asset bundling feature to not work as expected.
 - [flutter/150724](https://github.com/flutter/flutter/issues/150724) - Fixes an issue on Web+Linux that prevents users from inputting data using the numpad.

CHANGELOG.md

@@ -6,11 +6,37 @@
 #
 # Use git ls-files '<pattern>' without a / prefix to see the list of matching files.
 
-/packages/flutter_tools/templates/module/ios/ @jmagman
-/packages/flutter_tools/templates/**/Podfile* @jmagman
-/packages/flutter_tools/lib/src/ios/ @jmagman
+/engine/src/build/config/ios/** @vashworth
+/packages/flutter_tools/templates/module/ios/ @vashworth
+/packages/flutter_tools/templates/**/Podfile* @vashworth
+/packages/flutter_tools/lib/src/ios/ @vashworth
 
-# flutter_driver, integration_test, and internal dev infra.
-/dev/** @matanlurey
-/packages/flutter_driver/** @matanlurey
-/packages/integration_test/** @matanlurey
+# Internal dev infra that is closely tied to team-infra.
+/bin/internal/update_engine_version.ps1 @matanlurey
+/bin/internal/update_engine_version.sh @matanlurey
+/dev/bots/** @matanlurey
+/dev/conductor/** @matanlurey
+/dev/devicelab/** @matanlurey
+/dev/tools/test/update_engine_version_test.dart @matanlurey
+
+# flutter_drver, integration_test. Intentionally omit root files (i.e. pubspec.yaml upgrades).
+/dev/tools/android_driver_extensions @matanlurey
+/packages/flutter_driver/lib/** @matanlurey
+/packages/flutter_driver/test/** @matanlurey
+/packages/integration_test/lib/** @matanlurey
+/packages/integration_test/test/** @matanlurey
+
+# The following files define an Application Binary Interface (ABI) that must maintain
+# both forward and backward compatibility. Changes should be heavily
+# scrutinized as mistakes are irreversible.
+/engine/src/flutter/shell/platform/embedder/embedder.h @cbracken @chinmaygarde @loic-sharma
+/engine/src/flutter/shell/platform/embedder/tests/embedder_frozen.h @cbracken @chinmaygarde @loic-sharma
+
+# iOS team - keep this synced with .github/labeler.yml's team-ios section.
+/engine/src/flutter/shell/platform/darwin/common/ @flutter/ios-reviewers
+/engine/src/flutter/shell/platform/darwin/ios/framework/ @flutter/ios-reviewers
+/packages/flutter_tools/**/ios/* @flutter/ios-reviewers
+/packages/flutter_tools/**/macos/* @flutter/ios-reviewers
+/packages/flutter_tools/**/*xcode* @flutter/ios-reviewers
+/packages/flutter_tools/**/*ios* @flutter/ios-reviewers
+/packages/flutter_tools/**/*macos* @flutter/ios-reviewers