Remove legacy scenec stuff from flutter_tool (flutter#163569)

o7

Removes the legacy scenec logic from flutter_tool. We removed scenec
from the engine/shipped artifacts long ago. Originally added in
flutter#118157. This has since been
replaced by
[flutter_scene_importer](https://pub.dev/packages/flutter_scene_importer/versions)!

Author: bdero

packages/flutter_tools/lib/src/artifacts.dart

@@ -122,8 +122,6 @@ enum HostArtifact {
 
   // The Impeller shader compiler.
   impellerc,
-  // The Impeller Scene 3D model importer.
-  scenec,
   // Impeller's tessellation library.
   libtessellator,
 }
@@ -264,8 +262,6 @@ String _hostArtifactToFileName(HostArtifact artifact, Platform platform) {
       return 'dart_sdk.js.map';
     case HostArtifact.impellerc:
       return 'impellerc$exe';
-    case HostArtifact.scenec:
-      return 'scenec$exe';
     case HostArtifact.libtessellator:
       return 'libtessellator$dll';
   }
@@ -480,7 +476,6 @@ class CachedArtifacts implements Artifacts {
         final String artifactFileName = _hostArtifactToFileName(artifact, _platform);
         return _cache.getArtifactDirectory('usbmuxd').childFile(artifactFileName);
       case HostArtifact.impellerc:
-      case HostArtifact.scenec:
       case HostArtifact.libtessellator:
         final String artifactFileName = _hostArtifactToFileName(artifact, _platform);
         final String engineDir =
@@ -1147,7 +1142,6 @@ class CachedLocalEngineArtifacts implements Artifacts {
         final String artifactFileName = _hostArtifactToFileName(artifact, _platform);
         return _cache.getArtifactDirectory('usbmuxd').childFile(artifactFileName);
       case HostArtifact.impellerc:
-      case HostArtifact.scenec:
       case HostArtifact.libtessellator:
         final String artifactFileName = _hostArtifactToFileName(artifact, _platform);
         final File file = _fileSystem.file(
@@ -1506,7 +1500,6 @@ class CachedLocalWebSdkArtifacts implements Artifacts {
       case HostArtifact.iproxy:
       case HostArtifact.skyEnginePath:
       case HostArtifact.impellerc:
-      case HostArtifact.scenec:
       case HostArtifact.libtessellator:
         return _parent.getHostArtifact(artifact);
     }

packages/flutter_tools/lib/src/asset.dart

@@ -72,7 +72,7 @@ abstract class AssetBundleFactory {
   AssetBundle createBundle();
 }
 
-enum AssetKind { regular, font, shader, model }
+enum AssetKind { regular, font, shader }
 
 /// Contains all information about an asset needed by tool the to prepare and
 /// copy an asset file to the build output.
@@ -959,22 +959,6 @@ class ManifestAssetBundle implements AssetBundle {
       );
     }
 
-    for (final Uri modelUri in flutterManifest.models) {
-      _parseAssetFromFile(
-        packageConfig,
-        flutterManifest,
-        assetBase,
-        cache,
-        result,
-        modelUri,
-        packageName: packageName,
-        attributedPackage: attributedPackage,
-        assetKind: AssetKind.model,
-        flavors: <String>{},
-        transformers: <AssetTransformerEntry>[],
-      );
-    }
-
     // Add assets referenced in the fonts section of the manifest.
     for (final Font font in flutterManifest.fonts) {
       for (final FontAsset fontAsset in font.fontAssets) {

packages/flutter_tools/lib/src/build_system/targets/assets.dart

@@ -16,7 +16,6 @@ import '../build_system.dart';
 import '../depfile.dart';
 import '../exceptions.dart';
 import '../tools/asset_transformer.dart';
-import '../tools/scene_importer.dart';
 import '../tools/shader_compiler.dart';
 import 'common.dart';
 import 'icon_tree_shaker.dart';
@@ -83,12 +82,6 @@ Future<Depfile> copyAssets(
     fileSystem: environment.fileSystem,
     artifacts: environment.artifacts,
   );
-  final SceneImporter sceneImporter = SceneImporter(
-    processManager: environment.processManager,
-    logger: environment.logger,
-    fileSystem: environment.fileSystem,
-    artifacts: environment.artifacts,
-  );
   final AssetTransformer assetTransformer = AssetTransformer(
     processManager: environment.processManager,
     fileSystem: environment.fileSystem,
@@ -160,12 +153,6 @@ Future<Depfile> copyAssets(
                     outputPath: file.path,
                     targetPlatform: targetPlatform,
                   );
-            case AssetKind.model:
-              doCopy =
-                  !await sceneImporter.importScene(
-                    input: content.file as File,
-                    outputPath: file.path,
-                  );
           }
           if (doCopy) {
             await (content.file as File).copy(file.path);

packages/flutter_tools/lib/src/build_system/tools/scene_importer.dart

@@ -15,7 +15,6 @@ import 'build_info.dart';
 import 'build_system/build_system.dart';
 import 'build_system/depfile.dart';
 import 'build_system/tools/asset_transformer.dart';
-import 'build_system/tools/scene_importer.dart';
 import 'build_system/tools/shader_compiler.dart';
 import 'bundle.dart';
 import 'cache.dart';
@@ -166,13 +165,6 @@ Future<void> writeBundle(
     artifacts: artifacts,
   );
 
-  final SceneImporter sceneImporter = SceneImporter(
-    processManager: processManager,
-    logger: logger,
-    fileSystem: fileSystem,
-    artifacts: artifacts,
-  );
-
   final AssetTransformer assetTransformer = AssetTransformer(
     processManager: processManager,
     fileSystem: fileSystem,
@@ -225,8 +217,6 @@ Future<void> writeBundle(
                     outputPath: file.path,
                     targetPlatform: targetPlatform,
                   );
-            case AssetKind.model:
-              doCopy = !await sceneImporter.importScene(input: input, outputPath: file.path);
           }
           if (doCopy) {
             input.copySync(file.path);

packages/flutter_tools/lib/src/bundle_builder.dart

@@ -525,8 +525,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
 
     final List<Uri> shaders = rootManifest.shaders.map(transformAssetUri).toList();
 
-    final List<Uri> models = rootManifest.models.map(transformAssetUri).toList();
-
     final List<DeferredComponent>? deferredComponents =
         rootManifest.deferredComponents?.map(transformDeferredComponent).toList();
 
@@ -535,7 +533,6 @@ final class WidgetPreviewStartCommand extends WidgetPreviewSubCommandBase with C
       assets: assets,
       fonts: fonts,
       shaders: shaders,
-      models: models,
       deferredComponents: deferredComponents,
     );
   }

packages/flutter_tools/lib/src/commands/widget_preview.dart

@@ -19,7 +19,6 @@ import 'base/net.dart';
 import 'base/os.dart';
 import 'build_info.dart';
 import 'build_system/tools/asset_transformer.dart';
-import 'build_system/tools/scene_importer.dart';
 import 'build_system/tools/shader_compiler.dart';
 import 'compile.dart';
 import 'convert.dart' show base64, utf8;
@@ -476,7 +475,6 @@ class DevFS {
   final Directory rootDirectory;
   final Set<String> assetPathsToEvict = <String>{};
   final Set<String> shaderPathsToEvict = <String>{};
-  final Set<String> scenePathsToEvict = <String>{};
 
   // A flag to indicate whether we have called `setAssetDirectory` on the target device.
   bool hasSetAssetDirectory = false;
@@ -564,7 +562,6 @@ class DevFS {
     required PackageConfig packageConfig,
     required String dillOutputPath,
     required DevelopmentShaderCompiler shaderCompiler,
-    DevelopmentSceneImporter? sceneImporter,
     DevFSWriter? devFSWriter,
     String? target,
     AssetBundle? bundle,
@@ -654,23 +651,6 @@ class DevFS {
                 shaderPathsToEvict.add(archivePath);
               }
             });
-          case AssetKind.model:
-            if (sceneImporter == null) {
-              break;
-            }
-            final Future<DevFSContent?> pending = sceneImporter.reimportScene(entry.content);
-            pendingAssetBuilds.add(pending);
-            pending.then((DevFSContent? content) {
-              if (content == null) {
-                assetBuildFailed = true;
-                return;
-              }
-              dirtyEntries[deviceUri] = content;
-              syncedBytes += content.size;
-              if (!bundleFirstUpload) {
-                scenePathsToEvict.add(archivePath);
-              }
-            });
           case AssetKind.regular:
           case AssetKind.font:
           case null: