Skip to content

Commit a52f552

Browse files
Revert "revert"
This reverts commit b8568b6.
1 parent b8568b6 commit a52f552

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

engine/src/flutter/runtime/dart_plugin_registrant_unittests.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class DartIsolateTest : public FixtureTest {
5252
};
5353

5454
TEST_F(DartIsolateTest, DartPluginRegistrantIsPresent) {
55-
#if defined(OS_FUCHSIA)
55+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
5656
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
5757
#else
5858
ASSERT_FALSE(DartVMRef::IsInstanceRunning());
@@ -103,7 +103,7 @@ TEST_F(DartIsolateTest, DartPluginRegistrantIsPresent) {
103103
}
104104

105105
TEST_F(DartIsolateTest, DartPluginRegistrantFromBackgroundIsolate) {
106-
#if defined(OS_FUCHSIA)
106+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
107107
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
108108
#else
109109
ASSERT_FALSE(DartVMRef::IsInstanceRunning());
@@ -155,7 +155,7 @@ TEST_F(DartIsolateTest, DartPluginRegistrantFromBackgroundIsolate) {
155155
}
156156

157157
TEST_F(DartIsolateTest, DartPluginRegistrantNotFromBackgroundIsolate) {
158-
#if defined(OS_FUCHSIA)
158+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
159159
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
160160
#else
161161
ASSERT_FALSE(DartVMRef::IsInstanceRunning());
@@ -208,7 +208,7 @@ TEST_F(DartIsolateTest, DartPluginRegistrantNotFromBackgroundIsolate) {
208208
}
209209

210210
TEST_F(DartIsolateTest, DartPluginRegistrantWhenRegisteringBackgroundIsolate) {
211-
#if defined(OS_FUCHSIA)
211+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
212212
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
213213
#else
214214
ASSERT_FALSE(DartVMRef::IsInstanceRunning());

engine/src/flutter/runtime/no_dart_plugin_registrant_unittests.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class DartIsolateTest : public FixtureTest {
2626
};
2727

2828
TEST_F(DartIsolateTest, DartPluginRegistrantIsNotPresent) {
29-
#if defined(OS_FUCHSIA)
29+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
3030
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
3131
#else
3232
ASSERT_FALSE(DartVMRef::IsInstanceRunning());

engine/src/flutter/shell/platform/embedder/tests/embedder_a11y_unittests.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ constexpr static char kTooltip[] = "tooltip";
3434
#endif
3535

3636
TEST_F(EmbedderTest, CannotProvideMultipleSemanticsCallbacks) {
37-
#if defined(OS_FUCHSIA)
37+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
3838
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
3939
#else
4040
{
@@ -100,7 +100,7 @@ TEST_F(EmbedderTest, CannotProvideMultipleSemanticsCallbacks) {
100100
}
101101

102102
TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV3Callbacks) {
103-
#if defined(OS_FUCHSIA)
103+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
104104
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
105105
#else
106106
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();
@@ -278,7 +278,7 @@ TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV3Callbacks) {
278278
}
279279

280280
TEST_F(EmbedderA11yTest, A11yStringAttributes) {
281-
#if defined(OS_FUCHSIA)
281+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
282282
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
283283
#else
284284
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();
@@ -397,7 +397,7 @@ TEST_F(EmbedderA11yTest, A11yStringAttributes) {
397397
}
398398

399399
TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV2Callbacks) {
400-
#if defined(OS_FUCHSIA)
400+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
401401
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
402402
#else
403403
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();
@@ -573,7 +573,7 @@ TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV2Callbacks) {
573573
}
574574

575575
TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV1Callbacks) {
576-
#if defined(OS_FUCHSIA)
576+
#if defined(OS_FUCHSIA) && (FLUTTER_RUNTIME_MODE != FLUTTER_RUNTIME_MODE_DEBUG)
577577
GTEST_SKIP() << "Dart_LoadELF is not implemented on Fuchsia.";
578578
#else
579579
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();

engine/src/flutter/testing/fuchsia/test_suites.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@
9292
- test_command: test run fuchsia-pkg://fuchsia.com/tonic_unittests#meta/tonic_unittests.cm
9393
disabled: Dart_LoadELF isn't implemented on Fuchsia
9494
package: tonic_unittests-0.far
95-
variant: disabled
95+
variant: debug
9696
- test_command: test run fuchsia-pkg://fuchsia.com/touch-input-test#meta/touch-input-test.cm
9797
packages:
9898
- touch-input-test-0.far

0 commit comments

Comments
 (0)