update theme variables to FC. add docs

Author: craigh

CHANGELOG-1.5.md

@@ -48,6 +48,9 @@ CHANGELOG - ZIKULA 1.5.x
           https://symfony.com/blog/new-in-symfony-3-2-runtime-environment-variables
     - `\Zikula\Component\SortableColumns\Column#setIsSortColumn()` is deprecated. Use `setSortColumn() instead.
     - The `MetaTagExtension` class is deprecated which includes the Twig function named `setMetaTag`. Use `pageSetVar` instead.
+    - Using simple strings as form types in a theme's variables.yml is deprecated, use FqCN instead.
+        - Form options are similarly modified, for example a `choices` array must be formatted according to Symfony's
+            rules with respect to `choices_as_values`, etc. This changes from Core-1.5 to Core-2.0 which adopts Symfony 3
 
  - Fixes:
     - Corrected path to legacy module's admin icons.

src/docs/Themes/ThemeVariables.md

@@ -0,0 +1,26 @@
+Theme Variables
+===============
+
+filepath: `/Resources/config/variables.yml`
+
+The contents of this file can vary. At the very list, it can be a list of variables and values
+that will be passed along to the theme engine as global variables within your theme, e.g.:
+
+    {{ themevars.<variablename> }}
+
+Additionally, dynamically created forms (using the symfony form engine) can be used by creating a yml definition like so:
+
+    home:
+      default_value: 3col_w_centerblock
+      type: 'Symfony\Component\Form\Extension\Core\Type\ChoiceType'
+      options:
+        choices_as_values: true
+        choices:
+          'One column': 1col
+          'Two columns': 2col
+          'Two columns with centerblock': 2col_w_centerblock
+          'Three columns': 3col
+          'Three columns with centerblock': 3col_w_centerblock
+
+These pseudo-forms are created an available to the site admin through the Theme Module UI. The selected value then
+becomes available to templates as referenced above.

src/themes/AtomTheme/Resources/config/variables.yml

@@ -3,7 +3,7 @@
 ##
 showdescription:
   default_value: true
-  type: checkbox
+  type: 'Symfony\Component\Form\Extension\Core\Type\CheckboxType'
   options:
     label: "Show item descriptions"
     disabled: true

src/themes/BootstrapTheme/Resources/config/variables.yml

@@ -3,31 +3,34 @@
 ##
 home:
   default_value: 3col_w_centerblock
-  type: choice
+  type: 'Symfony\Component\Form\Extension\Core\Type\ChoiceType'
   options:
+    choices_as_values: true
     choices:
-      1col: One column
-      2col: Two columns
-      2col_w_centerblock: Two columns with centerblock
-      3col: Three columns
-      3col_w_centerblock: Three columns with centerblock
+      'One column': 1col
+      'Two columns': 2col
+      'Two columns with centerblock': 2col_w_centerblock
+      'Three columns': 3col
+      'Three columns with centerblock': 3col_w_centerblock
 master:
   default_value: 2col
-  type: choice
+  type: 'Symfony\Component\Form\Extension\Core\Type\ChoiceType'
   options:
+    choices_as_values: true
     choices:
-      1col: One column
-      2col: Two columns
-      2col_w_centerblock: Two columns with centerblock
-      3col: Three columns
-      3col_w_centerblock: Three columns with centerblock
+      'One column': 1col
+      'Two columns': 2col
+      'Two columns with centerblock': 2col_w_centerblock
+      'Three columns': 3col
+      'Three columns with centerblock': 3col_w_centerblock
 admin:
   default_value: 1col
-  type: choice
+  type: 'Symfony\Component\Form\Extension\Core\Type\ChoiceType'
   options:
+    choices_as_values: true
     choices:
-      1col: One column
-      2col: Two columns
-      2col_w_centerblock: Two columns with centerblock
-      3col: Three columns
-      3col_w_centerblock: Three columns with centerblock
+      'One column': 1col
+      'Two columns': 2col
+      'Two columns with centerblock': 2col_w_centerblock
+      'Three columns': 3col
+      'Three columns with centerblock': 3col_w_centerblock

src/themes/RssTheme/Resources/config/variables.yml

@@ -3,15 +3,16 @@
 ##
 showdescription:
   default_value: true
-  type: checkbox
+  type: 'Symfony\Component\Form\Extension\Core\Type\CheckboxType'
   options:
     label: "Show item descriptions"
     disabled: true
 rsslevel:
   default_value: rss20
-  type: choice
+  type: 'Symfony\Component\Form\Extension\Core\Type\ChoiceType'
   options:
+    choices_as_values: true
     label: "RSS Version"
     choices:
-      rss091: "RSS v0.91"
-      rss20: "RSS v0.20"
+      "RSS v0.91": rss091
+      "RSS v0.20": rss20