Merge pull request #1186 from zino-hofmann/macros/fix_rebasing

fix `SocketClient` to close subscription on socket close

Author: vincenzopalazzo

packages/graphql/lib/src/links/websocket_link/websocket_client.dart

@@ -495,7 +495,19 @@ class SocketClient {
                 .where((message) => message is SubscriptionComplete)
                 .take(1);
 
-        subscriptionComplete.listen((_) => response.close());
+        subscriptionComplete.listen(
+          (_) => response.close(),
+          onDone: () {
+            if (!config.autoReconnect) {
+              response.close();
+            }
+          },
+          onError: (_) {
+            if (!config.autoReconnect) {
+              response.close();
+            }
+          },
+        );
 
         dataErrorComplete
             .where((message) => message is SubscriptionData)

packages/graphql/test/websocket_test.dart

@@ -613,7 +613,8 @@ Future<void> main() async {
         operation: Operation(document: gql('subscription {}')),
       );
       final waitForConnection = true;
-      socketClient.subscribe(payload, waitForConnection);
+      var subscription = socketClient.subscribe(payload, waitForConnection);
+      var isEmpty = subscription.isEmpty;
 
       await expectLater(
         socketClient.connectionState,
@@ -638,6 +639,8 @@ Future<void> main() async {
 
       expect(
           socketClient.socketChannel!.closeCode, WebSocketStatus.normalClosure);
+
+      expect(await isEmpty.timeout(const Duration(seconds: 1)), true);
     });
   }, tags: "integration");