fix(graphql): remove unnecessary null checks in SocketClient

aarsham · aarsham · commit 1003c4b61d37 · 2024-04-08T16:37:12.000+03:30
**Fixes** - Removed unnecessary null checks(!) on SocketChannel instance in SocketClient onConnectionLost() method which cause an error when client cannot connect (#1379). this prevents reconnecting when there is a working connection later.
diff --git a/packages/graphql/lib/src/links/websocket_link/websocket_client.dart b/packages/graphql/lib/src/links/websocket_link/websocket_client.dart
@@ -372,8 +372,8 @@ class SocketClient {
   }
 
   void onConnectionLost([Object? e]) async {
-    var code = socketChannel!.closeCode;
-    var reason = socketChannel!.closeReason;
+    var code = socketChannel?.closeCode;
+    var reason = socketChannel?.closeReason;
 
     await _closeSocketChannel();
     if (e != null) {

Original file line number	Diff line number	Diff line change
`@@ -372,8 +372,8 @@ class SocketClient {`
`372`	`372`	`}`
`373`	`373`
`374`	`374`	`void onConnectionLost([Object? e]) async {`
`375`		`- var code = socketChannel!.closeCode;`
`376`		`- var reason = socketChannel!.closeReason;`
	`375`	`+ var code = socketChannel?.closeCode;`
	`376`	`+ var reason = socketChannel?.closeReason;`
`377`	`377`
`378`	`378`	`await _closeSocketChannel();`
`379`	`379`	`if (e != null) {`