JsonCodec.schemaBasedBinaryCodec issue with stream and group name when creating group

[AndreyKaBelka]

Hey there. This issue is related to a question from Discord. When using JsonCodec.schemaBasedBinaryCodec[A], all strings are escaped, including the stream name, group, and ID.
An example of group creation with this issue is provided in the repository.

This issue occurs in zio-redis versions 1.1.2, 1.0.0, and 0.2.0.

[mijicd]

This looks like an expected behavior as stream and group name are part of the command, thus encoded (not claiming that it's correct one though, it's not). We might be able to modify it, though we'll need to list all other affected commands and ensure nothing gets broken. Perhaps @hcwilhelm can provide more insight given that he recently worked with streams.

[hcwilhelm]

Dejan is right here name, group and id is part of the command and thus gets encoded by the provided BinaryEncoder.

object Main {
  def main(args: Array[String]) = {

    val jsonCodec: BinaryCodec[String] = JsonCodec.schemaBasedBinaryCodec
    val protobufCodec:  BinaryCodec[String] = ProtobufCodec.protobufCodec

    val s = "Foo"
    val jsonEncoded = jsonCodec.encode(s)
    val protobufEncoded = protobufCodec.encode(s)

    println(jsonEncoded.asString)
    println(protobufEncoded.asString)
  }
}

yield the following output

"Foo"
Foo

I don't exactly know where the escaping is introduced. It is indeed unfortunate that the special id character $ is encoded to "$" as this way Redis can't treat it as last entry.

@mijicd Any ideas on how we can fix that? Probably introduce an ADT for handling normal ID's and special ID's ?