This repository was archived by the owner on Jun 2, 2024. It is now read-only.
Remove FileNotFound error
#341
rylev
started this conversation in
Feature Design
Replies: 2 comments
-
|
I think the error type could do with some TLC. Is there any reason we shouldn't replace the |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
I'd like to open a new issue to address that. This should remain just for the FileNotFound case. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Currently the
FileNotFounderror does not really represent an error case so much as the user has asked for a file that doesn't exist. This is normally represented as aNonein an option. I think we should returnZipResult<Option<ZipFile>>fromZipArchive::by_indexandZipArchive::by_nameBeta Was this translation helpful? Give feedback.
All reactions