fix bad triangulation

Author: zippy84

Contact.cxx

@@ -634,15 +634,19 @@ void Contact::InterPolys (vtkIdType idA, vtkIdType idB) {
     bool hasReplB = replsB.count(idB) == 1;
 
     if (!isPlanarA && !hasReplA && newPdA->GetCellType(idA) != VTK_TRIANGLE) {
-        auto newIds = PreventEqualCaptPoints::TriangulateCell(newPdA, idA, {});
-        replsA.emplace(idA, newIds);
-        hasReplA = true;
+        try {
+            auto newIds = PreventEqualCaptPoints::TriangulateCell(newPdA, idA, {});
+            replsA.emplace(idA, newIds);
+            hasReplA = true;
+        } catch (...) {}
     }
 
     if (!isPlanarB && !hasReplB && newPdB->GetCellType(idB) != VTK_TRIANGLE) {
-        auto newIds = PreventEqualCaptPoints::TriangulateCell(newPdB, idB, {});
-        replsB.emplace(idB, newIds);
-        hasReplB = true;
+        try {
+            auto newIds = PreventEqualCaptPoints::TriangulateCell(newPdB, idB, {});
+            replsB.emplace(idB, newIds);
+            hasReplB = true;
+        } catch (...) {}
     }
 
     if (hasReplA || hasReplB) {

Optimize.cxx

@@ -450,6 +450,22 @@ IdsType PreventEqualCaptPoints::TriangulateCell (vtkPolyData *pd, vtkIdType cell
         ids->InsertNextId(p.id);
     }
 
+    double pA[3], pB[3], pC[3];
+
+    for (i = 0; i < triangles->GetNumberOfIds(); i += 3) {
+        pd->GetPoint(ids->GetId(triangles->GetId(i)), pA);
+        pd->GetPoint(ids->GetId(triangles->GetId(i+1)), pB);
+        pd->GetPoint(ids->GetId(triangles->GetId(i+2)), pC);
+
+        Poly p = { {pA[0], pA[1], pA[2]}, {pB[0], pB[1], pB[2]}, {pC[0], pC[1], pC[2]} };
+
+        double quality = GetTringleQuality(p);
+
+        if (quality < 0.001) {
+            throw std::runtime_error("");
+        }
+    }
+
     vtkIdType origId = origCellIds->GetValue(cellId);
 
     auto triangle = vtkSmartPointer<vtkIdList>::New();

Utilities.cxx

@@ -76,6 +76,8 @@ void FindPoints (vtkKdTreePointLocator *pl, const double *pt, vtkIdList *pts, do
 
 #ifdef DEBUG
 void WriteVTK (const char *name, vtkPolyData *pd) {
+    std::cout << "Writing " << name << std::endl;
+
     vtkPolyDataWriter *w = vtkPolyDataWriter::New();
     w->SetInputData(pd);
     w->SetFileName(name);
@@ -347,3 +349,25 @@ vtkSmartPointer<vtkPolyData> CreatePolyData (const PolysType &polys) {
 
     return pd;
 }
+
+double GetTringleQuality (const Poly &poly) {
+    double n[3];
+
+    double l = ComputeNormal(poly, n);
+
+    double d = 0;
+
+    Poly::const_iterator itrA, itrB;
+
+    for (itrA = poly.begin(); itrA != poly.end(); ++itrA) {
+        itrB = itrA+1;
+
+        if (itrB == poly.end()) {
+            itrB = poly.begin();
+        }
+
+        d += std::sqrt(Point3d::GetDist(*itrA, *itrB));
+    }
+
+    return 10.392304845413264*l/(d*d);
+}

Utilities.h

@@ -216,4 +216,6 @@ void ProjOnLine (vtkPolyData *pd, const Pair &line, const Point3d &p, std::share
 
 vtkSmartPointer<vtkPolyData> CreatePolyData (const PolysType &polys);
 
+double GetTringleQuality (const Poly &poly);
+
 #endif

vtkPolyDataBooleanFilter.cxx

@@ -119,10 +119,7 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             modPdB->EditableOn();
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA.vtk" << std::endl;
             WriteVTK("modPdA.vtk", modPdA);
-
-            std::cout << "Exporting modPdB.vtk" << std::endl;
             WriteVTK("modPdB.vtk", modPdB);
 #endif
 
@@ -151,13 +148,8 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             times.push_back(clock::now()-start);
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA_1.vtk" << std::endl;
             WriteVTK("modPdA_1.vtk", modPdA);
-
-            std::cout << "Exporting modPdB_1.vtk" << std::endl;
             WriteVTK("modPdB_1.vtk", modPdB);
-
-            std::cout << "Exporting contLines.vtk" << std::endl;
             WriteVTK("contLines.vtk", contLines);
 #endif
 
@@ -238,10 +230,7 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             times.push_back(clock::now()-start);
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA_2.vtk" << std::endl;
             WriteVTK("modPdA_2.vtk", modPdA);
-
-            std::cout << "Exporting modPdB_2.vtk" << std::endl;
             WriteVTK("modPdB_2.vtk", modPdB);
 #endif
 
@@ -253,10 +242,7 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             times.push_back(clock::now()-start);
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA_3.vtk" << std::endl;
             WriteVTK("modPdA_3.vtk", modPdA);
-
-            std::cout << "Exporting modPdB_3.vtk" << std::endl;
             WriteVTK("modPdB_3.vtk", modPdB);
 #endif
 
@@ -268,10 +254,7 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             times.push_back(clock::now()-start);
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA_4.vtk" << std::endl;
             WriteVTK("modPdA_4.vtk", modPdA);
-
-            std::cout << "Exporting modPdB_4.vtk" << std::endl;
             WriteVTK("modPdB_4.vtk", modPdB);
 #endif
 
@@ -283,10 +266,7 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             times.push_back(clock::now()-start);
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA_5.vtk" << std::endl;
             WriteVTK("modPdA_5.vtk", modPdA);
-
-            std::cout << "Exporting modPdB_5.vtk" << std::endl;
             WriteVTK("modPdB_5.vtk", modPdB);
 #endif
 
@@ -298,10 +278,7 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             times.push_back(clock::now()-start);
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA_6.vtk" << std::endl;
             WriteVTK("modPdA_6.vtk", modPdA);
-
-            std::cout << "Exporting modPdB_6.vtk" << std::endl;
             WriteVTK("modPdB_6.vtk", modPdB);
 #endif
 
@@ -313,10 +290,7 @@ int vtkPolyDataBooleanFilter::RequestData(vtkInformation *request, vtkInformatio
             times.push_back(clock::now()-start);
 
 #ifdef DEBUG
-            std::cout << "Exporting modPdA_7.vtk" << std::endl;
             WriteVTK("modPdA_7.vtk", modPdA);
-
-            std::cout << "Exporting modPdB_7.vtk" << std::endl;
             WriteVTK("modPdB_7.vtk", modPdB);
 #endif
 
@@ -2717,10 +2691,7 @@ bool vtkPolyDataBooleanFilter::CombineRegions () {
     vtkPolyData *pdB = cfB->GetOutput();
 
 #ifdef DEBUG
-    std::cout << "Exporting modPdA_8.vtk" << std::endl;
     WriteVTK("modPdA_8.vtk", pdA);
-
-    std::cout << "Exporting modPdB_8.vtk" << std::endl;
     WriteVTK("modPdB_8.vtk", pdB);
 #endif