fix(ci): unblock daily-qa network and add issue input#115
Conversation
- Add strict: false to allow ecosystem identifiers through firewall - Add github, containers ecosystems to network.allowed - Add workflow_dispatch input for issue/discussion number targeting - Only create issues for actionable findings, otherwise report via discussions - Recompile lock file with gh-aw v0.47.1
Benchmark ResultsNo benchmarks configured. Add benchmarks to benches/ directory. Full results available in CI artifacts. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 9 9
Lines 6499 6499
=======================================
Hits 6228 6228
Misses 271 271 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code Coverage ReportOverall Coverage: 0% SummaryFull HTML report available in CI artifacts. |
There was a problem hiding this comment.
Pull request overview
This PR fixes network access issues in the Daily QA workflow by configuring the Agent Workflow Firewall to allow access to Rust/Cargo ecosystems, and adds the ability to focus QA analysis on specific issues via a workflow dispatch input. The changes address Discussion #114 where cargo operations and GitHub API calls were blocked with 403 errors.
Changes:
- Added
strict: falseand ecosystem identifiers (github,rust,containers) to network configuration, enabling access to crates.io, rustup, and related domains needed for Rust development - Added
issueinput parameter toworkflow_dispatchtrigger, allowing manual runs to target specific issues or discussions for focused QA analysis - Updated workflow instructions to emphasize creating issues only for actionable problems (bugs, test failures, documentation errors) rather than informational findings
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/daily-qa.md | Source workflow configuration with network fixes, new issue input, and improved issue creation discipline |
| .github/workflows/daily-qa.lock.yml | Generated lockfile with compiler v0.47.1 incorporating network domain allowlists, issue input wiring, and infrastructure updates |
| .github/aw/actions-lock.json | Added version entry for gh-aw/actions/setup@v0.47.1 |
|
|
||
| concurrency: | ||
| group: "gh-aw-${{ github.workflow }}" | ||
| group: "gh-aw-${{ github.workflow }}-${{ github.event.discussion.number }}" |
There was a problem hiding this comment.
The concurrency group was changed from gh-aw-${{ github.workflow }} to include ${{ github.event.discussion.number }}. However, this workflow is only triggered by schedule and workflow_dispatch events (lines 35-42), neither of which populate github.event.discussion.number. This means the expression will always evaluate to gh-aw-Daily QA- (with an empty string for the discussion number), causing all runs to share the same concurrency group.
This appears to be introduced by the compiler upgrade from v0.45.0 to v0.47.1. Since this is a generated file, this may be a compiler bug that should be reported upstream. For now, consider:
- Checking if there's a way to configure concurrency in the source .md file
- Reporting this as a bug to the gh-aw compiler maintainers
- As a temporary workaround, manually fixing this line to
group: "gh-aw-${{ github.workflow }}"(though this would be overwritten on next compile)
| group: "gh-aw-${{ github.workflow }}-${{ github.event.discussion.number }}" | |
| group: "gh-aw-${{ github.workflow }}" |
Summary
strict: false,github, andcontainersecosystem identifiers tonetwork.allowed— resolves the 403 firewall blocks on cargo/crates.io and GitHub API calls reported in discussion Daily QAReport - 2026-02-27 #114workflow_dispatchinput so the QA report can target a specific issue/discussion numberContext
Discussion #114 showed all cargo operations (
build,test,clippy,doc) and GitHub API calls failing withCONNECT tunnel failed, response 403due to the Agent Workflow Firewall blocking egress. Therustecosystem identifier was present butstrictmode (default) was preventing non-defaultsidentifiers from resolving.Test plan
gh aw compile daily-qasucceeds with 0 errorsissue: 114input and verify focused analysis