replace () > 0) with isempty

Donnnno · Donnnno · commit b195ca2915c6 · 2025-01-21T16:39:54.000+01:00
diff --git a/library/src/main/java/candybar/lib/activities/CandyBarMainActivity.java b/library/src/main/java/candybar/lib/activities/CandyBarMainActivity.java
@@ -865,7 +865,7 @@ private void initNavigationViewHeader() {
             image.setRatio(16, 9);
         }
 
-        if (titleText.length() == 0) {
+        if (titleText.isEmpty()) {
             container.setVisibility(View.GONE);
         } else {
             title.setText(titleText);
diff --git a/library/src/main/java/candybar/lib/activities/CandyBarSplashActivity.java b/library/src/main/java/candybar/lib/activities/CandyBarSplashActivity.java
@@ -153,7 +153,7 @@ protected boolean run() {
                             return false;
                         }
 
-                        if (list.size() > 0 && list.get(0) instanceof Map) {
+                        if (!list.isEmpty() && list.get(0) instanceof Map) {
                             Map<?, ?> map = (Map<?, ?>) list.get(0);
                             String thumbUrl = JsonHelper.getThumbUrl(map);
 
diff --git a/library/src/main/java/candybar/lib/adapters/IconsAdapter.java b/library/src/main/java/candybar/lib/adapters/IconsAdapter.java
@@ -118,7 +118,7 @@ public boolean onPrepareActionMode(ActionMode mode, Menu menu) {
             mode.setTitle(mContext.getResources().getString(R.string.items_selected, mSelectedIcons.size()));
             menu.findItem(R.id.menu_select_all).setIcon(mSelectedIcons.size() == mIcons.size()
                     ? R.drawable.ic_toolbar_select_all_selected : R.drawable.ic_toolbar_select_all);
-            menu.findItem(R.id.menu_delete).setVisible(mSelectedIcons.size() > 0);
+            menu.findItem(R.id.menu_delete).setVisible(!mSelectedIcons.isEmpty());
             return true;
         }
 
@@ -382,7 +382,7 @@ public void search(String string) {
         String query = string.toLowerCase(Locale.ENGLISH).trim();
 
         mIcons = new ArrayList<>();
-        if (query.length() == 0) mIcons.addAll(mIconsAll);
+        if (query.isEmpty()) mIcons.addAll(mIconsAll);
         else {
             for (int i = 0; i < mIconsAll.size(); i++) {
                 Icon icon = mIconsAll.get(i);
@@ -394,7 +394,7 @@ public void search(String string) {
             }
         }
 
-        if (mIcons.size() == 0) {
+        if (mIcons.isEmpty()) {
             CandyBarApplication.getConfiguration().getAnalyticsHandler().logEvent(
                     "click",
                     new HashMap<String, Object>() {{
diff --git a/library/src/main/java/candybar/lib/adapters/SettingsAdapter.java b/library/src/main/java/candybar/lib/adapters/SettingsAdapter.java
@@ -102,21 +102,21 @@ public void onBindViewHolder(RecyclerView.ViewHolder holder, int position) {
             ContentViewHolder contentViewHolder = (ContentViewHolder) holder;
             Setting setting = mSettings.get(position);
 
-            if (setting.getTitle().length() == 0) {
+            if (setting.getTitle().isEmpty()) {
                 contentViewHolder.title.setVisibility(View.GONE);
                 contentViewHolder.divider.setVisibility(View.GONE);
                 contentViewHolder.container.setVisibility(View.VISIBLE);
 
                 contentViewHolder.subtitle.setText(setting.getSubtitle());
 
-                if (setting.getContent().length() == 0) {
+                if (setting.getContent().isEmpty()) {
                     contentViewHolder.content.setVisibility(View.GONE);
                 } else {
                     contentViewHolder.content.setText(setting.getContent());
                     contentViewHolder.content.setVisibility(View.VISIBLE);
                 }
 
-                if (setting.getFooter().length() == 0) {
+                if (setting.getFooter().isEmpty()) {
                     contentViewHolder.footer.setVisibility(View.GONE);
                 } else {
                     contentViewHolder.footer.setText(setting.getFooter());
diff --git a/library/src/main/java/candybar/lib/adapters/WallpapersAdapter.java b/library/src/main/java/candybar/lib/adapters/WallpapersAdapter.java
@@ -127,7 +127,7 @@ public boolean onResourceReady(Bitmap resource, Object model, Target<Bitmap> tar
     public void search(String string) {
         String query = string.toLowerCase(Locale.getDefault()).trim();
         mWallpapers.clear();
-        if (query.length() == 0) mWallpapers.addAll(mWallpapersAll);
+        if (query.isEmpty()) mWallpapers.addAll(mWallpapersAll);
         else {
             for (int i = 0; i < mWallpapersAll.size(); i++) {
                 Wallpaper wallpaper = mWallpapersAll.get(i);
diff --git a/library/src/main/java/candybar/lib/adapters/dialog/OtherAppsAdapter.java b/library/src/main/java/candybar/lib/adapters/dialog/OtherAppsAdapter.java
@@ -101,7 +101,7 @@ public View getView(int position, View view, ViewGroup viewGroup) {
 
         holder.title.setText(otherApp.getTitle());
 
-        if (otherApp.getDescription() == null || otherApp.getDescription().length() == 0) {
+        if (otherApp.getDescription() == null || otherApp.getDescription().isEmpty()) {
             holder.desc.setVisibility(View.GONE);
         } else {
             holder.desc.setText(otherApp.getDescription());
diff --git a/library/src/main/java/candybar/lib/applications/CandyBarApplication.java b/library/src/main/java/candybar/lib/applications/CandyBarApplication.java
@@ -303,7 +303,7 @@ public Configuration setShowTabAllIcons(boolean showTabAllIcons) {
 
         public Configuration setTabAllIconsTitle(@NonNull String title) {
             mTabAllIconsTitle = title;
-            if (mTabAllIconsTitle.length() == 0) mTabAllIconsTitle = "All Icons";
+            if (mTabAllIconsTitle.isEmpty()) mTabAllIconsTitle = "All Icons";
             return this;
         }
 
diff --git a/library/src/main/java/candybar/lib/fragments/RequestFragment.java b/library/src/main/java/candybar/lib/fragments/RequestFragment.java
@@ -276,7 +276,7 @@ public void onClick(View view) {
                 }
 
                 if ((requireActivity().getResources().getBoolean(R.bool.json_check_before_request)) &&
-                        (CandyBarApplication.getConfiguration().getConfigHandler().configJson(requireActivity()).length() != 0)) {
+                        (!CandyBarApplication.getConfiguration().getConfigHandler().configJson(requireActivity()).isEmpty())) {
                     mAsyncTask = new CheckConfig().executeOnThreadPool();
                 } else {
                     mAsyncTask = new RequestLoader().executeOnThreadPool();
@@ -479,7 +479,7 @@ protected boolean run() {
 
                         List<ResolveInfo> resolveInfos = requireActivity().getPackageManager()
                                 .queryIntentActivities(intent, 0);
-                        if (resolveInfos.size() == 0) {
+                        if (resolveInfos.isEmpty()) {
                             noEmailClientError = true;
                             return false;
                         }
diff --git a/library/src/main/java/candybar/lib/fragments/SettingsFragment.java b/library/src/main/java/candybar/lib/fragments/SettingsFragment.java
@@ -263,7 +263,7 @@ protected boolean run() {
                     Thread.sleep(1);
                     File directory = requireActivity().getCacheDir();
                     requests = Database.get(requireActivity()).getPremiumRequest(null);
-                    if (requests.size() == 0) return true;
+                    if (requests.isEmpty()) return true;
 
                     List<String> files = new ArrayList<>();
 
@@ -335,7 +335,7 @@ protected void postRun(boolean ok) {
             dialog = null;
 
             if (ok) {
-                if (requests.size() == 0) {
+                if (requests.isEmpty()) {
                     Toast.makeText(getActivity(), R.string.premium_request_rebuilding_empty,
                             Toast.LENGTH_LONG).show();
                     return;
diff --git a/library/src/main/java/candybar/lib/helpers/IconsHelper.java b/library/src/main/java/candybar/lib/helpers/IconsHelper.java
@@ -96,7 +96,7 @@ public static List<Icon> getIconsList(@NonNull Context context) throws Exception
                 if (parser.getName().equals("category")) {
                     String title = parser.getAttributeValue(null, "title");
                     if (!sectionTitle.equals(title)) {
-                        if (sectionTitle.length() > 0 && icons.size() > 0) {
+                        if (!sectionTitle.isEmpty() && !icons.isEmpty()) {
                             count += icons.size();
                             sections.add(new Icon(sectionTitle, icons));
                         }
@@ -121,7 +121,7 @@ public static List<Icon> getIconsList(@NonNull Context context) throws Exception
                 CandyBarApplication.getConfiguration().getCustomIconsCount() == 0) {
             CandyBarApplication.getConfiguration().setCustomIconsCount(count);
         }
-        if (icons.size() > 0) {
+        if (!icons.isEmpty()) {
             sections.add(new Icon(sectionTitle, icons));
         }
         parser.close();
@@ -158,7 +158,7 @@ public static void computeTitles(@NonNull Context context, List<Icon> icons) {
                 // Title is already computed, so continue
                 continue;
             }
-            if (icon.getCustomName() != null && !icon.getCustomName().equals("")) {
+            if (icon.getCustomName() != null && !icon.getCustomName().isEmpty()) {
                 icon.setTitle(icon.getCustomName());
             } else {
                 icon.setTitle(replaceName(context, iconReplacer, icon.getDrawableName()));
diff --git a/library/src/main/java/candybar/lib/helpers/ReportBugsHelper.java b/library/src/main/java/candybar/lib/helpers/ReportBugsHelper.java
@@ -154,7 +154,7 @@ public static File buildBrokenDrawables(@NonNull Context context) {
                 }
 
                 String drawable = drawables.get(icon.getDrawableName());
-                if ((drawable == null || drawable.length() == 0) && !addedIcons.contains(icon.getDrawableName())) {
+                if ((drawable == null || drawable.isEmpty()) && !addedIcons.contains(icon.getDrawableName())) {
                     addedIcons.add(icon.getDrawableName());
                     writer.append("Drawable: ").append(icon.getDrawableName()).append(".png")
                             .append("\r\n\r\n");
@@ -216,7 +216,7 @@ public static File buildActivityList(@NonNull Context context) {
     @Nullable
     public static File buildCrashLog(@NonNull Context context, @NonNull String stackTrace) {
         try {
-            if (stackTrace.length() == 0) return null;
+            if (stackTrace.isEmpty()) return null;
 
             File crashLog = new File(context.getCacheDir(), CRASHLOG);
             String deviceInfo = DeviceHelper.getDeviceInfoForCrashReport(context);
diff --git a/library/src/main/java/candybar/lib/helpers/RequestHelper.java b/library/src/main/java/candybar/lib/helpers/RequestHelper.java
@@ -184,28 +184,28 @@ public static String getRegularPacificApiKey(Context context) {
     }
 
     public static boolean isRegularPacificEnabled(Context context) {
-        return context.getResources().getString(R.string.regular_request_method).length() > 0
+        return !context.getResources().getString(R.string.regular_request_method).isEmpty()
                 ? context.getResources().getString(R.string.regular_request_method).contentEquals("pacific")
                 // Use fallback method to check if pacific is enabled
-                : getRegularPacificApiKey(context).length() > 0;
+                : !getRegularPacificApiKey(context).isEmpty();
     }
 
     public static String getPremiumPacificApiKey(Context context) {
         String pacificApiKey = context.getResources().getString(R.string.premium_request_pacific_api_key);
         // Fallback to regular request's api key
-        if (pacificApiKey.length() == 0) pacificApiKey = getRegularPacificApiKey(context);
+        if (pacificApiKey.isEmpty()) pacificApiKey = getRegularPacificApiKey(context);
 
         return pacificApiKey;
     }
 
     public static boolean isPremiumPacificEnabled(Context context) {
-        return context.getResources().getString(R.string.premium_request_method).length() > 0
+        return !context.getResources().getString(R.string.premium_request_method).isEmpty()
                 ? context.getResources().getString(R.string.premium_request_method).contentEquals("pacific")
                 // Fallback to regular request's method
-                : context.getResources().getString(R.string.regular_request_method).length() > 0
+                : !context.getResources().getString(R.string.regular_request_method).isEmpty()
                 ? context.getResources().getString(R.string.regular_request_method).contentEquals("pacific")
                 // Use fallback method to check if pacific is enabled
-                : getRegularPacificApiKey(context).length() > 0;
+                : !getRegularPacificApiKey(context).isEmpty();
     }
 
     public static String sendPacificRequest(List<Request> requests, List<String> iconFiles, File directory, String apiKey) {
@@ -255,16 +255,16 @@ public static String sendPacificRequest(List<Request> requests, List<String> ico
     }
 
     public static boolean isRegularCustomEnabled(Context context) {
-        return context.getResources().getString(R.string.regular_request_method).length() > 0
+        return !context.getResources().getString(R.string.regular_request_method).isEmpty()
                 && context.getResources().getString(R.string.regular_request_method).contentEquals("custom");
     }
 
     public static boolean isPremiumCustomEnabled(Context context) {
-        return (context.getResources().getString(R.string.premium_request_method).length() > 0
+        return (!context.getResources().getString(R.string.premium_request_method).isEmpty()
                 && context.getResources().getString(R.string.premium_request_method).contentEquals("custom"))
                 ||
                 // Fallback to regular request's method
-                (context.getResources().getString(R.string.regular_request_method).length() > 0
+                (!context.getResources().getString(R.string.regular_request_method).isEmpty()
                 && context.getResources().getString(R.string.regular_request_method).contentEquals("custom"));
     }
 
diff --git a/library/src/main/java/candybar/lib/tasks/IconRequestTask.java b/library/src/main/java/candybar/lib/tasks/IconRequestTask.java
@@ -66,7 +66,7 @@ protected boolean run() {
                         mContext.get().getResources().getBoolean(R.bool.enable_premium_request)) {
                     List<Request> requests = new ArrayList<>();
                     HashMap<String, String> appFilter = RequestHelper.getAppFilter(mContext.get(), RequestHelper.Key.ACTIVITY);
-                    if (appFilter.size() == 0) {
+                    if (appFilter.isEmpty()) {
                         mError = Extras.Error.APPFILTER_NULL;
                         return false;
                     }
@@ -77,7 +77,7 @@ protected boolean run() {
                     intent.addCategory(Intent.CATEGORY_LAUNCHER);
                     List<ResolveInfo> installedApps = packageManager.queryIntentActivities(
                             intent, PackageManager.GET_RESOLVED_FILTER);
-                    if (installedApps.size() == 0) {
+                    if (installedApps.isEmpty()) {
                         mError = Extras.Error.INSTALLED_APPS_NULL;
                         return false;
                     }
diff --git a/library/src/main/java/candybar/lib/tasks/PremiumRequestBuilderTask.java b/library/src/main/java/candybar/lib/tasks/PremiumRequestBuilderTask.java
@@ -165,13 +165,13 @@ private void addIntentExtra(@NonNull Intent intent, String emailBody) {
         }
 
         String subject = mContext.get().getResources().getString(R.string.premium_request_email_subject);
-        if (subject.length() == 0)
+        if (subject.isEmpty())
             subject = mContext.get().getResources().getString(R.string.app_name) + " Premium Icon Request";
         subject = "Rebuilt: " + subject;
 
         String emailAddress = mContext.get().getResources().getString(R.string.premium_request_email);
         // Fallback to regular request email
-        if (emailAddress.length() == 0)
+        if (emailAddress.isEmpty())
             emailAddress = mContext.get().getResources().getString(R.string.regular_request_email);
 
         intent.putExtra(Intent.EXTRA_EMAIL, new String[]{emailAddress});
diff --git a/library/src/main/java/candybar/lib/tasks/WallpaperThumbPreloaderTask.java b/library/src/main/java/candybar/lib/tasks/WallpaperThumbPreloaderTask.java
@@ -47,7 +47,7 @@ protected boolean run() {
                         return false;
                     }
 
-                    if (list.size() > 0 && list.get(0) instanceof Map) {
+                    if (!list.isEmpty() && list.get(0) instanceof Map) {
                         Map<?, ?> map = (Map<?, ?>) list.get(0);
                         String thumbUrl = JsonHelper.getThumbUrl(map);
 
diff --git a/library/src/main/java/candybar/lib/utils/InAppBillingClient.java b/library/src/main/java/candybar/lib/utils/InAppBillingClient.java
@@ -93,7 +93,7 @@ public void onPurchasesUpdated(@NonNull BillingResult billingResult, @Nullable L
         }
 
         if (billingResult.getResponseCode() == BillingClient.BillingResponseCode.OK) {
-            if (purchases != null && purchases.size() > 0) {
+            if (purchases != null && !purchases.isEmpty()) {
                 try {
                     ((InAppBillingListener) mInAppBilling.get().mContext)
                             .onProcessPurchase(purchases.get(0));
@@ -134,7 +134,7 @@ public void checkForUnprocessedPurchases() {
         mInAppBilling.get().getClient()
                 .queryPurchasesAsync(INAPP_PARAMS, (billingResult, purchases) -> {
                     if (billingResult.getResponseCode() == BillingClient.BillingResponseCode.OK) {
-                        if (purchases.size() > 0) {
+                        if (!purchases.isEmpty()) {
                             try {
                                 ((InAppBillingListener) mInAppBilling.get().mContext)
                                         .onProcessPurchase(purchases.get(0));

Original file line number	Diff line number	Diff line change
`@@ -865,7 +865,7 @@ private void initNavigationViewHeader() {`
`865`	`865`	`image.setRatio(16, 9);`
`866`	`866`	`}`
`867`	`867`
`868`		`- if (titleText.length() == 0) {`
	`868`	`+ if (titleText.isEmpty()) {`
`869`	`869`	`container.setVisibility(View.GONE);`
`870`	`870`	`} else {`
`871`	`871`	`title.setText(titleText);`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ protected boolean run() {`
`153`	`153`	`return false;`
`154`	`154`	`}`
`155`	`155`
`156`		`- if (list.size() > 0 && list.get(0) instanceof Map) {`
	`156`	`+ if (!list.isEmpty() && list.get(0) instanceof Map) {`
`157`	`157`	`Map<?, ?> map = (Map<?, ?>) list.get(0);`
`158`	`158`	`String thumbUrl = JsonHelper.getThumbUrl(map);`
`159`	`159`
Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ public Configuration setShowTabAllIcons(boolean showTabAllIcons) {`
`303`	`303`
`304`	`304`	`public Configuration setTabAllIconsTitle(@NonNull String title) {`
`305`	`305`	`mTabAllIconsTitle = title;`
`306`		`- if (mTabAllIconsTitle.length() == 0) mTabAllIconsTitle = "All Icons";`
	`306`	`+ if (mTabAllIconsTitle.isEmpty()) mTabAllIconsTitle = "All Icons";`
`307`	`307`	`return this;`
`308`	`308`	`}`
`309`	`309`