Skip to content

Commit 4ba7199

Browse files
i#4103 clang-tidy: Fix clang-tidy warnings (DynamoRIO#7397)
Fixes 3 clang-tidy warnings: + Removes default parameter value on virtual function schedule_stats_t::create_histogram() + Fixes inconsistent parameter name in is_annotation_tag() + Adds missing annotations_api.h header Issue: DynamoRIO#4103, DynamoRIO#7355
1 parent a0d576c commit 4ba7199

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

clients/drcachesim/tools/schedule_stats.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,7 @@ class schedule_stats_t : public analysis_tool_t {
343343
};
344344

345345
virtual std::unique_ptr<histogram_interface_t>
346-
create_histogram(uint64_t bin_size = 1)
346+
create_histogram(uint64_t bin_size)
347347
{
348348
return std::unique_ptr<histogram_interface_t>(new histogram_t(bin_size));
349349
}

core/annotations.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@
4040

4141
#ifdef ANNOTATIONS /* around whole file */
4242

43+
# include "annotations_api.h"
44+
4345
# if !(defined(WINDOWS) && defined(X64))
4446
# include "valgrind.h"
4547
# include "memcheck.h"
@@ -227,7 +229,7 @@ valgrind_running_on_valgrind(dr_vg_client_request_t *request);
227229
# endif
228230

229231
static bool
230-
is_annotation_tag(dcontext_t *dcontext, DR_PARAM_INOUT app_pc *start_pc, instr_t *scratch,
232+
is_annotation_tag(dcontext_t *dcontext, DR_PARAM_INOUT app_pc *cur_pc, instr_t *scratch,
231233
DR_PARAM_OUT const char **name);
232234

233235
static void

0 commit comments

Comments
 (0)