Skip to content

Commit 3dc0c96

Browse files
JakobDevJakobDev
authored
Delete repos of org when purge delete user (go-gitea#27273)
Fixes https://codeberg.org/forgejo/forgejo/issues/1514 I had to remove `RenameOrganization` to avoid circular import. We should really add some foreign keys to the database.
1 parent 398eccb commit 3dc0c96

File tree

8 files changed

+67
-41
lines changed

8 files changed

+67
-41
lines changed

‎routers/api/v1/org/org.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ func Delete(ctx *context.APIContext) {
385385
// "404":
386386
// "$ref": "#/responses/notFound"
387387

388-
if err := org.DeleteOrganization(ctx, ctx.Org.Organization); err != nil {
388+
if err := org.DeleteOrganization(ctx, ctx.Org.Organization, false); err != nil {
389389
ctx.Error(http.StatusInternalServerError, "DeleteOrganization", err)
390390
return
391391
}

‎routers/web/org/setting.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func SettingsPost(ctx *context.Context) {
7575

7676
// Check if organization name has been changed.
7777
if nameChanged {
78-
err := org_service.RenameOrganization(ctx, org, form.Name)
78+
err := user_service.RenameUser(ctx, org.AsUser(), form.Name)
7979
switch {
8080
case user_model.IsErrUserAlreadyExist(err):
8181
ctx.Data["OrgName"] = true
@@ -180,7 +180,7 @@ func SettingsDelete(ctx *context.Context) {
180180
return
181181
}
182182

183-
if err := org_service.DeleteOrganization(ctx, ctx.Org.Organization); err != nil {
183+
if err := org_service.DeleteOrganization(ctx, ctx.Org.Organization, false); err != nil {
184184
if models.IsErrUserOwnRepos(err) {
185185
ctx.Flash.Error(ctx.Tr("form.org_still_own_repo"))
186186
ctx.Redirect(ctx.Org.OrgLink + "/settings/delete")

‎services/org/org.go‎

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,24 @@ import (
1515
user_model "code.gitea.io/gitea/models/user"
1616
"code.gitea.io/gitea/modules/storage"
1717
"code.gitea.io/gitea/modules/util"
18-
user_service "code.gitea.io/gitea/services/user"
18+
repo_service "code.gitea.io/gitea/services/repository"
1919
)
2020

2121
// DeleteOrganization completely and permanently deletes everything of organization.
22-
func DeleteOrganization(ctx context.Context, org *org_model.Organization) error {
22+
func DeleteOrganization(ctx context.Context, org *org_model.Organization, purge bool) error {
2323
ctx, commiter, err := db.TxContext(ctx)
2424
if err != nil {
2525
return err
2626
}
2727
defer commiter.Close()
2828

29+
if purge {
30+
err := repo_service.DeleteOwnerRepositoriesDirectly(ctx, org.AsUser())
31+
if err != nil {
32+
return err
33+
}
34+
}
35+
2936
// Check ownership of repository.
3037
count, err := repo_model.CountRepositories(ctx, repo_model.CountRepositoryOptions{OwnerID: org.ID})
3138
if err != nil {
@@ -67,8 +74,3 @@ func DeleteOrganization(ctx context.Context, org *org_model.Organization) error
6774

6875
return nil
6976
}
70-
71-
// RenameOrganization renames an organization.
72-
func RenameOrganization(ctx context.Context, org *org_model.Organization, newName string) error {
73-
return user_service.RenameUser(ctx, org.AsUser(), newName)
74-
}

‎services/org/org_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,17 @@ func TestMain(m *testing.M) {
2222
func TestDeleteOrganization(t *testing.T) {
2323
assert.NoError(t, unittest.PrepareTestDatabase())
2424
org := unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: 6})
25-
assert.NoError(t, DeleteOrganization(db.DefaultContext, org))
25+
assert.NoError(t, DeleteOrganization(db.DefaultContext, org, false))
2626
unittest.AssertNotExistsBean(t, &organization.Organization{ID: 6})
2727
unittest.AssertNotExistsBean(t, &organization.OrgUser{OrgID: 6})
2828
unittest.AssertNotExistsBean(t, &organization.Team{OrgID: 6})
2929

3030
org = unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: 3})
31-
err := DeleteOrganization(db.DefaultContext, org)
31+
err := DeleteOrganization(db.DefaultContext, org, false)
3232
assert.Error(t, err)
3333
assert.True(t, models.IsErrUserOwnRepos(err))
3434

3535
user := unittest.AssertExistsAndLoadBean(t, &organization.Organization{ID: 5})
36-
assert.Error(t, DeleteOrganization(db.DefaultContext, user))
36+
assert.Error(t, DeleteOrganization(db.DefaultContext, user, false))
3737
unittest.CheckConsistencyFor(t, &user_model.User{}, &organization.Team{})
3838
}

‎services/repository/delete.go‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,3 +420,30 @@ func RemoveRepositoryFromTeam(ctx context.Context, t *organization.Team, repoID
420420

421421
return committer.Commit()
422422
}
423+
424+
// DeleteOwnerRepositoriesDirectly calls DeleteRepositoryDirectly for all repos of the given owner
425+
func DeleteOwnerRepositoriesDirectly(ctx context.Context, owner *user_model.User) error {
426+
for {
427+
repos, _, err := repo_model.GetUserRepositories(ctx, &repo_model.SearchRepoOptions{
428+
ListOptions: db.ListOptions{
429+
PageSize: repo_model.RepositoryListDefaultPageSize,
430+
Page: 1,
431+
},
432+
Private: true,
433+
OwnerID: owner.ID,
434+
Actor: owner,
435+
})
436+
if err != nil {
437+
return fmt.Errorf("GetUserRepositories: %w", err)
438+
}
439+
if len(repos) == 0 {
440+
break
441+
}
442+
for _, repo := range repos {
443+
if err := DeleteRepositoryDirectly(ctx, owner, repo.ID); err != nil {
444+
return fmt.Errorf("unable to delete repository %s for %s[%d]. Error: %w", repo.Name, owner.Name, owner.ID, err)
445+
}
446+
}
447+
}
448+
return nil
449+
}

‎services/repository/delete_test.go‎

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright 2017 The Gitea Authors. All rights reserved.
22
// SPDX-License-Identifier: MIT
33

4-
package repository
4+
package repository_test
55

66
import (
77
"testing"
@@ -10,6 +10,8 @@ import (
1010
"code.gitea.io/gitea/models/organization"
1111
repo_model "code.gitea.io/gitea/models/repo"
1212
"code.gitea.io/gitea/models/unittest"
13+
user_model "code.gitea.io/gitea/models/user"
14+
repo_service "code.gitea.io/gitea/services/repository"
1315

1416
"github.com/stretchr/testify/assert"
1517
)
@@ -19,7 +21,7 @@ func TestTeam_HasRepository(t *testing.T) {
1921

2022
test := func(teamID, repoID int64, expected bool) {
2123
team := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: teamID})
22-
assert.Equal(t, expected, HasRepository(db.DefaultContext, team, repoID))
24+
assert.Equal(t, expected, repo_service.HasRepository(db.DefaultContext, team, repoID))
2325
}
2426
test(1, 1, false)
2527
test(1, 3, true)
@@ -35,11 +37,19 @@ func TestTeam_RemoveRepository(t *testing.T) {
3537

3638
testSuccess := func(teamID, repoID int64) {
3739
team := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: teamID})
38-
assert.NoError(t, RemoveRepositoryFromTeam(db.DefaultContext, team, repoID))
40+
assert.NoError(t, repo_service.RemoveRepositoryFromTeam(db.DefaultContext, team, repoID))
3941
unittest.AssertNotExistsBean(t, &organization.TeamRepo{TeamID: teamID, RepoID: repoID})
4042
unittest.CheckConsistencyFor(t, &organization.Team{ID: teamID}, &repo_model.Repository{ID: repoID})
4143
}
4244
testSuccess(2, 3)
4345
testSuccess(2, 5)
4446
testSuccess(1, unittest.NonexistentID)
4547
}
48+
49+
func TestDeleteOwnerRepositoriesDirectly(t *testing.T) {
50+
unittest.PrepareTestEnv(t)
51+
52+
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
53+
54+
assert.NoError(t, repo_service.DeleteOwnerRepositoriesDirectly(db.DefaultContext, user))
55+
}

‎services/repository/lfs_test.go‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright 2023 The Gitea Authors. All rights reserved.
22
// SPDX-License-Identifier: MIT
33

4-
package repository
4+
package repository_test
55

66
import (
77
"bytes"
@@ -16,12 +16,13 @@ import (
1616
"code.gitea.io/gitea/modules/lfs"
1717
"code.gitea.io/gitea/modules/setting"
1818
"code.gitea.io/gitea/modules/storage"
19+
repo_service "code.gitea.io/gitea/services/repository"
1920

2021
"github.com/stretchr/testify/assert"
2122
)
2223

2324
func TestGarbageCollectLFSMetaObjects(t *testing.T) {
24-
assert.NoError(t, unittest.PrepareTestDatabase())
25+
unittest.PrepareTestEnv(t)
2526

2627
setting.LFS.StartServer = true
2728
err := storage.Init()
@@ -35,7 +36,7 @@ func TestGarbageCollectLFSMetaObjects(t *testing.T) {
3536
lfsOid := storeObjectInRepo(t, repo.ID, &lfsContent)
3637

3738
// gc
38-
err = GarbageCollectLFSMetaObjects(context.Background(), GarbageCollectLFSMetaObjectsOptions{
39+
err = repo_service.GarbageCollectLFSMetaObjects(context.Background(), repo_service.GarbageCollectLFSMetaObjectsOptions{
3940
AutoFix: true,
4041
OlderThan: time.Now().Add(7 * 24 * time.Hour).Add(5 * 24 * time.Hour),
4142
UpdatedLessRecentlyThan: time.Now().Add(7 * 24 * time.Hour).Add(3 * 24 * time.Hour),

‎services/user/user.go‎

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"code.gitea.io/gitea/modules/storage"
2525
"code.gitea.io/gitea/modules/util"
2626
"code.gitea.io/gitea/services/agit"
27+
org_service "code.gitea.io/gitea/services/org"
2728
"code.gitea.io/gitea/services/packages"
2829
container_service "code.gitea.io/gitea/services/packages/container"
2930
repo_service "code.gitea.io/gitea/services/repository"
@@ -158,27 +159,9 @@ func DeleteUser(ctx context.Context, u *user_model.User, purge bool) error {
158159
//
159160
// An alternative option here would be write a DeleteAllRepositoriesForUserID function which would delete all of the repos
160161
// but such a function would likely get out of date
161-
for {
162-
repos, _, err := repo_model.GetUserRepositories(ctx, &repo_model.SearchRepoOptions{
163-
ListOptions: db.ListOptions{
164-
PageSize: repo_model.RepositoryListDefaultPageSize,
165-
Page: 1,
166-
},
167-
Private: true,
168-
OwnerID: u.ID,
169-
Actor: u,
170-
})
171-
if err != nil {
172-
return fmt.Errorf("GetUserRepositories: %w", err)
173-
}
174-
if len(repos) == 0 {
175-
break
176-
}
177-
for _, repo := range repos {
178-
if err := repo_service.DeleteRepositoryDirectly(ctx, u, repo.ID); err != nil {
179-
return fmt.Errorf("unable to delete repository %s for %s[%d]. Error: %w", repo.Name, u.Name, u.ID, err)
180-
}
181-
}
162+
err := repo_service.DeleteOwnerRepositoriesDirectly(ctx, u)
163+
if err != nil {
164+
return err
182165
}
183166

184167
// Remove from Organizations and delete last owner organizations
@@ -206,7 +189,10 @@ func DeleteUser(ctx context.Context, u *user_model.User, purge bool) error {
206189
for _, org := range orgs {
207190
if err := models.RemoveOrgUser(ctx, org.ID, u.ID); err != nil {
208191
if organization.IsErrLastOrgOwner(err) {
209-
err = organization.DeleteOrganization(ctx, org)
192+
err = org_service.DeleteOrganization(ctx, org, true)
193+
if err != nil {
194+
return fmt.Errorf("unable to delete organization %d: %w", org.ID, err)
195+
}
210196
}
211197
if err != nil {
212198
return fmt.Errorf("unable to remove user %s[%d] from org %s[%d]. Error: %w", u.Name, u.ID, org.Name, org.ID, err)

0 commit comments

Comments
 (0)