Skip to content

Commit 93a2def

Browse files
lunnylunny
authored
Move and rename UpdateRepository (go-gitea#34136)
1 parent 5015992 commit 93a2def

File tree

7 files changed

+145
-156
lines changed

7 files changed

+145
-156
lines changed

‎modules/repository/create.go‎

Lines changed: 0 additions & 102 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,9 @@ import (
88
"fmt"
99
"os"
1010
"path/filepath"
11-
"strings"
1211

13-
activities_model "code.gitea.io/gitea/models/activities"
14-
"code.gitea.io/gitea/models/db"
1512
git_model "code.gitea.io/gitea/models/git"
16-
access_model "code.gitea.io/gitea/models/perm/access"
1713
repo_model "code.gitea.io/gitea/models/repo"
18-
issue_indexer "code.gitea.io/gitea/modules/indexer/issues"
19-
"code.gitea.io/gitea/modules/log"
20-
api "code.gitea.io/gitea/modules/structs"
21-
"code.gitea.io/gitea/modules/util"
2214
)
2315

2416
const notRegularFileMode = os.ModeSymlink | os.ModeNamedPipe | os.ModeSocket | os.ModeDevice | os.ModeCharDevice | os.ModeIrregular
@@ -63,97 +55,3 @@ func UpdateRepoSize(ctx context.Context, repo *repo_model.Repository) error {
6355

6456
return repo_model.UpdateRepoSize(ctx, repo.ID, size, lfsSize)
6557
}
66-
67-
// CheckDaemonExportOK creates/removes git-daemon-export-ok for git-daemon...
68-
func CheckDaemonExportOK(ctx context.Context, repo *repo_model.Repository) error {
69-
if err := repo.LoadOwner(ctx); err != nil {
70-
return err
71-
}
72-
73-
// Create/Remove git-daemon-export-ok for git-daemon...
74-
daemonExportFile := filepath.Join(repo.RepoPath(), `git-daemon-export-ok`)
75-
76-
isExist, err := util.IsExist(daemonExportFile)
77-
if err != nil {
78-
log.Error("Unable to check if %s exists. Error: %v", daemonExportFile, err)
79-
return err
80-
}
81-
82-
isPublic := !repo.IsPrivate && repo.Owner.Visibility == api.VisibleTypePublic
83-
if !isPublic && isExist {
84-
if err = util.Remove(daemonExportFile); err != nil {
85-
log.Error("Failed to remove %s: %v", daemonExportFile, err)
86-
}
87-
} else if isPublic && !isExist {
88-
if f, err := os.Create(daemonExportFile); err != nil {
89-
log.Error("Failed to create %s: %v", daemonExportFile, err)
90-
} else {
91-
f.Close()
92-
}
93-
}
94-
95-
return nil
96-
}
97-
98-
// UpdateRepository updates a repository with db context
99-
func UpdateRepository(ctx context.Context, repo *repo_model.Repository, visibilityChanged bool) (err error) {
100-
repo.LowerName = strings.ToLower(repo.Name)
101-
102-
e := db.GetEngine(ctx)
103-
104-
if _, err = e.ID(repo.ID).AllCols().Update(repo); err != nil {
105-
return fmt.Errorf("update: %w", err)
106-
}
107-
108-
if err = UpdateRepoSize(ctx, repo); err != nil {
109-
log.Error("Failed to update size for repository: %v", err)
110-
}
111-
112-
if visibilityChanged {
113-
if err = repo.LoadOwner(ctx); err != nil {
114-
return fmt.Errorf("LoadOwner: %w", err)
115-
}
116-
if repo.Owner.IsOrganization() {
117-
// Organization repository need to recalculate access table when visibility is changed.
118-
if err = access_model.RecalculateTeamAccesses(ctx, repo, 0); err != nil {
119-
return fmt.Errorf("recalculateTeamAccesses: %w", err)
120-
}
121-
}
122-
123-
// If repo has become private, we need to set its actions to private.
124-
if repo.IsPrivate {
125-
_, err = e.Where("repo_id = ?", repo.ID).Cols("is_private").Update(&activities_model.Action{
126-
IsPrivate: true,
127-
})
128-
if err != nil {
129-
return err
130-
}
131-
132-
if err = repo_model.ClearRepoStars(ctx, repo.ID); err != nil {
133-
return err
134-
}
135-
}
136-
137-
// Create/Remove git-daemon-export-ok for git-daemon...
138-
if err := CheckDaemonExportOK(ctx, repo); err != nil {
139-
return err
140-
}
141-
142-
forkRepos, err := repo_model.GetRepositoriesByForkID(ctx, repo.ID)
143-
if err != nil {
144-
return fmt.Errorf("getRepositoriesByForkID: %w", err)
145-
}
146-
for i := range forkRepos {
147-
forkRepos[i].IsPrivate = repo.IsPrivate || repo.Owner.Visibility == api.VisibleTypePrivate
148-
if err = UpdateRepository(ctx, forkRepos[i], true); err != nil {
149-
return fmt.Errorf("updateRepository[%d]: %w", forkRepos[i].ID, err)
150-
}
151-
}
152-
153-
// If visibility is changed, we need to update the issue indexer.
154-
// Since the data in the issue indexer have field to indicate if the repo is public or not.
155-
issue_indexer.UpdateRepoIndexer(ctx, repo.ID)
156-
}
157-
158-
return nil
159-
}

‎modules/repository/create_test.go‎

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,34 +6,13 @@ package repository
66
import (
77
"testing"
88

9-
activities_model "code.gitea.io/gitea/models/activities"
109
"code.gitea.io/gitea/models/db"
1110
repo_model "code.gitea.io/gitea/models/repo"
1211
"code.gitea.io/gitea/models/unittest"
1312

1413
"github.com/stretchr/testify/assert"
1514
)
1615

17-
func TestUpdateRepositoryVisibilityChanged(t *testing.T) {
18-
assert.NoError(t, unittest.PrepareTestDatabase())
19-
20-
// Get sample repo and change visibility
21-
repo, err := repo_model.GetRepositoryByID(db.DefaultContext, 9)
22-
assert.NoError(t, err)
23-
repo.IsPrivate = true
24-
25-
// Update it
26-
err = UpdateRepository(db.DefaultContext, repo, true)
27-
assert.NoError(t, err)
28-
29-
// Check visibility of action has become private
30-
act := activities_model.Action{}
31-
_, err = db.GetEngine(db.DefaultContext).ID(3).Get(&act)
32-
33-
assert.NoError(t, err)
34-
assert.True(t, act.IsPrivate)
35-
}
36-
3716
func TestGetDirectorySize(t *testing.T) {
3817
assert.NoError(t, unittest.PrepareTestDatabase())
3918
repo, err := repo_model.GetRepositoryByID(db.DefaultContext, 1)

‎services/repository/adopt.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ func adoptRepository(ctx context.Context, repo *repo_model.Repository, defaultBr
196196
return fmt.Errorf("setDefaultBranch: %w", err)
197197
}
198198
}
199-
if err = repo_module.UpdateRepository(ctx, repo, false); err != nil {
199+
if err = updateRepository(ctx, repo, false); err != nil {
200200
return fmt.Errorf("updateRepository: %w", err)
201201
}
202202

‎services/repository/create.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ func cleanupRepository(doer *user_model.User, repoID int64) {
464464
}
465465

466466
func updateGitRepoAfterCreate(ctx context.Context, repo *repo_model.Repository) error {
467-
if err := repo_module.CheckDaemonExportOK(ctx, repo); err != nil {
467+
if err := checkDaemonExportOK(ctx, repo); err != nil {
468468
return fmt.Errorf("checkDaemonExportOK: %w", err)
469469
}
470470

‎services/repository/fork.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ func ConvertForkToNormalRepository(ctx context.Context, repo *repo_model.Reposit
227227
repo.IsFork = false
228228
repo.ForkID = 0
229229

230-
if err := repo_module.UpdateRepository(ctx, repo, false); err != nil {
230+
if err := updateRepository(ctx, repo, false); err != nil {
231231
log.Error("Unable to update repository %-v whilst converting from fork. Error: %v", repo, err)
232232
return err
233233
}

‎services/repository/repository.go‎

Lines changed: 121 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,27 @@ import (
77
"context"
88
"errors"
99
"fmt"
10+
"os"
11+
"path/filepath"
12+
"strings"
1013

14+
activities_model "code.gitea.io/gitea/models/activities"
1115
"code.gitea.io/gitea/models/db"
1216
"code.gitea.io/gitea/models/git"
1317
issues_model "code.gitea.io/gitea/models/issues"
1418
"code.gitea.io/gitea/models/organization"
19+
access_model "code.gitea.io/gitea/models/perm/access"
1520
repo_model "code.gitea.io/gitea/models/repo"
1621
"code.gitea.io/gitea/models/unit"
1722
user_model "code.gitea.io/gitea/models/user"
1823
"code.gitea.io/gitea/modules/graceful"
24+
issue_indexer "code.gitea.io/gitea/modules/indexer/issues"
1925
"code.gitea.io/gitea/modules/log"
2026
"code.gitea.io/gitea/modules/queue"
2127
repo_module "code.gitea.io/gitea/modules/repository"
2228
"code.gitea.io/gitea/modules/setting"
2329
"code.gitea.io/gitea/modules/structs"
30+
"code.gitea.io/gitea/modules/util"
2431
notify_service "code.gitea.io/gitea/services/notify"
2532
pull_service "code.gitea.io/gitea/services/pull"
2633
)
@@ -109,42 +116,32 @@ func Init(ctx context.Context) error {
109116

110117
// UpdateRepository updates a repository
111118
func UpdateRepository(ctx context.Context, repo *repo_model.Repository, visibilityChanged bool) (err error) {
112-
ctx, committer, err := db.TxContext(ctx)
113-
if err != nil {
114-
return err
115-
}
116-
defer committer.Close()
117-
118-
if err = repo_module.UpdateRepository(ctx, repo, visibilityChanged); err != nil {
119-
return fmt.Errorf("updateRepository: %w", err)
120-
}
121-
122-
return committer.Commit()
123-
}
124-
125-
func UpdateRepositoryVisibility(ctx context.Context, repo *repo_model.Repository, isPrivate bool) (err error) {
126-
ctx, committer, err := db.TxContext(ctx)
127-
if err != nil {
128-
return err
129-
}
130-
131-
defer committer.Close()
132-
133-
repo.IsPrivate = isPrivate
134-
135-
if err = repo_module.UpdateRepository(ctx, repo, true); err != nil {
136-
return fmt.Errorf("UpdateRepositoryVisibility: %w", err)
137-
}
138-
139-
return committer.Commit()
119+
return db.WithTx(ctx, func(ctx context.Context) error {
120+
if err = updateRepository(ctx, repo, visibilityChanged); err != nil {
121+
return fmt.Errorf("updateRepository: %w", err)
122+
}
123+
return nil
124+
})
140125
}
141126

142127
func MakeRepoPublic(ctx context.Context, repo *repo_model.Repository) (err error) {
143-
return UpdateRepositoryVisibility(ctx, repo, false)
128+
return db.WithTx(ctx, func(ctx context.Context) error {
129+
repo.IsPrivate = false
130+
if err = updateRepository(ctx, repo, true); err != nil {
131+
return fmt.Errorf("MakeRepoPublic: %w", err)
132+
}
133+
return nil
134+
})
144135
}
145136

146137
func MakeRepoPrivate(ctx context.Context, repo *repo_model.Repository) (err error) {
147-
return UpdateRepositoryVisibility(ctx, repo, true)
138+
return db.WithTx(ctx, func(ctx context.Context) error {
139+
repo.IsPrivate = true
140+
if err = updateRepository(ctx, repo, true); err != nil {
141+
return fmt.Errorf("MakeRepoPrivate: %w", err)
142+
}
143+
return nil
144+
})
148145
}
149146

150147
// LinkedRepository returns the linked repo if any
@@ -170,3 +167,97 @@ func LinkedRepository(ctx context.Context, a *repo_model.Attachment) (*repo_mode
170167
}
171168
return nil, -1, nil
172169
}
170+
171+
// checkDaemonExportOK creates/removes git-daemon-export-ok for git-daemon...
172+
func checkDaemonExportOK(ctx context.Context, repo *repo_model.Repository) error {
173+
if err := repo.LoadOwner(ctx); err != nil {
174+
return err
175+
}
176+
177+
// Create/Remove git-daemon-export-ok for git-daemon...
178+
daemonExportFile := filepath.Join(repo.RepoPath(), `git-daemon-export-ok`)
179+
180+
isExist, err := util.IsExist(daemonExportFile)
181+
if err != nil {
182+
log.Error("Unable to check if %s exists. Error: %v", daemonExportFile, err)
183+
return err
184+
}
185+
186+
isPublic := !repo.IsPrivate && repo.Owner.Visibility == structs.VisibleTypePublic
187+
if !isPublic && isExist {
188+
if err = util.Remove(daemonExportFile); err != nil {
189+
log.Error("Failed to remove %s: %v", daemonExportFile, err)
190+
}
191+
} else if isPublic && !isExist {
192+
if f, err := os.Create(daemonExportFile); err != nil {
193+
log.Error("Failed to create %s: %v", daemonExportFile, err)
194+
} else {
195+
f.Close()
196+
}
197+
}
198+
199+
return nil
200+
}
201+
202+
// updateRepository updates a repository with db context
203+
func updateRepository(ctx context.Context, repo *repo_model.Repository, visibilityChanged bool) (err error) {
204+
repo.LowerName = strings.ToLower(repo.Name)
205+
206+
e := db.GetEngine(ctx)
207+
208+
if _, err = e.ID(repo.ID).AllCols().Update(repo); err != nil {
209+
return fmt.Errorf("update: %w", err)
210+
}
211+
212+
if err = repo_module.UpdateRepoSize(ctx, repo); err != nil {
213+
log.Error("Failed to update size for repository: %v", err)
214+
}
215+
216+
if visibilityChanged {
217+
if err = repo.LoadOwner(ctx); err != nil {
218+
return fmt.Errorf("LoadOwner: %w", err)
219+
}
220+
if repo.Owner.IsOrganization() {
221+
// Organization repository need to recalculate access table when visibility is changed.
222+
if err = access_model.RecalculateTeamAccesses(ctx, repo, 0); err != nil {
223+
return fmt.Errorf("recalculateTeamAccesses: %w", err)
224+
}
225+
}
226+
227+
// If repo has become private, we need to set its actions to private.
228+
if repo.IsPrivate {
229+
_, err = e.Where("repo_id = ?", repo.ID).Cols("is_private").Update(&activities_model.Action{
230+
IsPrivate: true,
231+
})
232+
if err != nil {
233+
return err
234+
}
235+
236+
if err = repo_model.ClearRepoStars(ctx, repo.ID); err != nil {
237+
return err
238+
}
239+
}
240+
241+
// Create/Remove git-daemon-export-ok for git-daemon...
242+
if err := checkDaemonExportOK(ctx, repo); err != nil {
243+
return err
244+
}
245+
246+
forkRepos, err := repo_model.GetRepositoriesByForkID(ctx, repo.ID)
247+
if err != nil {
248+
return fmt.Errorf("getRepositoriesByForkID: %w", err)
249+
}
250+
for i := range forkRepos {
251+
forkRepos[i].IsPrivate = repo.IsPrivate || repo.Owner.Visibility == structs.VisibleTypePrivate
252+
if err = updateRepository(ctx, forkRepos[i], true); err != nil {
253+
return fmt.Errorf("updateRepository[%d]: %w", forkRepos[i].ID, err)
254+
}
255+
}
256+
257+
// If visibility is changed, we need to update the issue indexer.
258+
// Since the data in the issue indexer have field to indicate if the repo is public or not.
259+
issue_indexer.UpdateRepoIndexer(ctx, repo.ID)
260+
}
261+
262+
return nil
263+
}

‎services/repository/repository_test.go‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package repository
66
import (
77
"testing"
88

9+
activities_model "code.gitea.io/gitea/models/activities"
910
"code.gitea.io/gitea/models/db"
1011
repo_model "code.gitea.io/gitea/models/repo"
1112
"code.gitea.io/gitea/models/unit"
@@ -40,3 +41,23 @@ func TestLinkedRepository(t *testing.T) {
4041
})
4142
}
4243
}
44+
45+
func TestUpdateRepositoryVisibilityChanged(t *testing.T) {
46+
assert.NoError(t, unittest.PrepareTestDatabase())
47+
48+
// Get sample repo and change visibility
49+
repo, err := repo_model.GetRepositoryByID(db.DefaultContext, 9)
50+
assert.NoError(t, err)
51+
repo.IsPrivate = true
52+
53+
// Update it
54+
err = updateRepository(db.DefaultContext, repo, true)
55+
assert.NoError(t, err)
56+
57+
// Check visibility of action has become private
58+
act := activities_model.Action{}
59+
_, err = db.GetEngine(db.DefaultContext).ID(3).Get(&act)
60+
61+
assert.NoError(t, err)
62+
assert.True(t, act.IsPrivate)
63+
}

0 commit comments

Comments
 (0)