Skip to content

Commit a44608a

Browse files
committed
Merge remote-tracking branch 'upstream/main'
* upstream/main: [skip ci] Updated translations via Crowdin Update JS and PY dependencies (go-gitea#28120) Decrease issue font size in project template (go-gitea#28054) Require clear descriptions both for feature and breaking PRs prior to the merge (go-gitea#28112) add skip ci functionality (go-gitea#28075) Fix project counter in organization/individual profile (go-gitea#28068) Fix Show/hide filetree button on small displays (go-gitea#27881) Change default size of attachments and repo files (go-gitea#28100) Fix Matrix and MSTeams nil dereference (go-gitea#28089)
2 parents a9be4ef + a3348bf commit a44608a

File tree

315 files changed

+774
-479
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

315 files changed

+774
-479
lines changed

.eslintrc.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ rules:
128128
"@stylistic/js/computed-property-spacing": [2, never]
129129
"@stylistic/js/dot-location": [2, property]
130130
"@stylistic/js/eol-last": [2]
131-
"@stylistic/js/func-call-spacing": [2, never]
131+
"@stylistic/js/function-call-spacing": [2, never]
132132
"@stylistic/js/function-call-argument-newline": [0]
133133
"@stylistic/js/function-paren-newline": [0]
134134
"@stylistic/js/generator-star-spacing": [0]

CONTRIBUTING.md

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -203,10 +203,20 @@ Some of the key points:
203203

204204
In the PR title, describe the problem you are fixing, not how you are fixing it. \
205205
Use the first comment as a summary of your PR. \
206-
In the PR summary, you can describe exactly how you are fixing this problem. \
206+
In the PR summary, you can describe exactly how you are fixing this problem.
207+
207208
Keep this summary up-to-date as the PR evolves. \
208209
If your PR changes the UI, you must add **after** screenshots in the PR summary. \
209-
If you are not implementing a new feature, you should also post **before** screenshots for comparison. \
210+
If you are not implementing a new feature, you should also post **before** screenshots for comparison.
211+
212+
If you are implementing a new feature, your PR will only be merged if your screenshots are up to date.\
213+
Furthermore, feature PRs will only be merged if their summary contains a clear usage description (understandable for users) and testing description (understandable for reviewers).
214+
You should strive to combine both into a single description.
215+
216+
Another requirement for merging PRs is that the PR is labeled correctly.\
217+
However, this is not your job as a contributor, but the job of the person merging your PR.\
218+
If you think that your PR was labeled incorrectly, or notice that it was merged without labels, please let us know.
219+
210220
If your PR closes some issues, you must note that in a way that both GitHub and Gitea understand, i.e. by appending a paragraph like
211221

212222
```text
@@ -255,13 +265,16 @@ Changing the default value of a setting or replacing the setting with another on
255265

256266
#### How to handle breaking PRs?
257267

258-
If your PR has a breaking change, you must add a `BREAKING` section to your PR summary, e.g.
268+
If your PR has a breaking change, you must add two things to the summary of your PR:
259269

260-
```
270+
1. A reasoning why this breaking change is necessary
271+
2. A `BREAKING` section explaining in simple terms (understandable for a typical user) how this PR affects users and how to mitigate these changes. This section can look for example like
272+
273+
```md
261274
## :warning: BREAKING :warning:
262275
```
263276

264-
To explain how this will affect users and how to mitigate these changes.
277+
Breaking PRs will not be merged as long as not both of these requirements are met.
265278

266279
### Maintaining open PRs
267280

custom/conf/app.example.ini

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1017,7 +1017,7 @@ LEVEL = Info
10171017
;ALLOWED_TYPES =
10181018
;;
10191019
;; Max size of each file in megabytes. Defaults to 50MB
1020-
;FILE_MAX_SIZE = 50
1020+
;FILE_MAX_SIZE = 50
10211021
;;
10221022
;; Max number of files per upload. Defaults to 5
10231023
;MAX_FILES = 5
@@ -2583,6 +2583,8 @@ LEVEL = Info
25832583
;ENDLESS_TASK_TIMEOUT = 3h
25842584
;; Timeout to cancel the jobs which have waiting status, but haven't been picked by a runner for a long time
25852585
;ABANDONED_JOB_TIMEOUT = 24h
2586+
;; Strings committers can place inside a commit message to skip executing the corresponding actions workflow
2587+
;SKIP_WORKFLOW_STRINGS = [skip ci],[ci skip],[no ci],[skip actions],[actions skip]
25862588

25872589
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
25882590
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

docs/content/administration/config-cheat-sheet.en-us.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1396,6 +1396,7 @@ PROXY_HOSTS = *.github.com
13961396
- `ZOMBIE_TASK_TIMEOUT`: **10m**: Timeout to stop the task which have running status, but haven't been updated for a long time
13971397
- `ENDLESS_TASK_TIMEOUT`: **3h**: Timeout to stop the tasks which have running status and continuous updates, but don't end for a long time
13981398
- `ABANDONED_JOB_TIMEOUT`: **24h**: Timeout to cancel the jobs which have waiting status, but haven't been picked by a runner for a long time
1399+
- `SKIP_WORKFLOW_STRINGS`: **[skip ci],[ci skip],[no ci],[skip actions],[actions skip]**: Strings committers can place inside a commit message to skip executing the corresponding actions workflow
13991400

14001401
`DEFAULT_ACTIONS_URL` indicates where the Gitea Actions runners should find the actions with relative path.
14011402
For example, `uses: actions/checkout@v3` means `https://github.com/actions/checkout@v3` since the value of `DEFAULT_ACTIONS_URL` is `github`.

modules/setting/actions.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,11 @@ var (
2222
ZombieTaskTimeout time.Duration `ini:"ZOMBIE_TASK_TIMEOUT"`
2323
EndlessTaskTimeout time.Duration `ini:"ENDLESS_TASK_TIMEOUT"`
2424
AbandonedJobTimeout time.Duration `ini:"ABANDONED_JOB_TIMEOUT"`
25+
SkipWorkflowStrings []string `ìni:"SKIP_WORKFLOW_STRINGS"`
2526
}{
26-
Enabled: true,
27-
DefaultActionsURL: defaultActionsURLGitHub,
27+
Enabled: true,
28+
DefaultActionsURL: defaultActionsURLGitHub,
29+
SkipWorkflowStrings: []string{"[skip ci]", "[ci skip]", "[no ci]", "[skip actions]", "[actions skip]"},
2830
}
2931
)
3032

modules/setting/attachment.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ var Attachment = struct {
1313
}{
1414
Storage: &Storage{},
1515
AllowedTypes: ".csv,.docx,.fodg,.fodp,.fods,.fodt,.gif,.gz,.jpeg,.jpg,.log,.md,.mov,.mp4,.odf,.odg,.odp,.ods,.odt,.patch,.pdf,.png,.pptx,.svg,.tgz,.txt,.webm,.xls,.xlsx,.zip",
16-
MaxSize: 4,
16+
MaxSize: 2048,
1717
MaxFiles: 5,
1818
Enabled: true,
1919
}

modules/setting/repository.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ var (
184184
Enabled: true,
185185
TempPath: "data/tmp/uploads",
186186
AllowedTypes: "",
187-
FileMaxSize: 3,
187+
FileMaxSize: 50,
188188
MaxFiles: 5,
189189
},
190190

options/locale/locale_fr-FR.ini

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,9 +1330,9 @@ projects.column.new_title=Nom
13301330
projects.column.new_submit=Créer une colonne
13311331
projects.column.new=Nouvelle colonne
13321332
projects.column.set_default=Définir par défaut
1333-
projects.column.set_default_desc=Missionne cette colonne d'accueillir les tickets et demande d'ajouts non catégorisés.
1333+
projects.column.set_default_desc=Les tickets et demandes d’ajout non-catégorisés seront placés dans cette colonne.
13341334
projects.column.unset_default=Défaire par défaut
1335-
projects.column.unset_default_desc=Décharge cette colonne d'accueillir les tickets et demandes d'ajouts non catégorisées. Ceux-ci iront dans une colonne idoine.
1335+
projects.column.unset_default_desc=Les tickets et demandes d'ajouts non-catégorisés seront placés dans une colonne idoine.
13361336
projects.column.delete=Supprimer la colonne
13371337
projects.column.deletion_desc=La suppression d'une colonne de projet déplace tous les tickets liés à 'Non catégorisé'. Continuer ?
13381338
projects.column.color=Couleur
@@ -3214,22 +3214,22 @@ notices.delete_success=Les informations systèmes ont été supprimées.
32143214
32153215
[action]
32163216
create_repo=a créé le dépôt <a href="%s">%s</a>
3217-
rename_repo=a rebaptisé le dépôt de <code>%[1]s</code> vers <a href="%[2]s">%[3]s</a>
3218-
commit_repo=a soumis sur <a href="%[2]s">%[3]s</a> à <a href="%[1]s">%[4]s</a>
3219-
create_issue=`ticket ouvert <a href="%[1]s">%[3]s#%[2]s</a>`
3220-
close_issue=`ticket fermé <a href="%[1]s">%[3]s#%[2]s</a>`
3217+
rename_repo=a rebaptisé le dépôt <s><code>%[1]s</code></s> en <a href="%[2]s">%[3]s</a>
3218+
commit_repo=a soumis sur <a href="%[2]s">%[3]s</a> dans <a href="%[1]s">%[4]s</a>
3219+
create_issue=`a ouvert le ticket <a href="%[1]s">%[3]s#%[2]s</a>`
3220+
close_issue=`a fermé le ticket <a href="%[1]s">%[3]s#%[2]s</a>`
32213221
reopen_issue=`a réouvert le ticket <a href="%[1]s">%[3]s#%[2]s</a>`
3222-
create_pull_request=`a créé la demande d'ajout <a href="%[1]s">%[3]s#%[2]s</a>`
3223-
close_pull_request=`a fermé la demande d'ajout <a href="%[1]s">%[3]s#%[2]s</a>`
3224-
reopen_pull_request=`a réouvert la demande d'ajout <a href="%[1]s">%[3]s#%[2]s</a>`
3222+
create_pull_request=`a créé la demande dajout <a href="%[1]s">%[3]s#%[2]s</a>`
3223+
close_pull_request=`a fermé la demande dajout <a href="%[1]s">%[3]s#%[2]s</a>`
3224+
reopen_pull_request=`a réouvert la demande dajout <a href="%[1]s">%[3]s#%[2]s</a>`
32253225
comment_issue=`a commenté le ticket <a href="%[1]s">%[3]s#%[2]s</a>`
3226-
comment_pull=`a commenté la demande d'ajout <a href="%[1]s">%[3]s#%[2]s</a>`
3227-
merge_pull_request=`a fusionné la demande d'ajout <a href="%[1]s">%[3]s#%[2]s</a>`
3228-
auto_merge_pull_request=`a fusionné automatiquement la demande d’ajout <a href="%[1]s">%[3]s#%[2]s</a>.`
3229-
transfer_repo=a transféré le dépôt <code>%s</code> à <a href="%s">%s</a>
3230-
push_tag=a poussé l'étiquette <a href="%[2]s">%[3]s</a> vers <a href="%[1]s">%[4]s</a>
3231-
delete_tag=étiquette supprimée %[2]s de <a href="%[1]s">%[3]s</a>
3232-
delete_branch=branche %[2]s supprimée de <a href="%[1]s">%[3]s</a>
3226+
comment_pull=`a commenté la demande dajout <a href="%[1]s">%[3]s#%[2]s</a>`
3227+
merge_pull_request=`a fusionné la demande dajout <a href="%[1]s">%[3]s#%[2]s</a>`
3228+
auto_merge_pull_request=`a fusionné automatiquement la demande d’ajout <a href="%[1]s">%[3]s#%[2]s</a>`
3229+
transfer_repo=a transféré le dépôt <code>%s</code> vers <a href="%s">%s</a>
3230+
push_tag=a poussé létiquette <a href="%[2]s">%[3]s</a> vers <a href="%[1]s">%[4]s</a>
3231+
delete_tag=a supprimé l’étiquette %[2]s de <a href="%[1]s">%[3]s</a>
3232+
delete_branch=a supprimée la branche %[2]s de <a href="%[1]s">%[3]s</a>
32333233
compare_branch=Comparer
32343234
compare_commits=Comparer %d révisions
32353235
compare_commits_general=Comparer les révisions
@@ -3242,8 +3242,8 @@ publish_release=`a publié <a href="%[2]s"> "%[4]s" </a> à <a href="%[1]s">%[3]
32423242
review_dismissed=`a révoqué l’évaluation de <b>%[4]s</b> sur <a href="%[1]s">%[3]s#%[2]s</a>.`
32433243
review_dismissed_reason=Raison :
32443244
create_branch=a créé la branche <a href="%[2]s">%[3]s</a> dans <a href="%[1]s">%[4]s</a>.
3245-
starred_repo=est fan de <a href="%[1]s">%[2]s</a>.
3246-
watched_repo=observe <a href="%[1]s">%[2]s</a>.
3245+
starred_repo=aime <a href="%[1]s">%[2]s</a>
3246+
watched_repo=observe <a href="%[1]s">%[2]s</a>
32473247
32483248
[tool]
32493249
now=maintenant

0 commit comments

Comments
 (0)