@@ -1196,16 +1196,17 @@ func registerRoutes(m *web.Router) {
11961196 })
11971197 })
11981198 }
1199+ // FIXME: many "pulls" requests are sent to "issues" endpoints correctly, so the issue endpoints have to tolerate pull request permissions at the moment
1200+ m .Group ("/{username}/{reponame}/{type:issues}" , addIssuesPullsViewRoutes , optSignIn , context .RepoAssignment , context .RequireUnitReader (unit .TypeIssues , unit .TypePullRequests ))
1201+ m .Group ("/{username}/{reponame}/{type:pulls}" , addIssuesPullsViewRoutes , optSignIn , context .RepoAssignment , reqUnitPullsReader )
1202+
11991203 m .Group ("/{username}/{reponame}" , func () {
12001204 m .Get ("/comments/{id}/attachments" , repo .GetCommentAttachments )
12011205 m .Get ("/labels" , repo .RetrieveLabelsForList , repo .Labels )
12021206 m .Get ("/milestones" , repo .Milestones )
12031207 m .Get ("/milestone/{id}" , context .RepoRef (), repo .MilestoneIssuesAndPulls )
12041208 m .Get ("/issues/suggestions" , repo .IssueSuggestions )
12051209 }, optSignIn , context .RepoAssignment , reqRepoIssuesOrPullsReader ) // issue/pull attachments, labels, milestones
1206-
1207- m .Group ("/{username}/{reponame}/{type:issues}" , addIssuesPullsViewRoutes , optSignIn , context .RepoAssignment , reqUnitIssuesReader )
1208- m .Group ("/{username}/{reponame}/{type:pulls}" , addIssuesPullsViewRoutes , optSignIn , context .RepoAssignment , reqUnitPullsReader )
12091210 // end "/{username}/{reponame}": view milestone, label, issue, pull, etc
12101211
12111212 m .Group ("/{username}/{reponame}/{type:issues}" , func () {
@@ -1224,7 +1225,7 @@ func registerRoutes(m *web.Router) {
12241225 m .Get ("/search" , repo .SearchRepoIssuesJSON )
12251226 }, reqUnitIssuesReader )
12261227
1227- addIssuesPullsRoutes := func () {
1228+ addIssuesPullsUpdateRoutes := func () {
12281229 // for "/{username}/{reponame}/issues" or "/{username}/{reponame}/pulls"
12291230 m .Group ("/{index}" , func () {
12301231 m .Post ("/title" , repo .UpdateIssueTitle )
@@ -1267,8 +1268,9 @@ func registerRoutes(m *web.Router) {
12671268 m .Delete ("/unpin/{index}" , reqRepoAdmin , repo .IssueUnpin )
12681269 m .Post ("/move_pin" , reqRepoAdmin , repo .IssuePinMove )
12691270 }
1270- m .Group ("/{type:issues}" , addIssuesPullsRoutes , reqUnitIssuesReader , context .RepoMustNotBeArchived ())
1271- m .Group ("/{type:pulls}" , addIssuesPullsRoutes , reqUnitPullsReader , context .RepoMustNotBeArchived ())
1271+ // FIXME: many "pulls" requests are sent to "issues" endpoints incorrectly, so the issue endpoints have to tolerate pull request permissions at the moment
1272+ m .Group ("/{type:issues}" , addIssuesPullsUpdateRoutes , context .RequireUnitReader (unit .TypeIssues , unit .TypePullRequests ), context .RepoMustNotBeArchived ())
1273+ m .Group ("/{type:pulls}" , addIssuesPullsUpdateRoutes , reqUnitPullsReader , context .RepoMustNotBeArchived ())
12721274
12731275 m .Group ("/comments/{id}" , func () {
12741276 m .Post ("" , repo .UpdateCommentContent )
@@ -1292,7 +1294,7 @@ func registerRoutes(m *web.Router) {
12921294 m .Post ("/delete" , repo .DeleteMilestone )
12931295 }, reqRepoIssuesOrPullsWriter , context .RepoRef ())
12941296
1295- // FIXME: need to move these routes to the proper place
1297+ // FIXME: many "pulls" requests are sent to "issues" endpoints incorrectly, need to move these routes to the proper place
12961298 m .Group ("/issues" , func () {
12971299 m .Post ("/request_review" , repo .UpdatePullReviewRequest )
12981300 m .Post ("/dismiss_review" , reqRepoAdmin , web .Bind (forms.DismissReviewForm {}), repo .DismissReview )
0 commit comments