Skip to content

Commit c102492

Browse files
wxiaoguangwxiaoguang
authored
Fix LFS URL (go-gitea#33840)
Fix go-gitea#33839
1 parent 34e5df6 commit c102492

File tree

11 files changed

+131
-21
lines changed

11 files changed

+131
-21
lines changed

‎modules/httplib/request.go‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"bytes"
99
"context"
1010
"crypto/tls"
11+
"errors"
1112
"fmt"
1213
"io"
1314
"net"
@@ -101,6 +102,9 @@ func (r *Request) Param(key, value string) *Request {
101102

102103
// Body adds request raw body. It supports string, []byte and io.Reader as body.
103104
func (r *Request) Body(data any) *Request {
105+
if r == nil {
106+
return nil
107+
}
104108
switch t := data.(type) {
105109
case nil: // do nothing
106110
case string:
@@ -193,6 +197,9 @@ func (r *Request) getResponse() (*http.Response, error) {
193197
// Response executes request client gets response manually.
194198
// Caller MUST close the response body if no error occurs
195199
func (r *Request) Response() (*http.Response, error) {
200+
if r == nil {
201+
return nil, errors.New("invalid request")
202+
}
196203
return r.getResponse()
197204
}
198205

‎modules/lfstransfer/backend/backend.go‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,13 @@ func (g *GiteaBackend) Batch(_ string, pointers []transfer.BatchItem, args trans
7070
g.logger.Log("json marshal error", err)
7171
return nil, err
7272
}
73-
url := g.server.JoinPath("objects/batch").String()
7473
headers := map[string]string{
7574
headerAuthorization: g.authToken,
7675
headerGiteaInternalAuth: g.internalAuth,
7776
headerAccept: mimeGitLFS,
7877
headerContentType: mimeGitLFS,
7978
}
80-
req := newInternalRequestLFS(g.ctx, url, http.MethodPost, headers, bodyBytes)
79+
req := newInternalRequestLFS(g.ctx, g.server.JoinPath("objects/batch").String(), http.MethodPost, headers, bodyBytes)
8180
resp, err := req.Response()
8281
if err != nil {
8382
g.logger.Log("http request error", err)
@@ -179,13 +178,12 @@ func (g *GiteaBackend) Download(oid string, args transfer.Args) (io.ReadCloser,
179178
g.logger.Log("argument id incorrect")
180179
return nil, 0, transfer.ErrCorruptData
181180
}
182-
url := action.Href
183181
headers := map[string]string{
184182
headerAuthorization: g.authToken,
185183
headerGiteaInternalAuth: g.internalAuth,
186184
headerAccept: mimeOctetStream,
187185
}
188-
req := newInternalRequestLFS(g.ctx, url, http.MethodGet, headers, nil)
186+
req := newInternalRequestLFS(g.ctx, toInternalLFSURL(action.Href), http.MethodGet, headers, nil)
189187
resp, err := req.Response()
190188
if err != nil {
191189
return nil, 0, fmt.Errorf("failed to get response: %w", err)
@@ -225,15 +223,14 @@ func (g *GiteaBackend) Upload(oid string, size int64, r io.Reader, args transfer
225223
g.logger.Log("argument id incorrect")
226224
return transfer.ErrCorruptData
227225
}
228-
url := action.Href
229226
headers := map[string]string{
230227
headerAuthorization: g.authToken,
231228
headerGiteaInternalAuth: g.internalAuth,
232229
headerContentType: mimeOctetStream,
233230
headerContentLength: strconv.FormatInt(size, 10),
234231
}
235232

236-
req := newInternalRequestLFS(g.ctx, url, http.MethodPut, headers, nil)
233+
req := newInternalRequestLFS(g.ctx, toInternalLFSURL(action.Href), http.MethodPut, headers, nil)
237234
req.Body(r)
238235
resp, err := req.Response()
239236
if err != nil {
@@ -274,14 +271,13 @@ func (g *GiteaBackend) Verify(oid string, size int64, args transfer.Args) (trans
274271
// the server sent no verify action
275272
return transfer.SuccessStatus(), nil
276273
}
277-
url := action.Href
278274
headers := map[string]string{
279275
headerAuthorization: g.authToken,
280276
headerGiteaInternalAuth: g.internalAuth,
281277
headerAccept: mimeGitLFS,
282278
headerContentType: mimeGitLFS,
283279
}
284-
req := newInternalRequestLFS(g.ctx, url, http.MethodPost, headers, bodyBytes)
280+
req := newInternalRequestLFS(g.ctx, toInternalLFSURL(action.Href), http.MethodPost, headers, bodyBytes)
285281
resp, err := req.Response()
286282
if err != nil {
287283
return transfer.NewStatus(transfer.StatusInternalServerError), err

‎modules/lfstransfer/backend/lock.go‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,13 @@ func (g *giteaLockBackend) Create(path, refname string) (transfer.Lock, error) {
4343
g.logger.Log("json marshal error", err)
4444
return nil, err
4545
}
46-
url := g.server.String()
4746
headers := map[string]string{
4847
headerAuthorization: g.authToken,
4948
headerGiteaInternalAuth: g.internalAuth,
5049
headerAccept: mimeGitLFS,
5150
headerContentType: mimeGitLFS,
5251
}
53-
req := newInternalRequestLFS(g.ctx, url, http.MethodPost, headers, bodyBytes)
52+
req := newInternalRequestLFS(g.ctx, g.server.String(), http.MethodPost, headers, bodyBytes)
5453
resp, err := req.Response()
5554
if err != nil {
5655
g.logger.Log("http request error", err)
@@ -95,14 +94,13 @@ func (g *giteaLockBackend) Unlock(lock transfer.Lock) error {
9594
g.logger.Log("json marshal error", err)
9695
return err
9796
}
98-
url := g.server.JoinPath(lock.ID(), "unlock").String()
9997
headers := map[string]string{
10098
headerAuthorization: g.authToken,
10199
headerGiteaInternalAuth: g.internalAuth,
102100
headerAccept: mimeGitLFS,
103101
headerContentType: mimeGitLFS,
104102
}
105-
req := newInternalRequestLFS(g.ctx, url, http.MethodPost, headers, bodyBytes)
103+
req := newInternalRequestLFS(g.ctx, g.server.JoinPath(lock.ID(), "unlock").String(), http.MethodPost, headers, bodyBytes)
106104
resp, err := req.Response()
107105
if err != nil {
108106
g.logger.Log("http request error", err)
@@ -176,16 +174,15 @@ func (g *giteaLockBackend) Range(cursor string, limit int, iter func(transfer.Lo
176174
}
177175

178176
func (g *giteaLockBackend) queryLocks(v url.Values) ([]transfer.Lock, string, error) {
179-
urlq := g.server.JoinPath() // get a copy
180-
urlq.RawQuery = v.Encode()
181-
url := urlq.String()
177+
serverURLWithQuery := g.server.JoinPath() // get a copy
178+
serverURLWithQuery.RawQuery = v.Encode()
182179
headers := map[string]string{
183180
headerAuthorization: g.authToken,
184181
headerGiteaInternalAuth: g.internalAuth,
185182
headerAccept: mimeGitLFS,
186183
headerContentType: mimeGitLFS,
187184
}
188-
req := newInternalRequestLFS(g.ctx, url, http.MethodGet, headers, nil)
185+
req := newInternalRequestLFS(g.ctx, serverURLWithQuery.String(), http.MethodGet, headers, nil)
189186
resp, err := req.Response()
190187
if err != nil {
191188
g.logger.Log("http request error", err)

‎modules/lfstransfer/backend/util.go‎

Lines changed: 48 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,13 @@ import (
88
"fmt"
99
"io"
1010
"net/http"
11+
"net/url"
12+
"strings"
1113

1214
"code.gitea.io/gitea/modules/httplib"
1315
"code.gitea.io/gitea/modules/private"
16+
"code.gitea.io/gitea/modules/setting"
17+
"code.gitea.io/gitea/modules/util"
1418

1519
"github.com/charmbracelet/git-lfs-transfer/transfer"
1620
)
@@ -57,8 +61,7 @@ const (
5761

5862
// Operations enum
5963
const (
60-
opNone = iota
61-
opDownload
64+
opDownload = iota + 1
6265
opUpload
6366
)
6467

@@ -86,8 +89,49 @@ func statusCodeToErr(code int) error {
8689
}
8790
}
8891

89-
func newInternalRequestLFS(ctx context.Context, url, method string, headers map[string]string, body any) *httplib.Request {
90-
req := private.NewInternalRequest(ctx, url, method)
92+
func toInternalLFSURL(s string) string {
93+
pos1 := strings.Index(s, "://")
94+
if pos1 == -1 {
95+
return ""
96+
}
97+
appSubURLWithSlash := setting.AppSubURL + "/"
98+
pos2 := strings.Index(s[pos1+3:], appSubURLWithSlash)
99+
if pos2 == -1 {
100+
return ""
101+
}
102+
routePath := s[pos1+3+pos2+len(appSubURLWithSlash):]
103+
fields := strings.SplitN(routePath, "/", 3)
104+
if len(fields) < 3 || !strings.HasPrefix(fields[2], "info/lfs") {
105+
return ""
106+
}
107+
return setting.LocalURL + "api/internal/repo/" + routePath
108+
}
109+
110+
func isInternalLFSURL(s string) bool {
111+
if !strings.HasPrefix(s, setting.LocalURL) {
112+
return false
113+
}
114+
u, err := url.Parse(s)
115+
if err != nil {
116+
return false
117+
}
118+
routePath := util.PathJoinRelX(u.Path)
119+
subRoutePath, cut := strings.CutPrefix(routePath, "api/internal/repo/")
120+
if !cut {
121+
return false
122+
}
123+
fields := strings.SplitN(subRoutePath, "/", 3)
124+
if len(fields) < 3 || !strings.HasPrefix(fields[2], "info/lfs") {
125+
return false
126+
}
127+
return true
128+
}
129+
130+
func newInternalRequestLFS(ctx context.Context, internalURL, method string, headers map[string]string, body any) *httplib.Request {
131+
if !isInternalLFSURL(internalURL) {
132+
return nil
133+
}
134+
req := private.NewInternalRequest(ctx, internalURL, method)
91135
for k, v := range headers {
92136
req.Header(k, v)
93137
}

‎modules/lfstransfer/backend/util_test.go‎

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
// Copyright 2025 The Gitea Authors. All rights reserved.
2+
// SPDX-License-Identifier: MIT
3+
4+
package backend
5+
6+
import (
7+
"testing"
8+
9+
"code.gitea.io/gitea/modules/setting"
10+
"code.gitea.io/gitea/modules/test"
11+
12+
"github.com/stretchr/testify/assert"
13+
)
14+
15+
func TestToInternalLFSURL(t *testing.T) {
16+
defer test.MockVariableValue(&setting.LocalURL, "http://localurl/")()
17+
defer test.MockVariableValue(&setting.AppSubURL, "/sub")()
18+
cases := []struct {
19+
url string
20+
expected string
21+
}{
22+
{"http://appurl/any", ""},
23+
{"http://appurl/sub/any", ""},
24+
{"http://appurl/sub/owner/repo/any", ""},
25+
{"http://appurl/sub/owner/repo/info/any", ""},
26+
{"http://appurl/sub/owner/repo/info/lfs/any", "http://localurl/api/internal/repo/owner/repo/info/lfs/any"},
27+
}
28+
for _, c := range cases {
29+
assert.Equal(t, c.expected, toInternalLFSURL(c.url), c.url)
30+
}
31+
}
32+
33+
func TestIsInternalLFSURL(t *testing.T) {
34+
defer test.MockVariableValue(&setting.LocalURL, "http://localurl/")()
35+
defer test.MockVariableValue(&setting.InternalToken, "mock-token")()
36+
cases := []struct {
37+
url string
38+
expected bool
39+
}{
40+
{"", false},
41+
{"http://otherurl/api/internal/repo/owner/repo/info/lfs/any", false},
42+
{"http://localurl/api/internal/repo/owner/repo/info/lfs/any", true},
43+
{"http://localurl/api/internal/repo/owner/repo/info", false},
44+
{"http://localurl/api/internal/misc/owner/repo/info/lfs/any", false},
45+
{"http://localurl/api/internal/owner/repo/info/lfs/any", false},
46+
{"http://localurl/api/internal/foo/bar", false},
47+
}
48+
for _, c := range cases {
49+
req := newInternalRequestLFS(t.Context(), c.url, "GET", nil, nil)
50+
assert.Equal(t, c.expected, req != nil, c.url)
51+
assert.Equal(t, c.expected, isInternalLFSURL(c.url), c.url)
52+
}
53+
}

‎modules/private/internal.go‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ func NewInternalRequest(ctx context.Context, url, method string) *httplib.Reques
4040
Ensure you are running in the correct environment or set the correct configuration file with -c.`, setting.CustomConf)
4141
}
4242

43+
if !strings.HasPrefix(url, setting.LocalURL) {
44+
log.Fatal("Invalid internal request URL: %q", url)
45+
}
46+
4347
req := httplib.NewRequest(url, method).
4448
SetContext(ctx).
4549
Header("X-Real-IP", getClientIP()).

‎tests/integration/git_lfs_ssh_test.go‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,14 @@ func TestGitLFSSSH(t *testing.T) {
5454
return strings.Contains(s, "POST /api/internal/repo/user2/repo1.git/info/lfs/objects/batch")
5555
})
5656
countUpload := slices.ContainsFunc(routerCalls, func(s string) bool {
57-
return strings.Contains(s, "PUT /user2/repo1.git/info/lfs/objects/")
57+
return strings.Contains(s, "PUT /api/internal/repo/user2/repo1.git/info/lfs/objects/")
58+
})
59+
nonAPIRequests := slices.ContainsFunc(routerCalls, func(s string) bool {
60+
fields := strings.Fields(s)
61+
return !strings.HasPrefix(fields[1], "/api/")
5862
})
5963
assert.NotZero(t, countBatch)
6064
assert.NotZero(t, countUpload)
65+
assert.Zero(t, nonAPIRequests)
6166
})
6267
}

‎tests/mssql.ini.tmpl‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ SIGNING_KEY = none
4545
SSH_DOMAIN = localhost
4646
HTTP_PORT = 3003
4747
ROOT_URL = http://localhost:3003/
48+
LOCAL_ROOT_URL = http://127.0.0.1:3003/
4849
DISABLE_SSH = false
4950
SSH_LISTEN_HOST = localhost
5051
SSH_PORT = 2201

‎tests/mysql.ini.tmpl‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ SIGNING_KEY = none
4747
SSH_DOMAIN = localhost
4848
HTTP_PORT = 3001
4949
ROOT_URL = http://localhost:3001/
50+
LOCAL_ROOT_URL = http://127.0.0.1:3001/
5051
DISABLE_SSH = false
5152
SSH_LISTEN_HOST = localhost
5253
SSH_PORT = 2201

‎tests/pgsql.ini.tmpl‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ SIGNING_KEY = none
4646
SSH_DOMAIN = localhost
4747
HTTP_PORT = 3002
4848
ROOT_URL = http://localhost:3002/
49+
LOCAL_ROOT_URL = http://127.0.0.1:3002/
4950
DISABLE_SSH = false
5051
SSH_LISTEN_HOST = localhost
5152
SSH_PORT = 2202

0 commit comments

Comments
 (0)