duplicate events

[tsilen]

Getting a znode with :watch => true seems to somehow cause all on_connecting/on_connected/etc events to be subscribed again causing them to fire multiple times.

[slyphon]

on_connecting, on_connected events are not related to :watch => true, so I'm not really sure how this would happen. Can you provide example code, or at least detailed steps needed to reproduce?

[tsilen]

It's strange indeed.

Was able to reproduce it with this example code:

require 'rubygems'
require 'zk-eventmachine'
require 'logger'

ZK.logger = Logger.new(STDOUT)
ZK.logger.level = Logger::INFO
STDOUT.sync = true

def handle_connecting_event(event=nil)
  @zkem.on_connecting(&method(:handle_connecting_event))
  ZK.logger.info "Connecting"
end

def handle_connected_event(event=nil)
  @zkem.on_connected(&method(:handle_connected_event))
  ZK.logger.info "Connected"
end

@zkem = ZK::ZKEventMachine::Client.new("localhost:2181")
@zkem.on_connecting(&method(:handle_connecting_event))
@zkem.on_connected(&method(:handle_connected_event))

EM.run do
  @zkem.connect do
    @zkem.stat('/test', :watch => true)
  end
end

Running that and then stopping and starting zookeeper gives
Connected
Connecting
Connecting
Connected
Connected

If I remove the stat() or set :watch => false, I get Connected -> Connecting -> Connected as expected
If I add another stat() then I get one more duplicate. Same thing with get(), etc.

Changing log level to debug reveals that there actually seem to be duplicate subscriptions that are then fired.

Any ideas?

[slyphon]

Urf, ok, i'll take a look. This definitely sounds like a bug, I'll work on it a bit and update you.

[slyphon]

Blah, ok, i just confirmed this, gonna have to dig around, there's nothing jumping out at me.