refactor(tests): cleanup, make classes final

zlodes · zlodes · commit 8cb9f2293d20 · 2025-04-05T00:54:29.000+04:00
diff --git a/tests/Collector/ByType/CounterCollectorTest.php b/tests/Collector/ByType/CounterCollectorTest.php
@@ -18,7 +18,7 @@
 use Zlodes\PrometheusClient\Storage\Contracts\CounterStorage;
 use Zlodes\PrometheusClient\Tests\Stubs\CounterStorageStub;
 
-class CounterCollectorTest extends TestCase
+final class CounterCollectorTest extends TestCase
 {
     use MockeryPHPUnitIntegration;
 
diff --git a/tests/Collector/ByType/GaugeCollectorTest.php b/tests/Collector/ByType/GaugeCollectorTest.php
@@ -15,7 +15,7 @@
 use Zlodes\PrometheusClient\Storage\Commands\UpdateGauge;
 use Zlodes\PrometheusClient\Storage\Contracts\GaugeStorage;
 
-class GaugeCollectorTest extends TestCase
+final class GaugeCollectorTest extends TestCase
 {
     use MockeryPHPUnitIntegration;
 
diff --git a/tests/Collector/ByType/HistogramCollectorTest.php b/tests/Collector/ByType/HistogramCollectorTest.php
@@ -14,9 +14,8 @@
 use Zlodes\PrometheusClient\Metric\Histogram;
 use Zlodes\PrometheusClient\Storage\Commands\UpdateHistogram;
 use Zlodes\PrometheusClient\Storage\Contracts\HistogramStorage;
-use Zlodes\PrometheusClient\Storage\DTO\MetricValue;
 
-class HistogramCollectorTest extends TestCase
+final class HistogramCollectorTest extends TestCase
 {
     use MockeryPHPUnitIntegration;
 
diff --git a/tests/Collector/ByType/SummaryCollectorTest.php b/tests/Collector/ByType/SummaryCollectorTest.php
@@ -8,7 +8,6 @@
 use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
-use Zlodes\PrometheusClient\Collector\ByType\HistogramCollector;
 use Zlodes\PrometheusClient\Collector\ByType\SummaryCollector;
 use PHPUnit\Framework\TestCase;
 use Zlodes\PrometheusClient\Exception\StorageWriteException;
@@ -17,7 +16,7 @@
 use Zlodes\PrometheusClient\Storage\Contracts\SummaryStorage;
 use Zlodes\PrometheusClient\Storage\DTO\MetricValue;
 
-class SummaryCollectorTest extends TestCase
+final class SummaryCollectorTest extends TestCase
 {
     use MockeryPHPUnitIntegration;
 
diff --git a/tests/Collector/CollectorFactoryTest.php b/tests/Collector/CollectorFactoryTest.php
@@ -20,7 +20,7 @@
 use Zlodes\PrometheusClient\Tests\Stubs\HistogramStorageStub;
 use Zlodes\PrometheusClient\Tests\Stubs\SummaryStorageStub;
 
-class CollectorFactoryTest extends TestCase
+final class CollectorFactoryTest extends TestCase
 {
     use MockeryPHPUnitIntegration;
 
diff --git a/tests/Collector/CollectorTest.php b/tests/Collector/CollectorTest.php
@@ -7,7 +7,7 @@
 use PHPUnit\Framework\TestCase;
 use Zlodes\PrometheusClient\Collector\Collector;
 
-class CollectorTest extends TestCase
+final class CollectorTest extends TestCase
 {
     public function testReturnClone(): void
     {
diff --git a/tests/Exporter/NullExporterTest.php b/tests/Exporter/NullExporterTest.php
@@ -7,7 +7,7 @@
 use Zlodes\PrometheusClient\Exporter\NullExporter;
 use PHPUnit\Framework\TestCase;
 
-class NullExporterTest extends TestCase
+final class NullExporterTest extends TestCase
 {
     public function testExport(): void
     {
diff --git a/tests/Fetcher/StoredMetricsFetcherTest.php b/tests/Fetcher/StoredMetricsFetcherTest.php
@@ -32,7 +32,7 @@
 /**
  * Kinda stupid test to check that the fetcher return metric as expected: with correct values and order
  */
-class StoredMetricsFetcherTest extends TestCase
+final class StoredMetricsFetcherTest extends TestCase
 {
     public function testFetch(): void
     {
diff --git a/tests/KeySerialization/JsonSerializerTest.php b/tests/KeySerialization/JsonSerializerTest.php
@@ -11,7 +11,7 @@
 use Zlodes\PrometheusClient\KeySerialization\JsonSerializer;
 use Zlodes\PrometheusClient\Storage\DTO\MetricNameWithLabels;
 
-class JsonSerializerTest extends TestCase
+final class JsonSerializerTest extends TestCase
 {
     #[DataProvider('serializeDataProvider')]
     public function testSerialization(string $name, array $labels, string $expectedKey): void
diff --git a/tests/Metric/HistogramTest.php b/tests/Metric/HistogramTest.php
@@ -9,7 +9,7 @@
 use PHPUnit\Framework\TestCase;
 use Zlodes\PrometheusClient\Metric\Histogram;
 
-class HistogramTest extends TestCase
+final class HistogramTest extends TestCase
 {
     public function testWithBuckets(): void
     {
diff --git a/tests/Metric/MetricTest.php b/tests/Metric/MetricTest.php
@@ -13,7 +13,7 @@
 use Zlodes\PrometheusClient\Metric\Metric;
 use Zlodes\PrometheusClient\Metric\Summary;
 
-class MetricTest extends TestCase
+final class MetricTest extends TestCase
 {
     #[DataProvider('wrongNamesDataProvider')]
     public function testWrongNames(string $name): void
diff --git a/tests/Metric/SummaryTest.php b/tests/Metric/SummaryTest.php
@@ -10,7 +10,7 @@
 use Zlodes\PrometheusClient\Metric\Summary;
 use PHPUnit\Framework\TestCase;
 
-class SummaryTest extends TestCase
+final class SummaryTest extends TestCase
 {
     public function testWithQuantiles(): void
     {
diff --git a/tests/Storage/DTO/MetricNameWithLabelsTest.php b/tests/Storage/DTO/MetricNameWithLabelsTest.php
@@ -9,7 +9,7 @@
 use Zlodes\PrometheusClient\Storage\DTO\MetricNameWithLabels;
 use PHPUnit\Framework\TestCase;
 
-class MetricNameWithLabelsTest extends TestCase
+final class MetricNameWithLabelsTest extends TestCase
 {
     #[DataProvider('wrongLabelsDataProvider')]
     public function testWrongLabels(array $labels): void
diff --git a/tests/Storage/InMemory/InMemoryCounterStorageTest.php b/tests/Storage/InMemory/InMemoryCounterStorageTest.php
@@ -17,7 +17,7 @@
 use Zlodes\PrometheusClient\Storage\InMemory\InMemoryCounterStorage;
 use Zlodes\PrometheusClient\Storage\Testing\CounterStorageTesting;
 
-class InMemoryCounterStorageTest extends TestCase
+final class InMemoryCounterStorageTest extends TestCase
 {
     use CounterStorageTesting;
 
diff --git a/tests/Storage/InMemory/InMemoryGaugeStorageTest.php b/tests/Storage/InMemory/InMemoryGaugeStorageTest.php
@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Storage\InMemory;
+namespace Zlodes\PrometheusClient\Tests\Storage\InMemory;
 
 use Mockery;
 use PHPUnit\Framework\TestCase;
@@ -11,17 +11,13 @@
 use Zlodes\PrometheusClient\Exception\StorageReadException;
 use Zlodes\PrometheusClient\Exception\StorageWriteException;
 use Zlodes\PrometheusClient\KeySerialization\Serializer;
-use Zlodes\PrometheusClient\Storage\Commands\IncrementCounter;
 use Zlodes\PrometheusClient\Storage\Commands\UpdateGauge;
-use Zlodes\PrometheusClient\Storage\Contracts\CounterStorage;
 use Zlodes\PrometheusClient\Storage\Contracts\GaugeStorage;
 use Zlodes\PrometheusClient\Storage\DTO\MetricNameWithLabels;
-use Zlodes\PrometheusClient\Storage\InMemory\InMemoryCounterStorage;
 use Zlodes\PrometheusClient\Storage\InMemory\InMemoryGaugeStorage;
-use Zlodes\PrometheusClient\Storage\Testing\CounterStorageTesting;
 use Zlodes\PrometheusClient\Storage\Testing\GaugeStorageTesting;
 
-class InMemoryGaugeStorageTest extends TestCase
+final class InMemoryGaugeStorageTest extends TestCase
 {
     use GaugeStorageTesting;
 
diff --git a/tests/Storage/InMemory/InMemoryHistogramStorageTest.php b/tests/Storage/InMemory/InMemoryHistogramStorageTest.php
@@ -17,7 +17,7 @@
 use Zlodes\PrometheusClient\Storage\InMemory\InMemoryHistogramStorage;
 use Zlodes\PrometheusClient\Storage\Testing\HistogramStorageTesting;
 
-class InMemoryHistogramStorageTest extends TestCase
+final class InMemoryHistogramStorageTest extends TestCase
 {
     use HistogramStorageTesting;
 
diff --git a/tests/Storage/InMemory/InMemorySummaryStorageTest.php b/tests/Storage/InMemory/InMemorySummaryStorageTest.php
@@ -17,7 +17,7 @@
 use PHPUnit\Framework\TestCase;
 use Zlodes\PrometheusClient\Storage\Testing\SummaryStorageTesting;
 
-class InMemorySummaryStorageTest extends TestCase
+final class InMemorySummaryStorageTest extends TestCase
 {
     use SummaryStorageTesting;
 
diff --git a/tests/Storage/InMemory/InMemorySummaryTest.php b/tests/Storage/InMemory/InMemorySummaryTest.php
@@ -2,12 +2,12 @@
 
 declare(strict_types=1);
 
-namespace Storage\InMemory;
+namespace Zlodes\PrometheusClient\Tests\Storage\InMemory;
 
 use PHPUnit\Framework\TestCase;
 use Zlodes\PrometheusClient\Storage\InMemory\InMemorySummary;
 
-class InMemorySummaryTest extends TestCase
+final class InMemorySummaryTest extends TestCase
 {
     public function testMaxValues(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`use Zlodes\PrometheusClient\Storage\Contracts\CounterStorage;`
`19`	`19`	`use Zlodes\PrometheusClient\Tests\Stubs\CounterStorageStub;`
`20`	`20`
`21`		`-class CounterCollectorTest extends TestCase`
	`21`	`+final class CounterCollectorTest extends TestCase`
`22`	`22`	`{`
`23`	`23`	`use MockeryPHPUnitIntegration;`
`24`	`24`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`use Zlodes\PrometheusClient\Storage\Commands\UpdateGauge;`
`16`	`16`	`use Zlodes\PrometheusClient\Storage\Contracts\GaugeStorage;`
`17`	`17`
`18`		`-class GaugeCollectorTest extends TestCase`
	`18`	`+final class GaugeCollectorTest extends TestCase`
`19`	`19`	`{`
`20`	`20`	`use MockeryPHPUnitIntegration;`
`21`	`21`
Original file line number	Diff line number	Diff line change
`@@ -14,9 +14,8 @@`
`14`	`14`	`use Zlodes\PrometheusClient\Metric\Histogram;`
`15`	`15`	`use Zlodes\PrometheusClient\Storage\Commands\UpdateHistogram;`
`16`	`16`	`use Zlodes\PrometheusClient\Storage\Contracts\HistogramStorage;`
`17`		`-use Zlodes\PrometheusClient\Storage\DTO\MetricValue;`
`18`	`17`
`19`		`-class HistogramCollectorTest extends TestCase`
	`18`	`+final class HistogramCollectorTest extends TestCase`
`20`	`19`	`{`
`21`	`20`	`use MockeryPHPUnitIntegration;`
`22`	`21`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`use Zlodes\PrometheusClient\Tests\Stubs\HistogramStorageStub;`
`21`	`21`	`use Zlodes\PrometheusClient\Tests\Stubs\SummaryStorageStub;`
`22`	`22`
`23`		`-class CollectorFactoryTest extends TestCase`
	`23`	`+final class CollectorFactoryTest extends TestCase`
`24`	`24`	`{`
`25`	`25`	`use MockeryPHPUnitIntegration;`
`26`	`26`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`use PHPUnit\Framework\TestCase;`
`8`	`8`	`use Zlodes\PrometheusClient\Collector\Collector;`
`9`	`9`
`10`		`-class CollectorTest extends TestCase`
	`10`	`+final class CollectorTest extends TestCase`
`11`	`11`	`{`
`12`	`12`	`public function testReturnClone(): void`
`13`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`use Zlodes\PrometheusClient\Exporter\NullExporter;`
`8`	`8`	`use PHPUnit\Framework\TestCase;`
`9`	`9`
`10`		`-class NullExporterTest extends TestCase`
	`10`	`+final class NullExporterTest extends TestCase`
`11`	`11`	`{`
`12`	`12`	`public function testExport(): void`
`13`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@`
`32`	`32`	`/**`
`33`	`33`	`* Kinda stupid test to check that the fetcher return metric as expected: with correct values and order`
`34`	`34`	`*/`
`35`		`-class StoredMetricsFetcherTest extends TestCase`
	`35`	`+final class StoredMetricsFetcherTest extends TestCase`
`36`	`36`	`{`
`37`	`37`	`public function testFetch(): void`
`38`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`use Zlodes\PrometheusClient\KeySerialization\JsonSerializer;`
`12`	`12`	`use Zlodes\PrometheusClient\Storage\DTO\MetricNameWithLabels;`
`13`	`13`
`14`		`-class JsonSerializerTest extends TestCase`
	`14`	`+final class JsonSerializerTest extends TestCase`
`15`	`15`	`{`
`16`	`16`	`#[DataProvider('serializeDataProvider')]`
`17`	`17`	`public function testSerialization(string $name, array $labels, string $expectedKey): void`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`use PHPUnit\Framework\TestCase;`
`10`	`10`	`use Zlodes\PrometheusClient\Metric\Histogram;`
`11`	`11`
`12`		`-class HistogramTest extends TestCase`
	`12`	`+final class HistogramTest extends TestCase`
`13`	`13`	`{`
`14`	`14`	`public function testWithBuckets(): void`
`15`	`15`	`{`