Skip to content

Add back SystemCertPool() to provide an OS-agnostic way to get the root certs #411

@phillip-stephens

Description

@phillip-stephens

Not sure if this is an issue, since it seems it was very clearly removed on purpose. However, I'm unsure of why it's a good idea to remove this functionality.

This ZGrab issue discusses how without a way to automatically find the root store, users have to specify it. IMO, this raises a hurdle to using ZGrab with TLS unnecessarily.

SystemCertPool() was removed in 0b16e8f The commit msg specifies that zmap/rootfetch should now be used.

Golang crypto/x509 SystemCertPool() Docs

@dadrian or @zakird, do you have more context on this? This seems like a really useful thing to have been removed from zcrypto, unless I'm missing some motivation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions