CLI does not open github link

[theharmy]

CLI does not open the github link.
Tried multiple restarts. (1 PC restart, multiple terminal restarts)
Tried with cmd, Powershell and Powershell in Admin mode.

Small things to note: Unsure of their relevance, but just wanna make sure.
Malewarebytes extension told me potential malicious activity on zmk.dev (don't know if it routes through that and Malewarebytes found that weird, but just wanna tell anything that can help.

Disabling Browser Extension and Closing Malewarebytes on PC didn't help.

When installing the CLI i also had some issues with python and pipx.
for python, had some path or starting issues, deinstalled it, reinstalled from windows store. -> worked.
Pipx needed additional path adding, afterwards worked fine.

I tried it might be due to Powershell apperantly not being up to date, and it told me at first that there seem some issues with winget, and then some issues with opening a url.
Although i solved that when installing Powershell seperately. no luck on the CLI tho.

i'll see what i can do to give more info

[joelspadin]

We'll need more information to help with this. What command did you run and which options did you pick? What did the tool output? (Please copy and paste the output directly instead of describing it, as that will make it much easier to figure out what the problem might be.)

[theharmy]

When i get to this point, nothing happens. browser doesn't open, no link etc.
The issue was the same when i did not have previously had another repo already

Although, during the building process I found out that "git commit" supposedly should automatically open a text editor for you to edit the commit file, which also did not happen.

therefore i might think it might be a system issue. not a zmk issue

[theharmy]

correction, by changed the default text editor output for the command, that worked now. Therefore remaining old issue.

[joelspadin]

By default, Git uses a command line text editor. When doing an interactive install, should be an option to change it to something else when installing it. Maybe we should change the instructions from

winget install git.git

to

winget install git.git -i

and show how to select a text editor.

For opening a page in your browser, please open PowerShell or Command Prompt and run python, then run the following code. It should open https://github.com in your browser.

import webbrowser
webbrowser.open("https://github.com")

If that does work, then we can change https://github.com/zmkfirmware/zmk-cli/blob/main/zmk/commands/init.py#L118 and https://github.com/zmkfirmware/zmk-cli/blob/main/zmk/commands/download.py#L19 to use webbrowser.open instead of typer.launch.

If it doesn't work, then something is definitely wrong with your system, and we should try to figure out what is wrong, and if it's possible for ZMK CLI to detect it.

[theharmy]

This opens github, as expected!

[joelspadin]

Fixed via #24 and #35