Skip to content

Commit 7cdef85

Browse files
markfieldsjason-ha
andauthored
[v2.50] Remove IFluidHandleInternal.bind (microsoft#24870)
Fixes microsoft#24557 ## Description `IFluidHandleInternal.bind` was deprecated in 2.40 (via microsoft#24553), see [release notes entry](https://github.com/microsoft/FluidFramework/releases/tag/client_v2.40.0#user-content-ifluidhandleinternalbind-has-been-deprecated-24553) for more details. --------- Co-authored-by: Jason Hartman <jasonha@microsoft.com>
1 parent 34d54e3 commit 7cdef85

File tree

35 files changed

+162
-146
lines changed

35 files changed

+162
-146
lines changed

experimental/dds/tree/src/migration-shim/shimHandle.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
* Licensed under the MIT License.
44
*/
55

6-
import { type IFluidHandleInternal } from '@fluidframework/core-interfaces/internal';
76
import { FluidHandleBase, toFluidHandleInternal } from '@fluidframework/runtime-utils/internal';
87

98
import { type IShim } from './types.js';
@@ -33,10 +32,4 @@ export class ShimHandle<TShim extends IShim> extends FluidHandleBase<TShim> {
3332
public async get(): Promise<TShim> {
3433
return this.shim;
3534
}
36-
/**
37-
* @deprecated No replacement provided. Arbitrary handles may not serve as a bind source.
38-
*/
39-
public bind(handle: IFluidHandleInternal): void {
40-
return toFluidHandleInternal(this.shim.currentTree.handle).bind(handle);
41-
}
4235
}

experimental/dds/tree/src/test/utilities/TestSerializer.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,6 @@ export class TestFluidHandle extends FluidHandleBase<unknown> {
3939
throw new Error('Method not implemented.');
4040
}
4141

42-
/**
43-
* @deprecated No replacement provided. Arbitrary handles may not serve as a bind source.
44-
*/
45-
public bind(handle: IFluidHandle): void {
46-
throw new Error('Method not implemented.');
47-
}
48-
4942
public attachGraph(): void {
5043
throw new Error('Method not implemented.');
5144
}

packages/common/core-interfaces/api-report/core-interfaces.legacy.alpha.api.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,8 +275,6 @@ export interface IFluidHandleEvents {
275275
export interface IFluidHandleInternal<out T = unknown> extends IFluidHandle<T>, IProvideFluidHandle {
276276
readonly absolutePath: string;
277277
attachGraph(): void;
278-
// @deprecated
279-
bind(handle: IFluidHandleInternal): void;
280278
}
281279

282280
// @alpha @legacy

packages/common/core-interfaces/package.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,14 @@
148148
}
149149
},
150150
"typeValidation": {
151-
"broken": {},
151+
"broken": {
152+
"Interface_IProvideFluidHandle": {
153+
"backCompat": false
154+
},
155+
"Interface_IFluidHandleInternal": {
156+
"backCompat": false
157+
}
158+
},
152159
"entrypoint": "legacy"
153160
}
154161
}

packages/common/core-interfaces/src/handles.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,6 @@ export interface IFluidHandleInternal<
9494
* Runs through the graph and attach the bounded handles.
9595
*/
9696
attachGraph(): void;
97-
98-
/**
99-
* Binds the given handle to this one or attach the given handle if this handle is attached.
100-
* A bound handle will also be attached once this handle is attached.
101-
*
102-
* @deprecated No replacement provided. Arbitrary handles may not serve as a bind source.
103-
*/
104-
bind(handle: IFluidHandleInternal): void;
10597
}
10698

10799
/**

packages/common/core-interfaces/src/test/types/validateCoreInterfacesPrevious.generated.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ declare type old_as_current_for_Interface_IFluidHandleInternal = requireAssignab
193193
* typeValidation.broken:
194194
* "Interface_IFluidHandleInternal": {"backCompat": false}
195195
*/
196+
// @ts-expect-error compatibility expected to be broken
196197
declare type current_as_old_for_Interface_IFluidHandleInternal = requireAssignableTo<TypeOnly<current.IFluidHandleInternal>, TypeOnly<old.IFluidHandleInternal>>
197198

198199
/*
@@ -292,6 +293,7 @@ declare type old_as_current_for_Interface_IProvideFluidHandle = requireAssignabl
292293
* typeValidation.broken:
293294
* "Interface_IProvideFluidHandle": {"backCompat": false}
294295
*/
296+
// @ts-expect-error compatibility expected to be broken
295297
declare type current_as_old_for_Interface_IProvideFluidHandle = requireAssignableTo<TypeOnly<current.IProvideFluidHandle>, TypeOnly<old.IProvideFluidHandle>>
296298

297299
/*

packages/dds/ordered-collection/package.json

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,23 @@
152152
"typescript": "~5.4.5"
153153
},
154154
"typeValidation": {
155-
"broken": {},
155+
"broken": {
156+
"Class_ConsensusOrderedCollection": {
157+
"backCompat": false
158+
},
159+
"Class_ConsensusQueueClass": {
160+
"backCompat": false
161+
},
162+
"ClassStatics_ConsensusOrderedCollection": {
163+
"backCompat": false
164+
},
165+
"ClassStatics_ConsensusQueueClass": {
166+
"backCompat": false
167+
},
168+
"TypeAlias_ConsensusQueue": {
169+
"backCompat": false
170+
}
171+
},
156172
"entrypoint": "legacy"
157173
}
158174
}

packages/dds/ordered-collection/src/test/types/validateOrderedCollectionPrevious.generated.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ declare type old_as_current_for_Class_ConsensusOrderedCollection = requireAssign
3131
* typeValidation.broken:
3232
* "Class_ConsensusOrderedCollection": {"backCompat": false}
3333
*/
34+
// @ts-expect-error compatibility expected to be broken
3435
declare type current_as_old_for_Class_ConsensusOrderedCollection = requireAssignableTo<TypeOnly<current.ConsensusOrderedCollection>, TypeOnly<old.ConsensusOrderedCollection>>
3536

3637
/*
@@ -49,6 +50,7 @@ declare type old_as_current_for_Class_ConsensusQueueClass = requireAssignableTo<
4950
* typeValidation.broken:
5051
* "Class_ConsensusQueueClass": {"backCompat": false}
5152
*/
53+
// @ts-expect-error compatibility expected to be broken
5254
declare type current_as_old_for_Class_ConsensusQueueClass = requireAssignableTo<TypeOnly<current.ConsensusQueueClass>, TypeOnly<old.ConsensusQueueClass>>
5355

5456
/*
@@ -58,6 +60,7 @@ declare type current_as_old_for_Class_ConsensusQueueClass = requireAssignableTo<
5860
* typeValidation.broken:
5961
* "ClassStatics_ConsensusOrderedCollection": {"backCompat": false}
6062
*/
63+
// @ts-expect-error compatibility expected to be broken
6164
declare type current_as_old_for_ClassStatics_ConsensusOrderedCollection = requireAssignableTo<TypeOnly<typeof current.ConsensusOrderedCollection>, TypeOnly<typeof old.ConsensusOrderedCollection>>
6265

6366
/*
@@ -67,6 +70,7 @@ declare type current_as_old_for_ClassStatics_ConsensusOrderedCollection = requir
6770
* typeValidation.broken:
6871
* "ClassStatics_ConsensusQueueClass": {"backCompat": false}
6972
*/
73+
// @ts-expect-error compatibility expected to be broken
7074
declare type current_as_old_for_ClassStatics_ConsensusQueueClass = requireAssignableTo<TypeOnly<typeof current.ConsensusQueueClass>, TypeOnly<typeof old.ConsensusQueueClass>>
7175

7276
/*
@@ -193,6 +197,7 @@ declare type old_as_current_for_TypeAlias_ConsensusQueue = requireAssignableTo<T
193197
* typeValidation.broken:
194198
* "TypeAlias_ConsensusQueue": {"backCompat": false}
195199
*/
200+
// @ts-expect-error compatibility expected to be broken
196201
declare type current_as_old_for_TypeAlias_ConsensusQueue = requireAssignableTo<TypeOnly<current.ConsensusQueue>, TypeOnly<old.ConsensusQueue>>
197202

198203
/*

packages/dds/register-collection/package.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,14 @@
149149
"typescript": "~5.4.5"
150150
},
151151
"typeValidation": {
152-
"broken": {},
152+
"broken": {
153+
"Class_ConsensusRegisterCollectionClass": {
154+
"backCompat": false
155+
},
156+
"ClassStatics_ConsensusRegisterCollectionClass": {
157+
"backCompat": false
158+
}
159+
},
153160
"entrypoint": "legacy"
154161
}
155162
}

packages/dds/register-collection/src/test/types/validateRegisterCollectionPrevious.generated.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ declare type old_as_current_for_Class_ConsensusRegisterCollectionClass = require
3131
* typeValidation.broken:
3232
* "Class_ConsensusRegisterCollectionClass": {"backCompat": false}
3333
*/
34+
// @ts-expect-error compatibility expected to be broken
3435
declare type current_as_old_for_Class_ConsensusRegisterCollectionClass = requireAssignableTo<TypeOnly<current.ConsensusRegisterCollectionClass<never>>, TypeOnly<old.ConsensusRegisterCollectionClass<never>>>
3536

3637
/*
@@ -58,6 +59,7 @@ declare type current_as_old_for_Class_ConsensusRegisterCollectionFactory = requi
5859
* typeValidation.broken:
5960
* "ClassStatics_ConsensusRegisterCollectionClass": {"backCompat": false}
6061
*/
62+
// @ts-expect-error compatibility expected to be broken
6163
declare type current_as_old_for_ClassStatics_ConsensusRegisterCollectionClass = requireAssignableTo<TypeOnly<typeof current.ConsensusRegisterCollectionClass>, TypeOnly<typeof old.ConsensusRegisterCollectionClass>>
6264

6365
/*

0 commit comments

Comments
 (0)