on_delete=models.DO_NOTHING -> on_delete=models.CASCADE

Author: znick

anytask/admission/migrations/0002_auto_20251026_2354.py

@@ -0,0 +1,20 @@
+# Generated by Django 2.0.13 on 2025-10-26 20:54
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('admission', '0001_initial'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='admissionregistrationprofile',
+            name='user',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL),
+        ),
+    ]

anytask/admission/models.py

@@ -172,7 +172,7 @@ def decline_user(self, activation_key):
 
 
 class AdmissionRegistrationProfile(models.Model):
-    user = models.ForeignKey(User, unique=False, null=False, blank=False, on_delete=models.DO_NOTHING)
+    user = models.ForeignKey(User, unique=False, null=False, blank=False, on_delete=models.CASCADE)
     activation_key = models.CharField(max_length=40, null=True, blank=True)
     old_activation_key = models.CharField(max_length=40, null=True, blank=True)
     is_updating = models.BooleanField(default=False)

anytask/anycontest/migrations/0004_auto_20251026_2354.py

@@ -0,0 +1,30 @@
+# Generated by Django 2.0.13 on 2025-10-26 20:54
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('anycontest', '0003_auto_20240226_2150'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='contestsubmission',
+            name='author',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='contestsubmission',
+            name='file',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='issues.File'),
+        ),
+        migrations.AlterField(
+            model_name='contestsubmission',
+            name='issue',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='issues.Issue'),
+        ),
+    ]

anytask/anycontest/models.py

@@ -25,9 +25,9 @@ class ContestSubmissionWaiting(Exception):
 
 
 class ContestSubmission(models.Model):
-    issue = models.ForeignKey('issues.Issue', db_index=True, null=False, blank=False, on_delete=models.DO_NOTHING)
-    author = models.ForeignKey(User, null=False, blank=False, on_delete=models.DO_NOTHING)
-    file = models.ForeignKey('issues.File', null=False, blank=False, on_delete=models.DO_NOTHING)
+    issue = models.ForeignKey('issues.Issue', db_index=True, null=False, blank=False, on_delete=models.CASCADE)
+    author = models.ForeignKey(User, null=False, blank=False, on_delete=models.CASCADE)
+    file = models.ForeignKey('issues.File', null=False, blank=False, on_delete=models.CASCADE)
 
     run_id = models.CharField(max_length=191, blank=True)
     compiler_id = models.CharField(max_length=191, blank=True)

anytask/courses/migrations/0011_auto_20251026_2354.py

@@ -0,0 +1,70 @@
+# Generated by Django 2.0.13 on 2025-10-26 20:54
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('courses', '0010_auto_20230305_2301'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='course',
+            name='group_with_extern',
+            field=models.ForeignKey(blank=True, db_index=False, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='course_with_extern', to='groups.Group'),
+        ),
+        migrations.AlterField(
+            model_name='course',
+            name='issue_status_system',
+            field=models.ForeignKey(db_index=False, default=1, on_delete=django.db.models.deletion.CASCADE, to='issues.IssueStatusSystem'),
+        ),
+        migrations.AlterField(
+            model_name='course',
+            name='mark_system',
+            field=models.ForeignKey(blank=True, db_index=False, null=True, on_delete=django.db.models.deletion.CASCADE, to='courses.CourseMarkSystem'),
+        ),
+        migrations.AlterField(
+            model_name='course',
+            name='year',
+            field=models.ForeignKey(default=2025, on_delete=django.db.models.deletion.CASCADE, to='years.Year'),
+        ),
+        migrations.AlterField(
+            model_name='defaultteacher',
+            name='course',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to='courses.Course'),
+        ),
+        migrations.AlterField(
+            model_name='defaultteacher',
+            name='group',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, to='groups.Group'),
+        ),
+        migrations.AlterField(
+            model_name='defaultteacher',
+            name='teacher',
+            field=models.ForeignKey(blank=True, db_index=False, null=True, on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='studentcoursemark',
+            name='course',
+            field=models.ForeignKey(db_index=False, on_delete=django.db.models.deletion.CASCADE, to='courses.Course'),
+        ),
+        migrations.AlterField(
+            model_name='studentcoursemark',
+            name='mark',
+            field=models.ForeignKey(blank=True, db_index=False, null=True, on_delete=django.db.models.deletion.CASCADE, to='courses.MarkField'),
+        ),
+        migrations.AlterField(
+            model_name='studentcoursemark',
+            name='student',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='studentcoursemark',
+            name='teacher',
+            field=models.ForeignKey(blank=True, db_index=False, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='teacher_change_mark', to=settings.AUTH_USER_MODEL),
+        ),
+    ]

anytask/courses/models.py

@@ -101,7 +101,7 @@ class Course(models.Model):
         null=False,
         blank=False,
         default=timezone.now().year,
-        on_delete=models.DO_NOTHING,
+        on_delete=models.CASCADE,
     )
 
     is_active = models.BooleanField(db_index=True, null=False, blank=False, default=False)
@@ -138,15 +138,15 @@ class Course(models.Model):
         db_index=False,
         null=True,
         blank=True,
-        on_delete=models.DO_NOTHING,
+        on_delete=models.CASCADE,
     )
 
     mark_system = models.ForeignKey(
         CourseMarkSystem,
         db_index=False,
         null=True,
         blank=True,
-        on_delete=models.DO_NOTHING,
+        on_delete=models.CASCADE,
     )
 
     show_accepted_after_contest_ok = models.BooleanField(db_index=False, null=False, blank=False, default=False)
@@ -163,7 +163,7 @@ class Course(models.Model):
         null=False,
         blank=False,
         default=1,
-        on_delete=models.DO_NOTHING,
+        on_delete=models.CASCADE,
     )
 
     is_python_task = models.BooleanField(db_index=False, null=False, blank=False, default=False)
@@ -302,13 +302,13 @@ def is_contest_integrated(self):
 
 class DefaultTeacher(models.Model):
     teacher = models.ForeignKey(
-        User, db_index=False, null=True, blank=True, on_delete=models.DO_NOTHING
+        User, db_index=False, null=True, blank=True, on_delete=models.CASCADE
     )
     course = models.ForeignKey(
-        Course, db_index=True, null=False, blank=False, on_delete=models.DO_NOTHING
+        Course, db_index=True, null=False, blank=False, on_delete=models.CASCADE
     )
     group = models.ForeignKey(
-        Group, db_index=True, null=True, blank=True, on_delete=models.DO_NOTHING
+        Group, db_index=True, null=True, blank=True, on_delete=models.CASCADE
     )
 
     def __str__(self):
@@ -320,13 +320,13 @@ class Meta:
 
 class StudentCourseMark(models.Model):
     student = models.ForeignKey(
-        User, db_index=True, null=False, blank=False, on_delete=models.DO_NOTHING
+        User, db_index=True, null=False, blank=False, on_delete=models.CASCADE
     )
     course = models.ForeignKey(
-        Course, db_index=False, null=False, blank=False, on_delete=models.DO_NOTHING
+        Course, db_index=False, null=False, blank=False, on_delete=models.CASCADE
     )
     mark = models.ForeignKey(
-        MarkField, db_index=False, null=True, blank=True, on_delete=models.DO_NOTHING
+        MarkField, db_index=False, null=True, blank=True, on_delete=models.CASCADE
     )
 
     teacher = models.ForeignKey(
@@ -335,7 +335,7 @@ class StudentCourseMark(models.Model):
         db_index=False,
         null=True,
         blank=True,
-        on_delete=models.DO_NOTHING,
+        on_delete=models.CASCADE,
     )
     update_time = models.DateTimeField(auto_now=True)  # remove default=timezone.now
 

anytask/courses/tests.py

@@ -2,7 +2,8 @@
 
 import datetime
 
-from django.test import TestCase, override_settings
+from django.db import connection
+from django.test import TestCase, override_settings, TransactionTestCase
 from django.contrib.auth.models import User
 from django.conf import settings
 from schools.models import School
@@ -11,7 +12,7 @@
 from issues.models import Issue, IssueStatus
 from groups.models import Group
 from years.models import Year
-from tasks.models import Task, TaskTaken
+from tasks.models import Task, TaskTaken, TaskGroupRelations
 from tasks.management.commands.check_task_taken_expires import Command as CheckTastTakenExpiresCommand
 
 from bs4 import BeautifulSoup
@@ -963,6 +964,81 @@ def test_set_task_mark_with_student(self):
         self.assertEqual(table_body_sum.span.string.strip().strip('\n'), '3.0')
 
 
+@override_settings(LANGUAGE_CODE='en-EN', LANGUAGES=(('en', 'English'),))
+class DeleteTaskTest(TransactionTestCase):
+    def setUp(self):
+        if connection.vendor == "sqlite":
+            with connection.cursor() as cursor:
+                # We need TransactionTestCase here to run this PRAGMA
+                # Can be deleted after migrating to Django 2.2+
+                # Need this pragma for test_delete_task,
+                # because we got a problems with FK while deleting tasks
+
+                cursor.execute("PRAGMA foreign_keys = ON;")
+
+        self.teacher_password = 'password1'
+        self.teacher = User.objects.create_user(username='teacher',
+                                                password=self.teacher_password)
+        self.teacher.first_name = 'teacher_name'
+        self.teacher.last_name = 'teacher_last_name'
+        self.teacher.save()
+
+        self.student_password = 'password2'
+        self.student = User.objects.create_user(username='student',
+                                                password=self.student_password)
+        self.student.first_name = 'student_name'
+        self.student.last_name = 'student_last_name'
+        self.student.save()
+
+        self.year = Year.objects.create(start_year=2016)
+
+        self.group = Group.objects.create(name='group_name',
+                                          year=self.year)
+        self.group.students.set([self.student])
+        self.group.save()
+
+        seminar_status = IssueStatus(name="seminar", tag=IssueStatus.STATUS_SEMINAR)
+        seminar_status.save()
+        issue_status_system = IssueStatusSystem()
+        issue_status_system.name = "seminar"
+        issue_status_system.save()
+        issue_status_system.statuses.add(seminar_status)
+
+        self.course = Course.objects.create(name='course_name',
+                                            year=self.year,
+                                            issue_status_system=issue_status_system)
+        self.course.groups.set([self.group])
+        self.course.teachers.set([self.teacher])
+        self.course.save()
+
+        self.school = School.objects.create(name='school_name',
+                                            link='school_link')
+        self.school.courses.set([self.course])
+        self.school.save()
+
+    def test_delete_task(self):
+        client = self.client
+        task = Task.objects.create(title='task_title',
+                                   course=self.course,
+                                   score_max=10,
+                                   type=Task.TYPE_SIMPLE)
+
+        task.set_position_in_new_group()
+
+        self.assertTrue(client.login(username=self.teacher.username, password=self.teacher_password))
+        data = {
+            'course_id': task.id,
+            'group_id': self.group.id,
+            'task_deleted[]': task.id,
+            'deleting_ids_from_groups': '{}',
+        }
+        response = client.post("/course/change_table_tasks_pos", data=data)
+        self.assertEqual(response.status_code, 200)
+
+        self.assertEqual(Task.objects.filter(id=task.id).count(), 0)
+        self.assertEqual(TaskGroupRelations.objects.filter(task__id=task.id).count(), 0)
+
+
 class PythonTaskTest(TestCase):
     def setUp(self):
         User.objects.create_user(username="anytask")

anytask/groups/migrations/0004_auto_20251026_2354.py

@@ -0,0 +1,19 @@
+# Generated by Django 2.0.13 on 2025-10-26 20:54
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('groups', '0003_auto_20210228_1721'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='group',
+            name='year',
+            field=models.ForeignKey(blank=True, on_delete=django.db.models.deletion.CASCADE, to='years.Year'),
+        ),
+    ]

anytask/groups/models.py

@@ -5,7 +5,7 @@
 
 
 class Group(models.Model):
-    year = models.ForeignKey(Year, db_index=True, null=False, blank=True, on_delete=models.DO_NOTHING)
+    year = models.ForeignKey(Year, db_index=True, null=False, blank=True, on_delete=models.CASCADE)
     name = models.CharField(max_length=191, db_index=True, null=False, blank=True)
     students = models.ManyToManyField(User, blank=True)
 

anytask/invites/migrations/0004_auto_20251026_2354.py

@@ -0,0 +1,25 @@
+# Generated by Django 2.0.13 on 2025-10-26 20:54
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('invites', '0003_auto_20210228_1721'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='invite',
+            name='generated_by',
+            field=models.ForeignKey(db_index=False, on_delete=django.db.models.deletion.CASCADE, related_name='invite_generated_by', to=settings.AUTH_USER_MODEL),
+        ),
+        migrations.AlterField(
+            model_name='invite',
+            name='group',
+            field=models.ForeignKey(blank=True, db_index=False, null=True, on_delete=django.db.models.deletion.CASCADE, to='groups.Group'),
+        ),
+    ]