Add tests for channel update. #1549

Author: Dallas62

README.md

@@ -381,7 +381,7 @@ To use custom channels, create them at startup and pass the matching `channelId`
       importance: 4, // (optional) default: 4. Int value of the Android notification importance
       vibrate: true, // (optional) default: true. Creates the default vibration patten if true.
     },
-    (created: any) => console.log(`createChannel returned '${created}'`) // (optional) callback returns whether the channel was created, false means it already existed.
+    (created) => console.log(`createChannel returned '${created}'`) // (optional) callback returns whether the channel was created, false means it already existed.
   );
 ```
 

android/src/main/java/com/dieam/reactnativepushnotification/modules/RNPushNotificationHelper.java

@@ -927,7 +927,7 @@ private boolean checkOrCreateChannel(NotificationManager manager, String channel
           channel_description = this.config.getChannelDescription(channel_id);
         }
 
-        if (channel == null || channel.getName() != channel_name || channel.getDescription() != channel_description) {
+        if (channel == null || !channel.getName().equals(channel_name) || !channel.getDescription().equals(channel_description)) {
             // If channel doesn't exist create a new one.
             // If channel name or description is updated then update the existing channel.
             channel = new NotificationChannel(channel_id, channel_name, importance);

example/App.js

@@ -112,6 +112,13 @@ export default class App extends Component {
           }}>
           <Text>Console.Log Scheduled Local Notifications</Text>
         </TouchableOpacity>
+        <TouchableOpacity
+          style={styles.button}
+          onPress={() => {
+            this.notif.createOrUpdateChannel();
+          }}>
+          <Text>Create or update a channel</Text>
+        </TouchableOpacity>
 
         <View style={styles.spacer}></View>
 

example/NotifService.js

@@ -4,6 +4,7 @@ import NotificationHandler from './NotificationHandler';
 export default class NotifService {
   constructor(onRegister, onNotification) {
     this.lastId = 0;
+    this.lastChannelCounter = 0;
 
     NotificationHandler.attachRegister(onRegister);
     NotificationHandler.attachNotification(onNotification);
@@ -20,6 +21,21 @@ export default class NotifService {
     });
   }
 
+  createOrUpdateChannel() {
+    this.lastChannelCounter++;
+    PushNotification.createChannel(
+      {
+        channelId: "custom-channel-id", // (required)
+        channelName: `Custom channel - Counter: ${this.lastChannelCounter}`, // (required)
+        channelDescription: `A custom channel to categorise your custom notifications. Updated at: ${Date.now()}`, // (optional) default: undefined.
+        soundName: "default", // (optional) See `soundName` parameter of `localNotification` function
+        importance: 4, // (optional) default: 4. Int value of the Android notification importance
+        vibrate: true, // (optional) default: true. Creates the default vibration patten if true.
+      },
+      (created) => console.log(`createChannel returned '${created}'`) // (optional) callback returns whether the channel was created, false means it already existed.
+    );
+  }
+
   localNotif(soundName) {
     this.lastId++;
     PushNotification.localNotification({

example/android/app/src/main/AndroidManifest.xml

@@ -53,13 +53,6 @@
                   android:value="Super channel description"/>
       <meta-data  android:name="com.dieam.reactnativepushnotification.notification_color"
                   android:resource="@android:color/white"/>
-
-
-
-      <meta-data  android:name="com.dieam.reactnativepushnotification.notification_channel_name.rn-push-notification-channel-id-4-300"
-                  android:value="Example-Channel silent"/>
-      <meta-data  android:name="com.dieam.reactnativepushnotification.notification_channel_description.rn-push-notification-channel-id-4-300"
-                  android:value="Super channel description for silent channel"/>
     </application>
 
 </manifest>

example/package.json

@@ -14,7 +14,7 @@
     "@react-native-community/push-notification-ios": "^1.2.2",
     "react": "16.11.0",
     "react-native": "0.62.2",
-    "react-native-push-notification": "git+https://[email protected]/zo0r/react-native-push-notification.git"
+    "react-native-push-notification": "zo0r/react-native-push-notification#dev"
   },
   "devDependencies": {
     "@babel/core": "^7.9.0",