Skip to content

Commit c42e206

Browse files
zodernunknown
authored andcommitted
Depreciate app.docker.imageFrontendServer
1 parent ad7a419 commit c42e206

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

docs/docs.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,6 @@ module.exports = {
123123
'--memory-reservation 200M'
124124
],
125125

126-
// Only used if using your own SSL certificates.
127-
// Default is "meteorhacks/mup-frontend-server" (optional)
128-
imageFrontendServer: 'meteorhacks/mup-frontend-server',
129-
130126
// lets you bind the docker container to a
131127
// specific network interface (optional)
132128
bind: '127.0.0.1',

docs/migrating.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Migrating to newer mup versions
22

3-
Always run `mup setup` when updating Meteor Up.
3+
Always run `mup setup` after updating Meteor Up.
44

55
## 1.4
66

77
### Depreciations
8-
`meteor.ssl` and `meteor.nginx` is depreciated. It uses a different implementation for custom certificates and lets encrypt, each with different features and restrictions. Also, the custom certificate implementation has security problems. The reverse proxy should be used instead. It doesn't have the security problems, uses the same implementation for custom certificates and lets encrypt, and has many additional features. Learn how to use the [reverse proxy in the docs](http://meteor-up.com/docs#reverse-proxy).
8+
`meteor.ssl`, `meteor.nginx`, and `meteor.docker.imageFrontendServer` are depreciated. It uses a different implementation for custom certificates and lets encrypt, each with different features and restrictions. Also, the custom certificate implementation has security problems. The reverse proxy should be used instead. It doesn't have the security problems, uses the same implementation for custom certificates and lets encrypt, and has many additional features. Learn how to use the [reverse proxy in the docs](http://meteor-up.com/docs#reverse-proxy).
99

10-
`proxy.shared.clientUploadLimit` is depreciated. Use `proxy.clientUploadLimit` instead, which allows each app to have a different clientUploadlimit.
10+
`proxy.shared.clientUploadLimit` is depreciated. Use `proxy.clientUploadLimit` instead, which allows each app to have a different value.

src/plugins/meteor/validate.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,5 +134,14 @@ export default function(
134134
);
135135
}
136136

137+
if (config.app.docker && config.app.docker.imageFrontendServer) {
138+
details = addDepreciation(
139+
details,
140+
'docker.imageFrontendServer',
141+
'Use the reverse proxy instead',
142+
'https://git.io/vN5tn'
143+
);
144+
}
145+
137146
return addLocation(details, config.meteor ? 'meteor' : 'app');
138147
}

0 commit comments

Comments
 (0)