Skip to content

Commit 7ed55ed

Browse files
committed
disable erase function
1 parent 4c5e8ee commit 7ed55ed

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

zarr-eio/src/storage.ml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,14 +213,15 @@ module HttpStore = struct
213213
in
214214
set t key (List.fold_left f ov rsv)
215215

216-
let erase t key =
216+
(*let erase t key =
217217
Eio.Switch.run @@ fun sw ->
218218
let url = Uri.with_path t.base_url key in
219219
let resp, _ = Client.delete ~sw t.client url in
220220
match Http.Response.status resp with
221221
| #Http.Status.success -> Deferred.return_unit
222-
| e -> raise_status_error e
222+
| e -> raise_status_error e *)
223223

224+
let erase _ = raise Not_implemented
224225
let erase_prefix _ = raise Not_implemented
225226
let list _ = raise Not_implemented
226227
let list_dir _ = raise Not_implemented

zarr-sync/test/test_sync.ml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,7 @@ let _ =
315315
assert_raises
316316
(HttpStore.Request_failed (404, "fakegroup/zarr.json not found"))
317317
(fun () -> HttpStore.Array.metadata store Node.Array.(gnode / "fakegroup"));
318+
assert_raises HttpStore.Not_implemented (fun () -> HttpStore.Array.reshape store anode [|25;32;20|]);
318319
assert_raises HttpStore.Not_implemented (fun () -> HttpStore.Array.rename store anode "newname");
319320
assert_raises HttpStore.Not_implemented (fun () -> HttpStore.Group.children store gnode);
320321
assert_raises HttpStore.Not_implemented (fun () -> HttpStore.hierarchy store);

zarr/src/storage/http.ml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,14 +112,15 @@ module Make (Deferred : Types.Deferred) (C : C with type 'a io = 'a Deferred.t)
112112
set t key (List.fold_left f ov rsv)
113113

114114
(* make reshaping arrays possible *)
115-
let erase t key =
115+
(*let erase t key =
116116
let tries = t.tries and client = t.client and config = t.config in
117117
let url = t.base_url ^ key in
118118
let+ res = C.http ~tries ~client ~config ~url ~meth:DELETE () in
119119
match fold_result res with
120-
| {code; _} when code = 200 -> ()
121-
| {code; body; _} -> raise (Request_failed (code, body))
120+
| {code; _} when code = 200 || code = 404 -> ()
121+
| {code; body; _} -> raise (Request_failed (code, body)) *)
122122

123+
let erase _ = raise Not_implemented
123124
let erase_prefix _ = raise Not_implemented
124125
let list _ = raise Not_implemented
125126
let list_dir _ = raise Not_implemented

0 commit comments

Comments
 (0)