Bring types in from API dependency #137
Closed
TonyGravagno
started this conversation in
Ideas
Replies: 2 comments
-
|
No, it's also used by https://github.com/zokugun/vscode-cobol-folding |
Beta Was this translation helpful? Give feedback.
0 replies
-
I've already made the change. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In my local version of the extension, I brought in the ExplicitFoldingHub and ExplicitFoldingConfig interfaces, and made them types. All files now refer to this internal file. That's all that's required to eliminate the dependency on @zokugun/vscode.explicit-folding-api.
Would you accept a PR with this?
This would eliminate the need to publish both packages for the one extension, and would eliminate the problem that I fixed in my recent PR to the API repo.
Beta Was this translation helpful? Give feedback.
All reactions