bug fixed

Author: dravenk

src/url.zig

@@ -58,7 +58,10 @@ const SliceReader = struct {
     fn readUntil(self: *Self, comptime predicate: fn (u8) bool) []const u8 {
         const start = self.offset;
         var end = start;
-        while (end < self.slice.len and !predicate(self.slice[end])) {
+        while (end < self.slice.len) {
+            if (predicate(self.slice[end])) {
+                break;
+            }
             end += 1;
         }
         self.offset = end;
@@ -78,6 +81,9 @@ pub fn parseUrl(self: *URL, text: []const u8) ParseError!*URL {
     if ((reader.peek() orelse 0) == '?') { // query part
         std.debug.assert(reader.get().? == '?');
         self.query = reader.readUntil(isQuerySeparator);
+        if (self.values == null) {
+            self.values = std.StringHashMap(std.ArrayList([]const u8)).init(self.allocator);
+        }
         try parseQuery(&self.values.?, self.query.?);
     }
 

src/url_test.zig

@@ -98,3 +98,56 @@ test "RFC example 1" {
     const vm = qm.get("name").?;
     try testing.expectEqualStrings("ferret", vm.items[0]);
 }
+
+test "edge case - empty path" {
+    const text = "";
+    var url = URL.init(.{ .allocator = std.testing.allocator });
+    defer url.deinit();
+    const result = try url.parseUrl(text);
+    try testing.expectEqualStrings("", result.path);
+}
+
+test "edge case - path only" {
+    const text = "/path";
+    var url = URL.init(.{ .allocator = std.testing.allocator });
+    defer url.deinit();
+    const result = try url.parseUrl(text);
+    try testing.expectEqualStrings("/path", result.path);
+}
+
+test "edge case - path at end of string" {
+    const text = "/very/long/path/that/ends/without/query/or/fragment";
+    var url = URL.init(.{ .allocator = std.testing.allocator });
+    defer url.deinit();
+    const result = try url.parseUrl(text);
+    try testing.expectEqualStrings("/very/long/path/that/ends/without/query/or/fragment", result.path);
+}
+
+test "edge case - single character" {
+    const text = "a";
+    var url = URL.init(.{ .allocator = std.testing.allocator });
+    defer url.deinit();
+    const result = try url.parseUrl(text);
+    try testing.expectEqualStrings("a", result.path);
+}
+
+test "boundary condition - path at string end" {
+    // This test specifically targets the boundary condition that was causing segfault
+    const text = "/api/users";
+    var url = URL.init(.{ .allocator = std.testing.allocator });
+    defer url.deinit();
+    const result = try url.parseUrl(text);
+    try testing.expectEqualStrings("/api/users", result.path);
+    // Note: query and fragment are undefined by default, not null
+    // We just need to ensure the path is parsed correctly
+}
+
+test "boundary condition - path with query at end" {
+    const text = "/api/users?name=john";
+    var url = URL.init(.{ .allocator = std.testing.allocator });
+    defer url.deinit();
+    const result = try url.parseUrl(text);
+    try testing.expectEqualStrings("/api/users", result.path);
+    try testing.expectEqualStrings("name=john", result.query.?);
+    // Note: fragment is undefined by default, not null
+}